a7dc566aaa
Many of these classes would be fine under the "rule of 0", except that the chrome plugin insists on out-of-line destructors, etc. Unfortunately, the plugin is not also insisting on out-of-line move constructors or move-assign operators, so these become deleted in the presence of the other user-defined methods. In turn, this makes std::move() call silently turn into copies. Bug: 364788123 Change-Id: I070957041894dd48cb604e6eee67d1e321cfc3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5846757 Commit-Queue: Tom Sepez <tsepez@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Nico Weber <thakis@chromium.org> Owners-Override: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1354134}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.