0
Files
src/docs/chromeos
Darren Shen 0e1f621511 Call out BrowserContext in ash code location guidelines.
In one section, the guidelines say:

  Instead of using ProfileKeyedServiceFactory (in //chrome), consider
  using BrowserContextKeyedServiceFactory (in //components) instead.

But in the "Desired State" section, it says:

  The //content directory is the API for building a web browser. Even
  though Ash does use web technology for rendering many things, it is
  not itself a web browser and there should be no OS code in this
  directory or calling directly into it.

And also:

  New features should be designed to adhere to the “desired state” as
  closely as practical.

To resolve some confusion here, explicitly call out BrowserContext as
allowed despite contradicting the desired state.

Change-Id: Iba72f48d9dc054d5012325bc4f384d036cc68b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093907
Reviewed-by: Michael Cui <mlcui@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1396991}
2024-12-16 14:12:03 -08:00
..