65c9dca85e
Currently if a user has multiple displays and clicks/taps the new desk button, there is a DeskNameView that is created on each display for the new desk. Additionally, all of these DeskNameViews request focus, leading to unexpected behavior. What should happen is that the newly created DeskNameView on the same DesksBarView as the button that was clicked/tapped should be focused. This CL fixes this bug by adding a field to the DesksBarView, which is set when a new desk button is clicked. Only the DesksBarView with this new field will have its newly created name view focused. Test: added Bug: 1206013 Change-Id: I63b7cb3594a5c6a63ec015e4b0d00ac1dcd740a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2877734 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#881308}
Ash
Ash is the "Aura Shell", the window manager and system UI for Chrome OS. Ash uses the views UI toolkit (e.g. views::View, views::Widget, etc.) backed by the aura native widget and layer implementations.
Ash sits below chrome in the dependency graph (i.e. it cannot depend on code in //chrome). Code outside of Ash should depend solely on Ash's public interface, which is in ash/public.
Tests
Tests should be added to the ash_unittests target.
Tests can bring up most of the ash UI and simulate a login session by deriving from AshTestBase. This is often needed to test code that depends on ash::Shell and the controllers it owns.
Test support code (TestFooDelegate, FooControllerTestApi, etc.) lives in the same directory as the class under test (e.g. //ash/foo rather than //ash/test). Test code uses namespace ash; there is no special "test" namespace.
Prefs
Ash supports both per-user prefs and device-wide prefs. These are called "profile prefs" and "local state" to match the naming conventions in chrome. Ash also supports "signin screen" prefs, bound to a special profile that allows users to toggle features like spoken feedback at the login screen.
Pref names are in //ash/public/cpp so that code in chrome can also use the names. Prefs are registered in the classes that use them because those classes have the best knowledge of default values.
Historical notes
Ash shipped on Windows for a couple years to support Windows 8 Metro mode. Windows support was removed in 2016.
The mash (some times called mus-ash or mustash) project was an effort to move ash into its own process and the browser in its own process. Communication between the two processes was done over mojo. Windowing was done using the window-service (some times called mus), which ran with Ash. Many of the mojo interfaces have been converted to pure virtual interfaces, with the implementation in ash. The mash project was stopped around 4/2019.