ac8c360346
Double-click text selection at the end of a page is a literal edge case that PDFiumEngine::OnMultipleClick() does not handle correctly. This method creates a PDFiumRange where the character index is out of bounds. In older code, this would have triggered a DCHECK() failure, but not crash when DCHECKs are turned off. After https://crrev.com/1417508, the DCHECK() failure still happens. When DCHECKs are turned off, code execution eventually triggers a crash, because that CL assumed the character index is never out of bounds. Add a test case that triggers this crash, and fix the crash by calculating the character index correctly in OnMultipleClick(). Additionally: 1) Add another test case for double clicking on a blank page, to help provide more test coverage, and to show OnMultipleClick() does not need to handle pages with no text. 2) Upgrade a cheap DCHECK_GE() to CHECK_GE(). Bug: 401992988 Change-Id: I60e1a4afb7cbb956205ce8f304b15701cf762ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347717 Reviewed-by: Andy Phan <andyphan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1431938}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.