
Make PDFiumEngine::AppendPage() check its input parameters, instead of the caller. Change these DCHECKs into CHECKs, per modern coding guidance, since they are cheap to run. This also helps to catch a rare crash where it looks as though the impossible has happened. Bug: 1488743 Change-Id: Ia491b20b771beebc0cd968908873228793e86698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903239 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Nigi <nigi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1204952}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.