da0e16b5b9
The style guide (now) requires that non-optional input parameters be references, since references cannot be null. https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs In service of this, I also added some explicit DCHECKs to double-check that the existing pointer usage wasn't handling nullptrs unexpectedly. In all cases, if the new DCHECK fails, that means that the previous code would have dereferenced a nullptr, which is UB (so a controlled crash is preferable). Change-Id: I4742f9331bebea80ff1f177ee67e1c30e45dbaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6402694 Reviewed-by: Aaron Selya <selya@google.com> Commit-Queue: Aaron Selya <selya@google.com> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/main@{#1438810}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.