
sdefresne spotted many useless #includes of abseil optional. This patches removes them all (patchset 1) Script: ``` cd components # This returns the list of files not using absl::optional, but having the # include. comm -13 \ <( ( git grep -l "std::make_optional"; git grep -l "std::optional"; git grep -l "std::nullopt"; git grep -l "std::in_place"; git grep -l "std::in_place_t"; ) | cut -f1 -d: \ | grep \ -e "\.h" \ -e "\.cc" \ -e "\.mm" \ | sort \ | uniq ) \ <( ( git grep "#include <optional>" ) | cut -f1 -d: \ | grep \ -e "\.h" \ -e "\.cc" \ -e "\.mm" \ | sort \ | uniq ) \ | xargs sed -i "s/#include <optional>//g" cd .. echo "Formatting" echo "IncludeBlocks: Regroup" >> ".clang-format" echo "IncludeIsMainRegex: \"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\"" >> ".clang-format" git cl format git restore ".clang-format" git cl format ``` Bug: chromium:1500249 Change-Id: I523daa869a4d6be90603691845aa679d9e1a9ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237129 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1274979}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.