
This relands commitc2e2051b47
. Reason for reland: Fix interactions with PWA windows by maintaining the observation pattern without interfering with the normal event propagation chain. In the above commit,*was_handled = true will be set after observation Stop event propagation after being observed by UserNotActivePrecondition and stop subsequent handlers from processing the event. The current implementation allows the EventMonitorMac to monitor events without interfering with normal event processing. after change: https://drive.google.com/file/d/1GvwOFuRCtBBLNuQfVDsNVUhmKsUCFRIa/view?usp=sharing Original change's description: > Revert "Support dismiss behavior for download bubble in dpwa on Mac" > > This reverts commitc2e2051b47
. > >Reason for revert: Causes keyboard inputs to not work in PWAs in fullscreen mode. See b/404035584 for more details. Verified locally that this CL is indeed the root cause by reverting this git commit. > >Original change's description: >> Support dismiss behavior for download bubble in dpwa on Mac >> >> implemented view::EventMonitor to support remote cocoa use. It will use NativeWidgetMacEventMonitor to add a local monitor to call in the app shim process if needed. >> >> >> Bug: 383770516 >> Change-Id: I5c2b2694d573a0729621efa807823a58874dabd6 >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304269 >> Reviewed-by: Leonard Grey <lgrey@chromium.org> >> Commit-Queue: Elyssa Sun <sunelyssa@microsoft.com> >> Reviewed-by: Lily Chen <chlily@chromium.org> >> Reviewed-by: Keren Zhu <kerenzhu@chromium.org> >> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> >> Cr-Commit-Position: refs/heads/main@{#1432168} > >Bug: 383770516 >Change-Id: I75965f811675cbaee8639e8540e77565aae04ab1 >Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6363058 >Commit-Queue: Mike Wasserman <msw@chromium.org> >Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> >Reviewed-by: Mike Wasserman <msw@chromium.org> >Reviewed-by: Leonard Grey <lgrey@chromium.org> >Auto-Submit: Dibyajyoti Pal <dibyapal@chromium.org> >Cr-Commit-Position: refs/heads/main@{#1433863} Bug: 383770516 Change-Id: Ic3afccdfa084019a2c30d9a9c468c91c600a7bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6370794 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Lily Chen <chlily@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elyssa Sun <sunelyssa@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1437280}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.