
Extends chrome_pdf::DocumentLayout::Options with a field for the UI direction (left-to-right or right-to-left). This allows the viewer UI to communicate the UI direction to the plugin. (This information is available from base::i18n::IsRTL() in unseasoned mode, but is not available to the Pepper plugin. In any case, it could be useful to make it togglable in the PDF viewer.) The UI direction field could have been added to the viewport message directly, but it likely will be useful to support RTL page layouts in the future. Also adds some serialization and deserialization tests, now that Options serializes to and from base::Value. Also had to fix a bug with dirty layout options triggering layout before document loading finished. Bug: 1158670 Change-Id: Iaa7cfccacfe54858a53d6e28b07f786332d7e9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202535 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/main@{#927933}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.