e92713cf27
Since FPDFAttachment_GetFile() returns false when it fails to retrieve data from an invalid attachment, this CL adds an |is_readable| flag in DocumentAttachmentInfo to indicate whether an attachment's data can be retrieved successfully. If |is_readable| gets set to false, the attachment's |size_bytes| will remain at its default value of 0. This CL adds test files embedded_attachments_invalid_data.in and embedded_attachments_invalid_data.pdf, which contain invalid attachments. The CL also adds unit tests to check whether |is_readable| flags are set correctly when loading DocumentAttachmentInfo from both valid and invalid attachments. Bug: 177188 Change-Id: Idaef5820d760a837048f96f810f892660216f4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240909 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#787251}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.