f7f53b43e9
V8 has its own command line flag mechanism, and V8-relevant base::Feature flags are defined in gin and passed through to V8 during gin initialization. This has the consequence that V8 flags need to be defined twice to be controllable via Chromium's variations mechanism -- once in V8 for their functionality, and once in Blink/gin just for pass-through. This adds overhead when wanting to A/B test V8 flags, and can cause issues if an enabled V8 flag needs to be disabled via kill switch (namely, we have to make sure that there exists a base::Feature equivalent of the flag that we can disable). It also causes some confusion about where the canonical default feature state exists (in Blink or V8). This CL introduces a generic `V8Flags_` prefix for features in the FeatureList. The gin initializer walks all feature overrides, and any `V8Flags_foo` feature that is overridden to enabled is passed through to V8 as a `--foo` flag (and disabled features are passed through as `--no-foo`). This will allow us to, effectively, expose all V8 flags as a pseudo base::Feature, without needing Chromium-side changes to expose such flags to Finch. Change-Id: Id88beafb8688d9f046706b0a67e23ad94d08a7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873788 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#1361715}
v8
@ a2e6c5079d
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.