fcb5eea9fe
XHR detection when used across iframes was broken because the frame owning the last_interacted_form_ would not correspond to the frame where form deletion really happened. A fix is to keep the last_interacted_form_ updated for the renderer form in the child frame, then forward the submit signal to the router when XHR submission is detected (from the last interacted form being removed). An alternative solution was to wait for the entire browser form to be deleted but this makes the saving of profile information impossible because once the browser form is fully deleted there isn't any profile data left for saving. One concern we had is that detecting XHR when deleting renderer forms could spam a lot form submissions but this is actually not likely to happen because the deleted form must correspond to a last_interacted_form_ which will moderate the quantity of submissions. Also, to be extra cautious, interactions are cleaned up in all frames that are part of the same form tree, to prevent spamming XHR from forms in child frames that were interacted with in the past prior to submitting the xframe form. Change-Id: Ib8be7a6c609c53725a26a35cb15fc803a30d3aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352167 Reviewed-by: Ernesto Izquierdo Clua <eic@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/main@{#1433762}
v8
@ 1459266e28
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.