
DragDownloadFileUI::InitiateDownload
.
This CL propagates the initiator origin via `content::DragDownloadFile::DragDownloadFileUI::InitiateDownload` into `download::DownloadUrlParameters::set_initiator`. Note that the initiator origin comes from trustworthy, browser-side data: - `RenderFrameHostImpl::StartDragging` passes `GetLastCommittedOrigin()` into `RenderViewHostDelegateView::StartDragging` - `WebContentsViewAura::StartDragging` stores the origin into into `ui::OSExchangeDataProviderFactory` using a call to `ui::OSExchangeDataProviderFactory::MarkRendererTaintedFromOrigin`. On Windows this CL takes the origin from `OSExchangeDataProviderFactory` and passes it directly into `DragDownloadFile`'s constructor. - `WebContentsViewMac::StartDragging` ends up storing the origin in `WebDragSource` from `web_drag_source_mac.mm`. On Mac this CL takes this origin and also passes it (indirectly, via mojo) into `DragDownloadFile`'s constructor. @lukasza has manually tested this CL on Windows using the repro steps from https://crbug.com/40060358 (@dcheng has kindly tried the repro steps on Mac). Note that `DragDownloadFile` is used on Windows and Mac, but not on Linux (i.e. the repro wouldn't have worked on Linux). Fixed: 40060358 Change-Id: I24b180473e140cbb8a56640444f2f4a306aa42fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5692867 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1327773}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.