chromium/src
0
Fork 0
Code Activity

Revert "Modify markdown to satisfy Windows Defender"

Browse Source 
This reverts commit f17419f416.

Reason for revert: Microsoft responded to twitter reports and fixed
their detection so this isn't needed anymore. I'm retaining the typo
fix though!

Original change's description:
> Modify markdown to satisfy Windows Defender
> 
> debugging_gpu_related_code.md explains how to use a Chrome command-line
> switch which has been used for arbitrary code execution. Windows
> Defender therefore treats it as malware. This means that some Windows
> Chromium developers will get anti-virus warnings (with mandatory
> quarantining of the file). If Chrome is in a directory that is
> excluded from scanning then they will avoid warnings but will hit
> problems if they try to use Windows backup.
> 
> This is all very silly since there is no way - short of manually
> following the steps, modify to be malicious - to activate this payload.
> Windows Defender even complains about the file created by this:
> 
>   > echo --no-sandbox --gpu-launcher="x" >foo.txt
> 
> But, sometimes it's not worth arguing.
> 
> This also fixes a typo.
> 
> R=​kainino@chromium.org
> BUG=851562
> 
> Change-Id: I85403a1cb1667f45784684179927119058608d40
> Reviewed-on: https://chromium-review.googlesource.com/1096311
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566245}

TBR=brucedawson@chromium.org,kainino@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 851562
Change-Id: I60b09d8e6a698c1646f5c4bb0ecab16f999bfb9c
Reviewed-on: https://chromium-review.googlesource.com/1100255
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567294}
This commit is contained in:
Bruce Dawson
2018-06-14 16:22:23 +00:00
committed by Commit Bot
parent b70d8c27e5
commit a33b7c45d8
1 changed files with 4 additions and 6 deletions

10
docs/gpu/debugging_gpu_related_code.md

@ -197,17 +197,15 @@ after that. All of them go through `gpu::gles2::GLES2DecoderImpl::DoCommand`.
To actually debug the GPU process:
On Linux this works for me (the quotes around launcher can be omitted - they are
there to stop Windows Defender from complaining about this file):
On Linux this works for me:
* `out/Debug/chromium --no-sandbox --gpu-"launcher"="xterm -e gdb --args"
* `out/Debug/chromium --no-sandbox --gpu-launcher="xterm -e gdb --args"
http://localhost:8000/page-to-repro.html`
On OSX this works for me (the quotes around launcher can be omitted - they are
there to stop Windows Defender from complaining about this file):
On OSX this works for me:
* `out/Debug/Chromium.app/Contents/MacOSX/Chromium --no-sandbox
--gpu-"launcher"="xterm -e gdb --args"
--gpu-launcher="xterm -e gdb --args"
http://localhost:8000/page-to-repro.html`
On Windows I use `--gpu-startup-dialog` and then connect to the listed process.