chromium/src
0
Fork 0
Code Activity

Translate caps lock strings.

Browse Source 
Bug: b:345303965
Change-Id: Ia1a4aeb68e62e6c7c22434696fd4897d0fc58de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5759574
Reviewed-by: Michelle Chen <michellegc@google.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1337680}
This commit is contained in:
Darren Shen
2024-08-06 05:43:50 +00:00
committed by Chromium LUCI CQ
parent a0dd6b706e
commit c024517ff2
5 changed files with 11 additions and 8 deletions

4
ash/ash_strings.grd

@ -7378,11 +7378,11 @@ New install
desc="This string appears in a selectable menu item in a menu. When selected, it navigates to another page where users can enter mathematical calculations or unit conversions (e.g. '1 + 1' or '1 meter to feet').">
Calculations
</message>
<message name="IDS_PICKER_CAPS_ON_CATEGORY_LABEL" translateable="false"
<message name="IDS_PICKER_CAPS_LOCK_ON_MENU_LABEL"
desc="This string appears as a selectable menu item in a menu. When selected, it turns on the user's keyboard Caps Lock.">
Turn on Caps Lock
</message>
<message name="IDS_PICKER_CAPS_OFF_CATEGORY_LABEL" translateable="false"
<message name="IDS_PICKER_CAPS_LOCK_OFF_MENU_LABEL"
desc="This string appears a selectable menu item in a menu. When selected, it turns off the user's keyboard Caps Lock.">
Turn off Caps Lock
</message>

1
ash/ash_strings_grd/IDS_PICKER_CAPS_LOCK_OFF_MENU_LABEL.png.sha1 Normal file

@ -0,0 +1 @@
0224eecbcfed78da9adc4ef9a2ecdaea4290fa35

1
ash/ash_strings_grd/IDS_PICKER_CAPS_LOCK_ON_MENU_LABEL.png.sha1 Normal file

@ -0,0 +1 @@
0547e28b8c232007273fe27d5277983de035a051

9
ash/picker/search/picker_action_search.cc

@ -57,10 +57,11 @@ std::vector<PickerSearchResult> PickerActionSearch(
}
}
if (IsMatch(tokenized_query, l10n_util::GetStringUTF16(
options.caps_lock_state_to_search
? IDS_PICKER_CAPS_ON_CATEGORY_LABEL
: IDS_PICKER_CAPS_OFF_CATEGORY_LABEL))) {
if (IsMatch(tokenized_query,
l10n_util::GetStringUTF16(
options.caps_lock_state_to_search
? IDS_PICKER_CAPS_LOCK_ON_MENU_LABEL
: IDS_PICKER_CAPS_LOCK_OFF_MENU_LABEL))) {
matches.push_back(
PickerSearchResult::CapsLock(options.caps_lock_state_to_search));
}

4
ash/picker/views/picker_section_view.cc

@ -304,8 +304,8 @@ std::unique_ptr<PickerItemView> PickerSectionView::CreateItemFromResult(
auto item_view = std::make_unique<PickerListItemView>(
std::move(select_result_callback));
item_view->SetPrimaryText(l10n_util::GetStringUTF16(
data.enabled ? IDS_PICKER_CAPS_ON_CATEGORY_LABEL
: IDS_PICKER_CAPS_OFF_CATEGORY_LABEL));
data.enabled ? IDS_PICKER_CAPS_LOCK_ON_MENU_LABEL
: IDS_PICKER_CAPS_LOCK_OFF_MENU_LABEL));
item_view->SetLeadingIcon(ui::ImageModel::FromVectorIcon(
data.enabled ? kPickerCapsLockOnIcon : kPickerCapsLockOffIcon,
cros_tokens::kCrosSysOnSurface));