Previous instructions in 2530745 installed the whole espeak-ng tarball,
and not just the chrome-extension/ directory, under
/usr/share/chromeos-assets/speech_synthesis/espeak-ng .
Moreover attempt to provide instructions which would work on standard
linux / rodete to create the directory and set the permissions correctly.
R=dmazzoni@chromium.org, dtseng@chromium.org
Signed-off-by: Guido Trotter <ultrotter@chromium.org>
Change-Id: I41193bf02374f0bdde55371619ed4db72dae63e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536434
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827571}
This moves the voice ranking from chrome into content.
TtsControllerDelegate is now optional, and *only* used on ChromeOS. The
logic for looking up prefs remains in the chrome implementation, but is
expressed differently so that all the ranking can be in content.
BUG=1025626
TEST=covered by existing tests
Change-Id: Ib105fe91452dea791e992eb6c70fa7f1d2789985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781702}
This extension will be used by any ash accessibility feature
which wants some information about the accessibility tree.
This is a pure rename with no functional changes.
AX-Relnotes: n/a
Bug: 960373
Change-Id: I2ca9db321fce6c44dfb374ca3c690986591acd96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252037
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780890}
This change moves the libbrlapi loader from
build/linux/libbrlapi
to
third_party/libbrlapi.
libbrlapi.h corresponds directly to the version of brltty we ship in Chrome OS. Prior to this change, libbrlapi.h appears to be obtained from
build/linux/debian*
While the above is fairly recent, it can diverge from the version in Chrome OS.
For example, we're currently running brltty6.1 but the headers above are for 6.0.
This also let's us specify the exact .so to load. Since we only expect Chrome OS to use libbrlapi, we shouldn't need to support multiple versions of the .so.
R=dmazzoni@chromium.org
Change-Id: I7676f0c7b557adf4f572ac7a9f352ac0582d6240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189251
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769469}
ChromeOS expects the eSpeak files to be at /usr/share/.../espeak-ng,
but the original copy command in the documentation put the files inside
a subdirectory called chrome-extension.
Bug: none
Change-Id: Id956921a959643a2a71951fdfd49de1fa97835f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189659
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#767336}
Things have changed recently and we no longer use the legacy IPC
messages to communicate between the browser and the renderer, and
we even introduce a new class (RenderAccessibilityManager), so we
need to update the documentation to keep it being accurate.
Bug: 1010831
Change-Id: Ib41883f8356c2114d17e6b606989e9a54dd54d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160468
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761469}
Since AutoclickMenuPosition contains quite generic values, which can be
reused by other floating menus, we should rename it to better indicate
its properties.
Bug: 1061068
Change-Id: Ifb58be11de2fa4163fc2e9a4f37a4b9c9bdc43b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141928
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757811}
This CL adds a new test case for a html structure with a link that has
a nested structure. This adds the expected outputs for auralinux and
blink, and updates some README files to be more descriptive and to
update them to be in-line with current test names.
Added a basic nested structure for <a href> links for future test case.
Added test case for the nested structure a link html.
Generated expected results for new nested structure <a href> tests.
Ran code formatter to complete checklist before raising CL.
Updated README to fix typo and incorrect command, added more info.
Updated tests.md readme to fix same typo as in unit_test readme file.
R=dmazzoni
Bug: 1018555
Change-Id: Ibdea155e586d7b4c00fa31b86d6209f1f63b0195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951781
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#722543}
As part of a transition to share code and tooling more easily between
ChromeVox, Switch Access, Select-to-Speak, autoclick, and any future
accessibility component extensions, move them into a shared
accessibility/ directory in chrome/browser/resources/chromeos.
Bug: 706981
Change-Id: Icaec4981380ac37e42d12706c2ec5693f58c334c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913122
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717744}
This is a small fix for a subtle bug.
The way touch exploration works on Android is complicated:
* When the user taps or drags their finger, our View gets a hover event.
* Accessibility code sends a hit test action to the renderer process
* The renderer process fires a HOVER accessibility event on the accessibility
node at that coordinate
* WebContentsAccessibilityImpl.handleHover is called with that node. We fire
an Android TYPE_VIEW_HOVER_ENTER event on that node and a
TYPE_VIEW_HOVER_EXIT event on the previous node.
* Finally, TalkBack sets accessibility focus to that node.
As the user continues to drag their finger, we get lots of hover events
on the view, but often the finger is over the same node. To prevent
repeatedly firing TYPE_VIEW_HOVER_ENTER on the same node, we keep track
of the last hover id in mLastHoverId.
The problem with this was that if you moved accessibility focus somewhere
else - like tapping outside of the web view, or swiping to a different element,
we weren't clearing mLastHoverId, so if you subsequently tapped on the same
element, we'd suppress it (incorrectly).
The fix is just to clear mLastHoverId and fire the
TYPE_VIEW_HOVER_EXIT whenever we're told to clear accessibility focus
from the last node that was hovered. Then if the user subsequently
taps on that node we'll send the right event and let them focus it again.
Bug: 769736
Change-Id: I68f4c522bd6fe76657a5624abe291a45e7aafe58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874502
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708729}
The ax_enums file has moved from .idl to .mojom.
This change fixes all current outdates references to old .idl filename.
R=aboxhall,dmazzoni,dtseng
Change-Id: I31069ebfec2a37432a9c868c5758734b8b32d1c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855062
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705468}
This change directs Chrome's shared library loader to look for the latest .7 version of libbrlapi.so without which an upgrade to Brltty 6.0 completely breaks Chrome from loading libbrlapi.
It also adds some notes to our public docs for future persons who wish to investigate failures during upreving.
Change-Id: I07967831cd2e6a39f34a16b555a3c95b62966bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802214
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696574}
Specifically:
* Mentions of specific locations in the code now link to that part of
the code.
* Command line examples that span multiple commands were condensed
into a single line for easier copying into terminals.
* A Markdown formatter was run over the file, mostly just changing
line lengths to get closer to 80 characters.
Change-Id: I3d6694fc186008866441bf7a8255d63c10687d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579861
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#655831}
In particular, the following were changed:
* Reduce wordiness.
* Run mdformat.
* Remove information about SCOPED_TRACE(), since that appears to be
outdated (or maybe just misleading).
* Replace section on Google-internal script with link to internal
Chrome A11y page on the topic.
Change-Id: I94e3a47f435f092b225a60ae2e35c06ddba8d2ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555417
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652853}
NodeIndex() is O(n) and the difference is measurable if a single node
has many siblings, like in a paragraph with a lot of explicit line breaks.
Bug: 921789
Change-Id: I0540105cb2947efffda6958797d16cbcfaa2c583
Reviewed-on: https://chromium-review.googlesource.com/c/1410175
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623289}
select_to_speak_extension_tests compiles and links all of chrome, so
folding into browser_tests will save work on the bots. It will also
give coverage for SingleProcessMash and other projects that run
browser_tests with optional flags.
Bug: 892179
Change-Id: I8dfce56a8b522194dfbb0d24de7cb8f5cdd45b01
Reviewed-on: https://chromium-review.googlesource.com/c/1300073
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602964}
chromevox_tests compiles and links all of chrome, so folding into
browser_tests will save work on the bots. It will also give coverage
for SingleProcessMash and other projects that run browser_tests with
optional flags.
Rename the tests to start with ChromeVox to make them easier to run
with --gtest_filter (thanks to dtseng for a CL that did the rename).
Fix ChromeVoxEditingTest.RichTextSelectByLine so it isn't sensitive
to exact font widths and remove chromevox_tests fontconfig override.
Bug: 892179, 898213
Test: browser_tests
Change-Id: Ia23c8f4c237677d299bbe774cf3191654974a56b
Reviewed-on: https://chromium-review.googlesource.com/c/1294811
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602543}
Update the documentation to run brltty on linux as well. This is sometimes hard to [re]discover.
Change-Id: Ia6cfefa2af9465762fc31c8077fec7310edca083
Reviewed-on: https://chromium-review.googlesource.com/c/1294512
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601811}
