This call was replaced by isSessionSupported in the WebXR spec is Sept
of 2019. I think 5+ years should be enough of a deprecation period that
we can now remove the call safely.
Stats for the deprecated call say it's used by ~0.00004% of web pages.
Bug: 40874319
Change-Id: I1b8f6b2b3fbf21e1926fe6d03a39f70b30c4d879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6227520
Reviewed-by: Sergio Villar <svillar@igalia.com>
Auto-Submit: Brandon Jones <bajones@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424807}
Chrome tests for the existence of a TPM on a dedicated thread since the
operation may result in disk access. Since Chrome blocks showing any UI
on this check finishing, increase the thread priority to USER_BLOCKING.
This results in a speedup from ~1700ms to ~1ms on my development
machine. Add a FIDO log entry to measure how long the check takes.
This might help some users who are seeing very long times for any UI to
pop up, but that stop experiencing the bug when GPM is disabled.
Bug: 396607267
Change-Id: I326812b8e086398453fe794306fa8a04341eefbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300761
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424806}
I tried to port this test to desktop Android, but noticed after I was
done that it uses the chrome.scripting API, which hasn't been ported
yet. There's no harm in converting to ExtensionPlatformBrowserTest and
it will help us once chrome.scripting is available, so I'd like to
land what I did.
(I didn't notice in part due to crbug.com/393191910 where tests
can fail with no logs and no stack. I'm trying to escalate that bug.)
This CL also adds permissions_test_util.h/cc to the desktop Android
build, which will be useful for porting other tests.
Bug: 397766259, 393191910
Change-Id: I12e3dddacc7d642ce19fcea46feefa5062b9459e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300233
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424805}
This adds (behind a new, default disabled feature flag) a new net error
code (ERR_CERT_SELF_SIGNED_LOCAL_NETWORK), which is returned for
certificate errors when the certificate is self-signed, and is being
used on a local network URL (either an RFC 1918 IP, or a URL that ends
in .local).
This is step one towards implementing go/betterselfsigned, for now this
only results in the regular SSL interstitial being triggered.
Bug: 394119724
Change-Id: I62850128c250358071cc0693526b23c2677647cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226147
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424804}
This is a reland of commit 9f44fe6906
Original change's description:
> Reland "Modify B&A key fetcher code to retain the full key ID"
>
> This is a reland of commit 5624b16cc2
>
> Original change's description:
> > Modify B&A key fetcher code to retain the full key ID
> >
> > Changes the B&A key fetcher code so that it stores the full key
> > identifier instead of the first two bytes parsed as a hexadecimal
> > number. This will be needed to support features like Private Model
> > Training that include the full key ID as part of the message.
> >
> > This CL also does some refactoring in order to support per-adtech
> > keys/origin scoped keys as described in
> > https://github.com/WICG/turtledove/issues/1334.
> >
> > NO_IFTTT=Just moving the enums.
> >
> > Bug: 390160246
> > Change-Id: I62ded0175dbbc559363685ada995c91ef2d9d2dc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6265963
> > Reviewed-by: Orr Bernstein <orrb@google.com>
> > Commit-Queue: Russ Hamilton <behamilton@google.com>
> > Auto-Submit: Russ Hamilton <behamilton@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1423990}
>
> Bug: 390160246
> Change-Id: I968311418baf9b487654f294f065f893a5b217ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299239
> Commit-Queue: Russ Hamilton <behamilton@google.com>
> Reviewed-by: Orr Bernstein <orrb@google.com>
> Cr-Commit-Position: refs/heads/main@{#1424577}
Bug: 390160246
Change-Id: I9f885c1fd667e094dd2cdf17eb21237fda1057e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297865
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1424802}
This CL is intended to be trivial. It marks the return from `std::to_array` as
`constexpr`. This CL is a split of a naive textual search-and-replace under:
extensions/browser/api/file_system
This CL was uploaded by git cl split.
Change-Id: I2a0830e2cdf05536b5aa7f1768c571cb8b2758e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6301451
Reviewed-by: François Degros <fdegros@chromium.org>
Auto-Submit: Kalvin Lee <kdlee@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424801}
Certain use cases require separate network state from other requests
with the same (top_frame_site, frame_site), but would like to access the
HTTPCache, so using a transient IsolationInfo is not sufficient.
The goal is to extend IsolationInfo,NetworkIsolationKey, and
NetworkAnonymizationKey to include an additional enum value called
NetworkIsolationPartition, creating a three-part key: (top_frame_origin,
frame_origin, network_isolation_partition).
This CL incorporates the enum into the IsolationInfo. Previous CLs
incorporated the enum into the NIK and NAK.
Bug: 396463430
Change-Id: Ic6e21e5e21d9e85394e8bfd4725d45765afb002c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6266263
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424800}
In a short response the web client will call OnResponseStopped() without
first calling OnResponseStarted(). This CL handles this by synthetically
invoking OnResponseStarted() in this case.
Change-Id: Ia96dc0d682ff4d4f9d213c9ecbca557023af81e0
Bug: 391417447, 399151164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300792
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424796}
Enable initialization of the feature list before mojo
is initialized. This changes the creation of the
ApplicationContextImpl to happen in a PostEarlyInitialization
callback in the IOSMainDelegate.
Bug: 40261735
Change-Id: If2b76a2fad420fb15551354ecb65a85310777504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6293264
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424792}
This CL adds parsing logic using DataDecoder to parse the
EnterpriseSearchAggregator response body in a utility process. This
change is finch-gated such that the existing parsing logic can still be
used if the new finch parameter, `parse_in_utility`, is set to false.
Bug: 395938335
Change-Id: I2de3f538da96b7d6063bd8bf8baef4195c9e149a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6288697
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Ananya Seelam <ananyaseelam@google.com>
Cr-Commit-Position: refs/heads/main@{#1424786}
Wait for changes to menu items to propagate to the DOM before displaying
the menu. Otherwise, for cases where cr-lazy-render-lit's get() method
does not force a synchronous render, the menu ends up incorrectly
aligned.
Also fixing a minor issue where tests triggered an assertion failure
when items were being removed from the list. Since bookmarks-item was
already updated to gracefully handle null or undefined item_ values,
dropping the assertion that was trying to ensure this never occurred.
Fixed: 398993300
Change-Id: Ib2af96251927b0b1d061841c2f2303d43852a516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302533
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424784}
TabListModel's clear() and removeAt() methods were effectively
"Overridden" in TabListMediator. To avoid accidentally using the wrong
method in the future just make them true overrides.
Bug: 398186407
Change-Id: I7fb356a31251d4022e0b3ceb0906c8852f99d9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6301773
Reviewed-by: Fiaz Muhammad <mfiaz@google.com>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424783}
Browser view activation state is reflected incorrectly when a child
widget is focused e.g. when Tab search bubble is opened. To change this,
updating the implementation to be consistent with state we use to paint
the browser frame as active. This better aligns with the schematics for
active/inactive state of the browser.
This change also addresses some issues with active/inactive states for
the split tab strip button since it wasn't consistent with the frame
logic and hence was causing some visual issues.
Bug: 394736410
Change-Id: I618fea10a05604840daabab964bf5fa609a17555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6245812
Reviewed-by: Marke Hallowell <wry@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Dan Harrington <harringtond@chromium.org>
Reviewed-by: Emily Shack <emshack@chromium.org>
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424779}
This makes it faster to iterate locally when working with
fetch_all_androidx.py and not needing to roll. The existing --no-roll
arg doesn't work since when working locally, we likely want to resolve
the latest androidx and then iterate on it (e.g. when the roller isn't
working).
Bug: None
Change-Id: Iae6e4da80fc82cdffc406d152cb745de9b40b7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299893
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424778}
The notification content detection model should not run on Android
devices with either low memory or with an ARM32 architecture. This CL
checks for these in the factory, so that we don't even create the
NotificationContentDetectionService if either of these are true. Also
added unit tests for this, since the chrome/browser/safe_browsing/
browser tests do not run for android.
Bug: 374936030
Change-Id: I37f6e98627fb45c9b105832e914cd0d7125b141c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302185
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Sarah Krakowiak <skrakowi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424777}
This is a reland of commit d7c989fedc
See patchset 1 vs 2 for the change. Remove the SetMinSize call from the
constructor since this is already handled in CalculatePreferredSize. Add
regression test to make sure webapps with the downloads button visible
(due to a recent download) will reopen successfully. Move the part of
the flaky test that caused the revert into the new test so there is no
need to wait for the bubble to timeout on its own.
Original change's description:
> Make sure pinned toolbar buttons layout correctly and container hit test component is set for PWAs
>
> This updates the layout for pinned toolbar buttons to match other
> toolbar buttons in web apps and makes sure hit tests work correctly in
> the PinnedToolbarActionsContainer.
>
> Bug: 398059805
> Change-Id: I4fb3d311bb5c3af68c3da3216c8c98639a922da9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6293064
> Reviewed-by: David Pennington <dpenning@chromium.org>
> Commit-Queue: Caroline Rising <corising@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1423753}
Bug: 398059805
Change-Id: I0a6b1f463ac3d2ff45cb48ae69ede676650da69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299298
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424767}
Added a new ErrorWithReason type for initialize().
Currently only UNKNOWN reason is supported, which shows the
error page and allows users to reload manually.
This also resolves an issue where the error panel wasn't
being shown after initialize() errors
Bug: 387365130
Change-Id: I98d846560fc21f07192f9804629aa8ba426b2932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6288924
Commit-Queue: Dan Harrington <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424763}
- New interface with a default method
- Might not be necessary, but cleanup between ModelList container
classes is similar, and will be duplicated in future classes
Bug: 391387522
Change-Id: Ic070d82e0b6790f00850204d90028ee3d8367365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302389
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Fiaz Muhammad <mfiaz@google.com>
Cr-Commit-Position: refs/heads/main@{#1424762}
I chose to introduce a new field in the Method node because it will be
quite difficult to refactor all the code to expect either a param list
or a result return type.
By using a new field, we should be able to branch off of the
"if param_response_list == None" path to generate code to specifically
handle result returns.
Bug: 40841428
Change-Id: I8cfedba118e1745bc208e5ea5a42df1e4d5b3564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298560
Commit-Queue: Fred Shih <ffred@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424760}