d09f5c193b
`ASSERT_NO_FATAL_FAILURE(...)` checks for `ASSERT_*` failures while
executing the provided statement [0] but discards any expression. Use a
plain `ASSERT_TRUE()` to actually check that `ParseX509Certificate()`
succeeds.
The dropped assertion causes a build failure [1] with a recent
Googletest revision that marks `AssertionResult` as `[[nodiscard]]` [2].
[0]: https://google.github.io/googletest/advanced.html#asserting-on-subroutines
[1]: https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/374803/overview
[2]: 3fbe4db9a3%5E%21/
Bug: 398298306
Change-Id: I809e26995510d4055d8aa9282be377cb86b34455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299635
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Auto-Submit: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1424797}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.