- Adding specific examples about serialization in JSON vs. XML so
we can critique how it will ultimately be formatted in context of the
spec.
- dropping "hash_" prefix from hash_in/out to match differential
`previous` objects of the same type.
- clarified that the `hash` object is both a request and a response
object.
- renamed `cache` to `cached_hashes` to clarify the type and also
match the plural list guidance in JSON.
- Pluralizing new and pre-existing list properties to match the
style expectations defined for JSON. This makes it self-documenting in
both XML and JSON that an object is a list, even when the list contains
only a single element.
For context, see:
https://google.github.io/styleguide/jsoncstyleguide.xml?showone=Singular_vs_Plural_Property_Names#Singular_vs_Plural_Property_Names
Fixed: 399959348
Change-Id: I345e0bd2448453f712b898bc20b9b54358a50990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6314174
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: James Decker <deckerjames@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427229}
This CL creates a build rule and Python script which generates
compiled bytecode for JS module input files, alongside a
corresponding manifest.json file. These compiled bytecode artifacts
will be used to improve startup performance of participating WebUI.
This CL does not integrate the rule into build_webui(). Initial
integrations will target stand-alone modules, such as lit-element,
for which an independent build rule is sufficient.
After a successful end-to-end demonstration, work will be done to
integrate this as an optional optimization step of the build_webui()
pipeline.
Invoke tests via
<build_dir>/bin/run_webui_resources_tools_python_unittests
Bug: 378504039
Change-Id: I95d2bd0d3f8d15c0b799fb047e13b40ce837bdbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6261546
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426857}
As code reviewers are expected to perform multiple review passes per
work day, code authors should feel empowered to add different reviewers
if the initial reviewer is not responsive.
Change-Id: I3e15bb0af755a660ce06afd751c8091b6b070f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6305072
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425383}
The convention now is the embedder name followed by `-wpt-tests`. So
remove blink from the name and add `android` as a common prefix for
Android platform.
The steps are now called `android_chrome_wpt_tests` and
`android_webview_wpt_tests` respectively for Chrome
Android and Webview.
Validate-Test-Flakiness: skip
Bug: 395962971
Change-Id: I3fe833ae3fa8ee5b4e338db794eb8ebef3e6b249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279415
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Reviewed-by: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1423477}
Introduce the concept of "." lines that pass names of checks into
the plugin. Then always activate the unsafe libc warnings and filter
them based on these values.
-- Remove switch replaced by this mechanism.
-- Pretty much accept any dot line format despite the stricter docs.
-- Default unsafe_buffers checks on (can remove once products are
updated to match).
Change-Id: I7808615abf3f1669401f2c676b8e5c06aa596bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6251213
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421495}
1. Change the Commit-Queue value from +1 to 0 in Gerrit UI.
2. Upload a new patchset which triggers a new dry run.
3. Code-Review -1. This prevents a CL from landing.
Change-Id: I8cd0659a83deb469631f180e8a1192ba87fe8f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254918
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419021}
Move some text from unsafe_buffers_paths.txt into the markdown file
so that it may be more easily discovered. Hidden benefit of not
reading and discarding so many comment lines in each compiler
invocation.
Re-arrange and re-write sections to make flow more natural.
Change-Id: I077cf0d91cdd52a36cde9bb7c882ce3cf1fd6785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6251406
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418875}
Reland notes: This is the 2nd part of the reland of the reverted CL at
crrev.com/c/6253018. The CL was incorrectly reverted, since the problem
was limited in the local dev environment of the person that was having
the issue, where third_party/node/ for some reason was stuck in v16 (a
very old version) instead of v22.
Enabling `enable_type_aware_eslint_checks` by default in build_webui().
Bug: 394634491
Change-Id: I35f77e4d3aef7af08ad06f1881d079e184c8153d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254799
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418856}
It took me some time to figure this out, both to learn if the version
number mismatch was important, and how to apply the patches by hand.
Change-Id: I3312435a0dcdddb0f4e04e199da5c334e80248ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249083
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418829}
Add instructions on how to use the compile-size builder and fix
issues. This is necessary before we block CLs in CQ that have
large increases.
Bug: 370594503
Change-Id: I035ea17a6687457dac0060ce28f843319a564687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6246737
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418813}
This reverts commit 32867d045f.
Reason for revert: Breaks the build.
FAILED: gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs
python3 ../../ui/webui/resources/tools/eslint_ts.py --in_folder gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed --out_folder gen/ui/webui/resources/cr_components/cr_shortcut_input --config_base ../../../../../../../../ui/webui/resources/tools/eslint_ts.config_base.mjs --tsconfig tsconfig_build_ts.json --in_files cr_shortcut_input.ts cr_shortcut_input.html.ts cr_shortcut_util.ts
Traceback (most recent call last):
File "/usr/local/google/home/sesse/chromium/src/out/Default/../../ui/webui/resources/tools/eslint_ts.py", line 78, in <module>
main(sys.argv[1:])
File "/usr/local/google/home/sesse/chromium/src/out/Default/../../ui/webui/resources/tools/eslint_ts.py", line 67, in main
node.RunNode([
File "/usr/local/google/home/sesse/chromium/src/third_party/node/node.py", line 38, in RunNode
raise RuntimeError('Command \'%s\' failed\n%s' % (' '.join(cmd), err))
RuntimeError: Command '/usr/local/google/home/sesse/chromium/src/third_party/node/linux/node-linux-x64/bin/node /usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/bin/eslint --color --quiet --config gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_input.ts gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_input.html.ts gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_util.ts' failed
Oops! Something went wrong! :(
ESLint: 9.10.0
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at new NodeError (node:internal/errors:371:5)
at validateString (node:internal/validators:119:11)
at Object.join (node:path:1172:7)
at file:///usr/local/google/home/sesse/chromium/src/out/Default/gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs?mtime=1739278158700:10:26
at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
at async loadFlatConfigFile (/usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/lib/eslint/eslint.js:390:21)
at async calculateConfigArray (/usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/lib/eslint/eslint.js:473:28)
Original change's description:
> WebUI: Enable @typescript-eslint/require-await check in build_webui().
>
> - Enabling `enable_type_aware_eslint_checks` by default in build_webui().
> - Fixing a few remaining violations that were not already fixed in
> precursor CLs.
> - Fix the dependnecies of the ":lint" target for the case of
> `use_javascript_coverage=true`
> - Add a new "ESLint checks" section in styleguide/web/web.md explaining
> the two different types of ESLint checks.
> - Update Chromium styleguide additions to include what will be
> enfroced by @typescript-eslint/require-await as part of this CL,
> and @typescript-eslint/no-unnecessary-type-assertion in upcoming
> CLs.
>
> Bug: 394634491
> Change-Id: I59a07d4e76339449c3e5ff79608b57154a3e32cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250398
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1418375}
Bug: 394634491
Change-Id: Iccfa9b2c94f608e193f95a7fe454abbec3c3f3b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253018
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Steinar H Gunderson <sesse@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Owners-Override: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418592}