0
Commit Graph

5715 Commits

Author SHA1 Message Date
d8f399e6bb Roll Website from cbe3327ec687 to d68f942f2c6e (1 revision)
https://chromium.googlesource.com/website.git/+log/cbe3327ec687..d68f942f2c6e

2025-03-06 uekawa@google.com CrOS: fix fuse links.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I8ed2dfdb4f1fc9f86a88f1ff4c55e8b12fafccdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333156
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1428946}
2025-03-06 08:18:27 -08:00
632d24554f [Telemetry] Fix TPM API description
Add the missing description for `enabled` field in `TpmStatus`.

Bug: None
Test: CQ

Change-Id: I3058a54ac37d01f61091c3599c259ae7241f2106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330614
Reviewed-by: Wei-Luan Wang <weiluanwang@google.com>
Commit-Queue: Wei-Luan Wang <weiluanwang@google.com>
Auto-Submit: Byron Lee <byronlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428711}
2025-03-05 19:48:15 -08:00
e4581c9c5d Roll Website from 15e8c937306c to cbe3327ec687 (1 revision)
https://chromium.googlesource.com/website.git/+log/15e8c937306c..cbe3327ec687

2025-03-05 pbos@chromium.org Allow accepted Chromium GSoC contributors on Slack

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I450fa8c4e94e29158cc60bbb3b80150907123799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6331198
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1428539}
2025-03-05 13:15:02 -08:00
1d58c639e7 Add Fullscreen Security FAQ to docs/security/
Change-Id: I527eeef1dbfc5bf88e0412d7cd1f7a39ccfb86aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6315931
Reviewed-by: Amy Ressler <amyressler@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/main@{#1428456}
2025-03-05 11:01:14 -08:00
1d1b6407d9 updater: add dev guidelines for converting base::FilePath to strings
Bug: 397561234
Change-Id: I505b88ee9f45a88bb5a9a7d840e0e94fc8d4812a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6321731
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427919}
2025-03-04 12:47:15 -08:00
2351772933 updater: add dev guidelines for appending strings to base::FilePath
Bug: 397561234
Change-Id: Ie84212a2ab2a14cb1932c77c1cd8452efe4290ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6323303
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427844}
2025-03-04 10:50:06 -08:00
d5287f331c [ios blink] Adjust documentation
Add a few more fields to the build instructions for ios_blink.

Change-Id: I18c4d8d0b76062cac63ae1852632db8e2ad6c4e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6323123
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427752}
2025-03-04 08:32:55 -08:00
b1b3d7982c Roll Website from d00ede697084 to 15e8c937306c (2 revisions)
https://chromium.googlesource.com/website.git/+log/d00ede697084..15e8c937306c

2025-03-04 vovoy@google.com Remove joelaf from OWNERS
2025-03-03 estark@google.com Yeet Chromium security PGP key, because it's 2025

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:399856242
Tbr: dpranke@google.com
Change-Id: I21bf562a5a70ef01039d270579d27ae5e6c077da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6321596
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1427663}
2025-03-04 04:58:10 -08:00
ea777fea6d Roll Website from 441c86221443 to d00ede697084 (1 revision)
https://chromium.googlesource.com/website.git/+log/441c86221443..d00ede697084

2025-03-03 kuanhuang@chromium.org Add chrome-for-testing per-commit builds to the public bisect-builds.py doc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:390476466
Tbr: dpranke@google.com
Change-Id: I6925a9e0916ad58b96c3d9b43622c72e82f66915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319233
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1427372}
2025-03-03 14:01:51 -08:00
638a46aba3 android_isolated_splits.md: Mention our compile check for invalid package-private access
Change-Id: Ifd279005da59b04ed685aae968ecb9ddcaefec44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317630
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427332}
2025-03-03 12:58:20 -08:00
e0b0499d7c Remove obsolete merge information.
Change-Id: I9ecc69fbb97c5e693141aa4d0bf87f581a66f135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6316529
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Harry Souders <harrysouders@google.com>
Cr-Commit-Position: refs/heads/main@{#1427268}
2025-03-03 11:07:35 -08:00
b26d0a87e2 Updating v4 spec to define objects to be more JSON friendly.
- Adding specific examples about serialization in JSON vs. XML so
we can critique how it will ultimately be formatted in context of the
spec.
- dropping "hash_" prefix from hash_in/out to match differential
`previous` objects of the same type.
- clarified that the `hash` object is both a request and a response
object.
- renamed `cache` to `cached_hashes` to clarify the type and also
match the plural list guidance in JSON.
- Pluralizing new and pre-existing list properties to match the
style expectations defined for JSON. This makes it self-documenting in
both XML and JSON that an object is a list, even when the list contains
only a single element.

For context, see:
https://google.github.io/styleguide/jsoncstyleguide.xml?showone=Singular_vs_Plural_Property_Names#Singular_vs_Plural_Property_Names

Fixed: 399959348
Change-Id: I345e0bd2448453f712b898bc20b9b54358a50990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6314174
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: James Decker <deckerjames@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427229}
2025-03-03 10:44:02 -08:00
69b9b0476d [webui] Add generate_code_cache build rule
This CL creates a build rule and Python script which generates
compiled bytecode for JS module input files, alongside a
corresponding manifest.json file. These compiled bytecode artifacts
will be used to improve startup performance of participating WebUI.

This CL does not integrate the rule into build_webui(). Initial
integrations will target stand-alone modules, such as lit-element,
for which an independent build rule is sufficient.

After a successful end-to-end demonstration, work will be done to
integrate this as an optional optimization step of the build_webui()
pipeline.

Invoke tests via
  <build_dir>/bin/run_webui_resources_tools_python_unittests

Bug: 378504039
Change-Id: I95d2bd0d3f8d15c0b799fb047e13b40ce837bdbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6261546
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426857}
2025-03-02 11:18:42 -08:00
933b35e0c3 Mention compile-size for build increases in third_party docs
Bug: 40190002
Change-Id: I076ebd8e14a88affd99d2c5eb88d4120f6209e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312265
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Erik Staab <estaab@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426662}
2025-02-28 18:29:54 -08:00
20d830d70a Roll Website from 12ac248ece2f to 441c86221443 (3 revisions)
https://chromium.googlesource.com/website.git/+log/12ac248ece2f..441c86221443

2025-03-01 adetaylor@chromium.org Update OWNERs of Chromium Security website.
2025-02-28 ahaas@chromium.org Mention changes to .gclient for msan builds.
2025-02-28 davidcross@chromium.org developer-information: update chromium.org device page with lotso

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I96a4023de4271dc37c1ecdf71a9c65a3e7838c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6314298
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1426639}
2025-02-28 16:54:05 -08:00
208ea7967e Update speed-metrics-changelog with the information for m133 INP launch.
Document EventTimingSelectionAutoScrollNoInteractionId change.

Change-Id: Ic2ceb056941f7780445f8c3ddc4f1fe05dcdd37b
Bug: 330711100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309045
Commit-Queue: Michal Mocny <mmocny@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426305}
2025-02-28 07:43:36 -08:00
f7a9f00200 Roll Website from ca7e3649d9a4 to 12ac248ece2f (2 revisions)
https://chromium.googlesource.com/website.git/+log/ca7e3649d9a4..12ac248ece2f

2025-02-28 bmgordon@chromium.org rust-on-cros: Adjust recommended chromeos-version.sh
2025-02-27 jasikab@google.com publishing Q4 2024 quarterly update

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: If9e21331877144f838c474f6ed8773efab773145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312568
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1426208}
2025-02-28 03:11:10 -08:00
61bc2b23a9 Roll Website from 73082c81d712 to ca7e3649d9a4 (1 revision)
https://chromium.googlesource.com/website.git/+log/73082c81d712..ca7e3649d9a4

2025-02-27 mitchella@google.com Update Privacy Sandbox link

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I04dd27fa13067d0187f76420246009e26e889b49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6311142
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1425979}
2025-02-27 14:18:57 -08:00
f439f3a410 Updater: Update link to tagging tool.
https://crrev.com/c/4738939 converted the tagging tool from Python to C++.

Change-Id: Id84f0555e510a37591331dd3131d7ceaf3b4beef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6310419
Auto-Submit: Noah Anderson <noahanderson@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Noah Rose Ledesma <noahrose@google.com>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/main@{#1425966}
2025-02-27 13:53:33 -08:00
0075e4c935 Updater: Remove FP from v4 protocol documentation.
Bug: 353249967
Change-Id: Ib32098fd4712ded3cec017dfb3160289c291af08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300769
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425479}
2025-02-26 16:54:57 -08:00
8bda7ba733 Add code author expectation.
As code reviewers are expected to perform multiple review passes per
work day, code authors should feel empowered to add different reviewers
if the initial reviewer is not responsive.

Change-Id: I3e15bb0af755a660ce06afd751c8091b6b070f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6305072
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425383}
2025-02-26 13:30:29 -08:00
d23c10bb91 Roll Website from d9817b87d844 to 73082c81d712 (1 revision)
https://chromium.googlesource.com/website.git/+log/d9817b87d844..73082c81d712

2025-02-26 alevkoy@chromium.org Chroot Clangd: Explain client configuration

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I665908f383da1e9a7a19f9375041e01faae55582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6306206
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1425281}
2025-02-26 10:51:46 -08:00
1169ce5301 Roll Website from 6e02f43f289b to d9817b87d844 (1 revision)
https://chromium.googlesource.com/website.git/+log/6e02f43f289b..d9817b87d844

2025-02-25 alevkoy@chromium.org Chroot Clangd: Simplify clangd launch script

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ib5a1d6847c1cb813a8f00592edd9ef6dd5b44a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302652
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1424712}
2025-02-25 12:06:03 -08:00
fe99df99dd android_binary_size_trybot.md: Update to say arm64 breakdowns exist
Bug: 383540547
Change-Id: I2c8a5a157f4a8b96fec5823222b3a99a8e1662db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299354
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424096}
2025-02-24 12:39:08 -08:00
275044ecef Rename WPT step names for Android and Webview
The convention now is the embedder name followed by `-wpt-tests`. So
remove blink from the name and add `android` as a common prefix for
Android platform.

The steps are now called `android_chrome_wpt_tests` and
`android_webview_wpt_tests` respectively for Chrome
Android and Webview.

Validate-Test-Flakiness: skip

Bug: 395962971
Change-Id: I3fe833ae3fa8ee5b4e338db794eb8ebef3e6b249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279415
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Reviewed-by: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1423477}
2025-02-21 16:20:41 -08:00
53d3716d6e Roll Website from 149dc09722d5 to 6e02f43f289b (1 revision)
https://chromium.googlesource.com/website.git/+log/149dc09722d5..6e02f43f289b

2025-02-21 ricea@chromium.org Update one section of the netlog docs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ic04e1de29e1bb31fb35ae0003e7b4ddc2efdf67c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6291862
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1423265}
2025-02-21 10:41:45 -08:00
4444f886b9 [win-bootstrap] Update win docs to clone depot_tools repo
Now that installing git is an early part of the build setup process,
one can use `git clone` to get `depot_tools`.

Bug: 360206460
Change-Id: Ida85f8da17649962fc2b38fb30bb5cf907ebe14b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6288186
Reviewed-by: Joey Scarr <jsca@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joey Scarr <jsca@google.com>
Auto-Submit: Anne Redulla <aredulla@google.com>
Cr-Commit-Position: refs/heads/main@{#1422843}
2025-02-20 15:30:00 -08:00
9b315d56e2 Remove obsolete group from docs
This removes mention of the "Chromium UI Discussion" group from the
docs, as it seems to no longer be used.

Change-Id: I703c44c5c51555b9315017ba46364ff7108f0c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6289265
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422840}
2025-02-20 15:27:53 -08:00
b1a8156b36 Reapply "Make UnsafeBuffersPlugin take arguments from .txt file"
This reverts commit 5a8d40867f.

The original patch is updated to fix command line argument parsing
in the test files.

Bug: 397620599
Change-Id: Ice08d42516451690c1bb31b5ef732162c7b50cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282426
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422631}
2025-02-20 09:28:54 -08:00
166b241d35 Roll Website from 4e4b61042e75 to 149dc09722d5 (1 revision)
https://chromium.googlesource.com/website.git/+log/4e4b61042e75..149dc09722d5

2025-02-19 achristiansen@google.com Update chromium/website/main Edit page link to Cider G.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I37eccee6a761f9bfaecd4c22dada92ab9b9c5cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282992
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1422274}
2025-02-19 16:22:53 -08:00
7b8dfcaa71 Re-format plugin section in clang docs.
Make it more obvious that the tests run as part of the incremental
build are *not* the full suite of tests required.

Change-Id: Ibf77020a45a0f613f5f2dab0bdac353e271c90d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282727
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422109}
2025-02-19 11:36:38 -08:00
8174ee0645 [rust] Add more UNSAFE_RUST_OWNERS + tweak related documentation.
Bug: 393410747
Change-Id: I10f8c71f40f001d25a4a1a3c746d112da5ba22b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279505
Reviewed-by: Liza Burakova <liza@chromium.org>
Reviewed-by: Dustin Mitchell <djmitche@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422092}
2025-02-19 11:07:58 -08:00
4c56a2adc8 Update Shepherding guidelines to reflect correct owners file
Change-Id: I20d70b62b8946347d118a1deb76ef9a84c4a2549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6276280
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Amy Ressler <amyressler@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422029}
2025-02-19 09:39:49 -08:00
5a8d40867f Revert "Make UnsafeBuffersPlugin take arguments from .txt file"
This reverts commit 8133461042.

Reason for revert: caused https://crbug.com/397620599

Original change's description:
> Make UnsafeBuffersPlugin take arguments from .txt file
>
> Introduce the concept of "." lines that pass names of checks into
> the plugin. Then always activate the unsafe libc warnings and filter
> them based on these values.
>
> -- Remove switch replaced by this mechanism.
> -- Pretty much accept any dot line format despite the stricter docs.
> -- Default unsafe_buffers checks on (can remove once products are
>    updated to match).
>
> Change-Id: I7808615abf3f1669401f2c676b8e5c06aa596bf5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6251213
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1421495}

Change-Id: I73f629242de56d4813a42cbc6d2ff511ffe11807
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6281433
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1421975}
2025-02-19 08:17:12 -08:00
038459f202 JSON parser is in the past tense
With https://crbug.com/40276029, the JSON parser is no longer a going
concern. However, it's still useful as an example of how Java can be
used for safety.

Bug: 40276029
Change-Id: I0ab0f26f1e9b082e6a56ad0c8c2c7225d03f958d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6267862
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421935}
2025-02-19 07:11:22 -08:00
1c0ad55f18 Document detection and pings for overinstalls
Add documentation to the updater's functional spec explaining how
external installs are periodically detected and pinged.

Bug: 397415614
Change-Id: I9f046e0c77f5bf7139fe0af04125f3d5258b6a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6278790
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/main@{#1421665}
2025-02-18 15:00:05 -08:00
8133461042 Make UnsafeBuffersPlugin take arguments from .txt file
Introduce the concept of "." lines that pass names of checks into
the plugin. Then always activate the unsafe libc warnings and filter
them based on these values.

-- Remove switch replaced by this mechanism.
-- Pretty much accept any dot line format despite the stricter docs.
-- Default unsafe_buffers checks on (can remove once products are
   updated to match).

Change-Id: I7808615abf3f1669401f2c676b8e5c06aa596bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6251213
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421495}
2025-02-18 10:46:36 -08:00
327571afc7 Fix a small typo
Change-Id: Ie1c78d43790ea0ba2fc92584701a84a094cbc202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6247447
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Amy Ressler <amyressler@chromium.org>
Commit-Queue: Andrew Mitchell <mitchella@google.com>
Cr-Commit-Position: refs/heads/main@{#1420874}
2025-02-16 20:14:09 -08:00
68bc0ae25e Roll Website from 087e0ee5b711 to 4e4b61042e75 (1 revision)
https://chromium.googlesource.com/website.git/+log/087e0ee5b711..4e4b61042e75

2025-02-14 ryandickson@google.com Update Chrome Root Program Policy to Version 1.6.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I96c6b2b6f9a139f1b237bd58a52d2166fc1bbdf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6270903
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1420771}
2025-02-14 15:22:16 -08:00
a48d7965cd Update merge request docs to mention multiple changes
Bug: 396131425
Change-Id: Iea66141d79b7f3ced1f94079506c8dd5c6aa9609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6264023
Reviewed-by: Daniel Yip <danielyip@google.com>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419911}
2025-02-13 08:06:47 -08:00
3191020795 WebUI: Enable @typescript-eslint/require-await in build_webui_tests().
Also fixing a few remaining violations that were not already fixed in
precursor CLs.

Bug: 394634491
Change-Id: Id6d45210a1800653330d0105e1fe3013a27796d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6258153
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419613}
2025-02-12 16:30:12 -08:00
e415c52cfc Fix broken link to Mac.txt
The file is renamed to MacOld.txt. Updated document accordingly.

Bug: None
Change-Id: Ib9221301fd441fda82fd6b8fc6a102e687440035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6259595
Reviewed-by: An Sung <ansung@google.com>
Auto-Submit: Weizhong Xia <weizhong@google.com>
Commit-Queue: An Sung <ansung@google.com>
Cr-Commit-Position: refs/heads/main@{#1419523}
2025-02-12 13:29:01 -08:00
84b3c4562e [DevTools] Update HostConfig documentation.
Bug: 396033932
Change-Id: Ia1562126c4182959b21d8c32d6d96e810b23f961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6257731
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419237}
2025-02-12 05:47:59 -08:00
45561553bc [Docs] Update CQ doc to include 3 ways to stop the CQ
1. Change the Commit-Queue value from +1 to 0 in Gerrit UI.
2. Upload a new patchset which triggers a new dry run.
3. Code-Review -1. This prevents a CL from landing.

Change-Id: I8cd0659a83deb469631f180e8a1192ba87fe8f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254918
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419021}
2025-02-11 17:23:27 -08:00
d647d84dc8 Move some documentation into unsafe_buffers.md
Move some text from unsafe_buffers_paths.txt into the markdown file
so that it may be more easily discovered. Hidden benefit of not
reading and discarding so many comment lines in each compiler
invocation.

Re-arrange and re-write sections to make flow more natural.

Change-Id: I077cf0d91cdd52a36cde9bb7c882ce3cf1fd6785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6251406
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418875}
2025-02-11 13:11:51 -08:00
af3c4fb362 [Reland] WebUI: Enable @typescript-eslint/require-await check in build_webui().
Reland notes: This is the 2nd part of the reland of the reverted CL at
crrev.com/c/6253018. The CL was incorrectly reverted, since the problem
was limited in the local dev environment of the person that was having
the issue, where third_party/node/ for some reason was stuck in v16 (a
very old version) instead of v22.

Enabling `enable_type_aware_eslint_checks` by default in build_webui().

Bug: 394634491
Change-Id: I35f77e4d3aef7af08ad06f1881d079e184c8153d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254799
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418856}
2025-02-11 12:50:27 -08:00
672902a3b0 [Docs] Tweak contributing.md vote-copying phrasing
Follow-up from request at
https://chromium-review.googlesource.com/c/chromium/src/+/6226768/8/docs/contributing.md#393

Bug: None
Change-Id: I49ab2c6d7a667e47fbf5fa48a3a34b106f1ded60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244014
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1418845}
2025-02-11 12:37:26 -08:00
3d17cd4bee Add a note to //docs/rust.md about how patches are applied
It took me some time to figure this out, both to learn if the version
number mismatch was important, and how to apply the patches by hand.

Change-Id: I3312435a0dcdddb0f4e04e199da5c334e80248ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249083
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418829}
2025-02-11 12:15:00 -08:00
5e847c6565 Add docs on using the compile-size builder
Add instructions on how to use the compile-size builder and fix
issues. This is necessary before we block CLs in CQ that have
large increases.

Bug: 370594503
Change-Id: I035ea17a6687457dac0060ce28f843319a564687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6246737
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418813}
2025-02-11 11:42:58 -08:00
9832bca736 Revert "WebUI: Enable @typescript-eslint/require-await check in build_webui()."
This reverts commit 32867d045f.

Reason for revert: Breaks the build.

FAILED: gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs 
python3 ../../ui/webui/resources/tools/eslint_ts.py --in_folder gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed --out_folder gen/ui/webui/resources/cr_components/cr_shortcut_input --config_base ../../../../../../../../ui/webui/resources/tools/eslint_ts.config_base.mjs --tsconfig tsconfig_build_ts.json --in_files cr_shortcut_input.ts cr_shortcut_input.html.ts cr_shortcut_util.ts
Traceback (most recent call last):
  File "/usr/local/google/home/sesse/chromium/src/out/Default/../../ui/webui/resources/tools/eslint_ts.py", line 78, in <module>
    main(sys.argv[1:])
  File "/usr/local/google/home/sesse/chromium/src/out/Default/../../ui/webui/resources/tools/eslint_ts.py", line 67, in main
    node.RunNode([
  File "/usr/local/google/home/sesse/chromium/src/third_party/node/node.py", line 38, in RunNode
    raise RuntimeError('Command \'%s\' failed\n%s' % (' '.join(cmd), err))
RuntimeError: Command '/usr/local/google/home/sesse/chromium/src/third_party/node/linux/node-linux-x64/bin/node /usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/bin/eslint --color --quiet --config gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_input.ts gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_input.html.ts gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_util.ts' failed

Oops! Something went wrong! :(

ESLint: 9.10.0

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:119:11)
    at Object.join (node:path:1172:7)
    at file:///usr/local/google/home/sesse/chromium/src/out/Default/gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs?mtime=1739278158700:10:26
    at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async loadFlatConfigFile (/usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/lib/eslint/eslint.js:390:21)
    at async calculateConfigArray (/usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/lib/eslint/eslint.js:473:28)

Original change's description:
> WebUI: Enable @typescript-eslint/require-await check in build_webui().
>
>  - Enabling `enable_type_aware_eslint_checks` by default in build_webui().
>  - Fixing a few remaining violations that were not already fixed in
>    precursor CLs.
>  - Fix the dependnecies of the ":lint" target for the case of
>    `use_javascript_coverage=true`
>  - Add a new "ESLint checks" section in styleguide/web/web.md explaining
>    the two different types of ESLint checks.
>  - Update Chromium styleguide additions to include what will be
>    enfroced by @typescript-eslint/require-await as part of this CL,
>    and @typescript-eslint/no-unnecessary-type-assertion in upcoming
>    CLs.
>
> Bug: 394634491
> Change-Id: I59a07d4e76339449c3e5ff79608b57154a3e32cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250398
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1418375}

Bug: 394634491
Change-Id: Iccfa9b2c94f608e193f95a7fe454abbec3c3f3b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253018
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Steinar H Gunderson <sesse@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Owners-Override: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418592}
2025-02-11 05:49:25 -08:00