Omer Katz
bbffc26a8a
heap: Add chrome feature for --separate-gc-phases
...
Bug: 365694581
Change-Id: Ic458199ba7872aa55f0272e08c6eafade3ecd105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850976
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Omer Katz <omerkatz@chromium.org >
Auto-Submit: Omer Katz <omerkatz@chromium.org >
Commit-Queue: Michael Lippautz <mlippautz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1353421}
2024-09-10 16:50:04 +00:00
Michael Lippautz
8f6541c296
V8GCOptimizeSweepForMutator: Remove flag
...
The flag has been removed on the V8 side as the new feature has a
conservative fallback that's very close to the old behavior.
Bug: 333981063
Change-Id: I2f5d2c342c55583541b9b1e9d7be5f28be0b5321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823075
Auto-Submit: Michael Lippautz <mlippautz@chromium.org >
Reviewed-by: Anton Bikineev <bikineev@chromium.org >
Commit-Queue: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Anton Bikineev <bikineev@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1350057}
2024-09-03 09:50:13 +00:00
Etienne Pierre-doray
3976b76ecc
[v8 GC] Connect incremental-marking-start-user-visible to V8IncrementalMarkingStartUserVisible feature
...
Bug: 361124432
Change-Id: I9da11b4a0db57a502b981d06ed9be0eec1373fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817635
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1347482}
2024-08-27 17:47:50 +00:00
Tom Sepez
590a856c7c
Comment some functions that should be UNSAFE_BUFFER_USAGE.
...
Whenever "passing the buck" to the caller to provide safe arguments
used in an UNSAFE_BUFFERS() region of the code, enforcement must also
be passed to the caller via UNSAFE_BUFFER_USAGE. Note places where
this is not happening, but do not enforce as it would cause breakage.
No code changes.
-- Upcase one SAFETY comment found along the way.
Change-Id: I5f5d0b877faf1ee289772efcc7a35cb7d04f4b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789370
Commit-Queue: Tom Sepez <tsepez@chromium.org >
Reviewed-by: Daniel Cheng <dcheng@chromium.org >
Owners-Override: Daniel Cheng <dcheng@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1342288}
2024-08-15 15:59:16 +00:00
Matthias Liedtke
2c83e3f488
[v8] Add new gin feature WebAssemblyDeopt
...
Prepare Finch trial by adding a feature (off-by-default for now).
Bug: 42204618
Change-Id: I5c97a7ea1f352945ad48d7829e70930f75c12b0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5766679
Reviewed-by: Eva Herencsárová <evih@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Auto-Submit: Matthias Liedtke <mliedtke@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1338428}
2024-08-07 13:10:36 +00:00
mikt
dc1d5a68d4
[PA] Update DEPS for new include path #cleanup
...
Before this CL,
- `//DEPS` allows including `base/` headers
- `//base/DEPS` allows including `partition_alloc` headers, while
banning `base/allocator/partition_alloc`.
This forced us to use
- `#include "partition_alloc/*"` in `//base`
- `#include "base/allocator/partition_alloc/src/partition_alloc/*"`
elsewhere
and the rule was inconsistent.
This CL applies the DEP include rule in `//base` chrome-wide so that
we can only use `#include "partition_alloc/*"` style includes.
At the same time, all `#include` with the old style are rewritten.
This need to be done in the single CL to avoid DEP rule check errors.
Bug: 40276913
Change-Id: I1410888184df71ec3bd6374d58d876740357272c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5745369
Commit-Queue: Mikihito Matsuura <mikt@google.com >
Reviewed-by: Rick Byers <rbyers@chromium.org >
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org >
Owners-Override: Rick Byers <rbyers@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1334435}
2024-07-29 20:43:02 +00:00
Marja Hölttä
86a32b0d90
Reland: [compile hints magic] Enable the compile hints magic comment when producing the code cache
...
Measurements with the file-based explicit compile hint magic comment
showed regressions in the non-cached loads, but improvements in cached
loads. The running theory is that having more data in the code cache is
beneficial, but compiling it comes with a cost.
Thus, we should enable the compile hints magic comment only when we're
going to produce a code cache afterwards.
Last try: https://chromium-review.googlesource.com/c/chromium/src/+/5712811
This version contains fixes to handle ScriptResources with a CachedMetadataHandler
gracefully.
Bug: 42203853
Change-Id: I3d6f0ea18ae76235873d2baa1882932a454a4381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5730299
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Marja Hölttä <marja@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1332243}
2024-07-24 10:50:53 +00:00
Marja Hölttä
41760e74b6
Revert "[compile hints magic] Enable the compile hints magic comment when producing the code cache"
...
This reverts commit 0d31411c75https://issues.chromium.org/issues/354751038
Original change's description:
> [compile hints magic] Enable the compile hints magic comment when producing the code cache
>
> Measurements with the file-based explicit compile hint magic comment
> showed regressions in the non-cached loads, but improvements in cached
> loads. The running theory is that having more data in the code cache is
> beneficial, but compiling it comes with a cost.
>
> Thus, we should enable the compile hints magic comment only when we're
> going to produce a code cache afterwards.
>
> Bug: 42203853
> Change-Id: I199a7e9569de84d5a9e7d1a16644dd6c3bbba333
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5712811
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org >
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
> Commit-Queue: Marja Hölttä <marja@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1330925}
Bug: 42203853
Change-Id: Ida8ef01791ebaf894b1bb228061d1c4e66b3ff3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5730276
Reviewed-by: Prudhvikumar Bommana <pbommana@google.com >
Owners-Override: Prudhvikumar Bommana <pbommana@google.com >
Commit-Queue: Marja Hölttä <marja@chromium.org >
Reviewed-by: Tsuyoshi Horo <horo@chromium.org >
Auto-Submit: Marja Hölttä <marja@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Tsuyoshi Horo <horo@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1331596}
2024-07-23 07:57:54 +00:00
Marja Hölttä
0d31411c75
[compile hints magic] Enable the compile hints magic comment when producing the code cache
...
Measurements with the file-based explicit compile hint magic comment
showed regressions in the non-cached loads, but improvements in cached
loads. The running theory is that having more data in the code cache is
beneficial, but compiling it comes with a cost.
Thus, we should enable the compile hints magic comment only when we're
going to produce a code cache afterwards.
Bug: 42203853
Change-Id: I199a7e9569de84d5a9e7d1a16644dd6c3bbba333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5712811
Reviewed-by: Tsuyoshi Horo <horo@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Marja Hölttä <marja@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1330925}
2024-07-22 06:49:36 +00:00
Daniel Lehmann
4997d64650
[wasm] Follow flag rename on v8 side
...
The V8 side change is in https://crrev.com/c/5720949 .
This feature has not been staged, finched, or launched, so the brief
period of inconsistency between V8 and Chromium should be fine.
Bug: 335082212
Change-Id: Ie49bfa12e32468474f324896b7e2c01da3d4a964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5720896
Commit-Queue: Daniel Lehmann <dlehmann@chromium.org >
Reviewed-by: Clemens Backes <clemensb@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1329613}
2024-07-18 16:32:41 +00:00
Daniel Lehmann
4205b35ac3
[gin] Feature for speculative Wasm call_indirect inlining
...
Prepare Finch trial by adding a feature (off-by-default for now).
Bug: 335082212
Change-Id: Ia5dd6159fa8c8b07575807bb841a2bc8db9979ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5625693
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Clemens Backes <clemensb@chromium.org >
Commit-Queue: Daniel Lehmann <dlehmann@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1327414}
2024-07-15 11:01:49 +00:00
Omer Katz
dd11ac17a2
heap: Set field trial for Scavenger max capacity
...
Bug: 351843812
Change-Id: I0e62b6cff480de244191318f188a4918b4b03905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688524
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Omer Katz <omerkatz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1326667}
2024-07-12 10:59:23 +00:00
Shu-yu Guo
cb122b6fb0
[gin] Remove kJavaScriptArrayFromAsync
...
The feature has shipped since M121.
Bug: v8:13321
Change-Id: I25a9f7a5025ce8d373e6d6309238d736d51ce0cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5695969
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1326401}
2024-07-11 21:39:49 +00:00
Shu-yu Guo
160b2ae6e2
[gin] Add feature for Promise.try
...
Bug: 346505948
Change-Id: I8b3e350264a841ec644d309d51b46f5f26d324f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689594
Reviewed-by: Adam Klein <adamk@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1325616}
2024-07-10 18:02:59 +00:00
Omer Katz
30f1533f0b
heap: Enable --update-allocation-limits-after-loading on field trial
...
Add a feature flag in Chrome and enable it on field trial.
Bug: 346498599
Change-Id: I6153e778d087959ec0003f79721f3e451ae1c858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5630639
Commit-Queue: Omer Katz <omerkatz@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1315307}
2024-06-14 17:13:27 +00:00
Olivier Flückiger
d772e5df60
gin: add a kill switch for v8 sidestep transitions
...
Bug: 40764103
Change-Id: I1e8db775e0716c581814e096f4b288dd27ef6cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5600623
Auto-Submit: Olivier Flückiger <olivf@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1311790}
2024-06-07 07:21:25 +00:00
Olivier Flückiger
bc5db3d9d5
gin: remove V8ProfileGuidedOptimization flag enabled upstream
...
Bug: 41490281
Change-Id: Ied6cc19c2d1ac0c6cdfdfa89db0bd822bd5fc167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5584839
Commit-Queue: Olivier Flückiger <olivf@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1309318}
2024-06-03 15:07:28 +00:00
Dominik Inführ
06fa667bcf
gin: Add features to test variants of V8SingleThreadedGCInBackground
...
Add additional gin features for single-threaded GCs in background.
Bug: 40278463
Change-Id: I504f8b74b293f464f0e60acd06805bed31503373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5574970
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Reviewed-by: Omer Katz <omerkatz@chromium.org >
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1306832}
2024-05-28 16:55:14 +00:00
Benoît Lizé
787cd3af44
[gin] Add a feature to decommit pooled Oilpan pages
...
This is the chromium-side of this V8 CL:
https://chromium-review.googlesource.com/c/v8/v8/+/5541750/6
Bug: 326303884
Change-Id: Ie8ea1fd912229f50bbff57723850c50f43eefbe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545282
Commit-Queue: Benoit Lize <lizeb@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1302573}
2024-05-17 14:47:46 +00:00
Peter Boström
7843eba214
Use NOTREACHED_IN_MIGRATION() in the rest of src/
...
This was generated by replacing " NOTREACHED()" with
" NOTREACHED_IN_MIGRATION()" and running git cl format.
This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.
third_party/crashpad is still excluded, needs to be changed upstream.
Bug: 40580068
Change-Id: Ia5dbaddf53dba2fedefb67f1d428e8b24e9edffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545021
Commit-Queue: Peter Boström <pbos@chromium.org >
Auto-Submit: Peter Boström <pbos@chromium.org >
Commit-Queue: Lei Zhang <thestig@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Owners-Override: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1302314}
2024-05-16 23:41:33 +00:00
Thibaud Michaud
2de2cc1458
[wasm][cleanup] Remove wasm tail-call feature flag
...
The WebAssembly tail-call (aka return call) proposal has been enabled by
default for a long time in Chrome/V8 and has reached phase 4 of the
standardization process.
R=adamk@chromium.org
Change-Id: I6e33dc804b2e51f4455a42594b7ad1f1190da968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5537896
Reviewed-by: Adam Klein <adamk@chromium.org >
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Auto-Submit: Thibaud Michaud <thibaudm@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1301458}
2024-05-15 18:37:17 +00:00
Shu-yu Guo
3f6b3a4fe6
[gin] Remove RAB/GSAB-related features
...
The V8 flag has been removed in crrev.com/c/5516580
Bug: v8:11111
Change-Id: I478c8b1f70b2d1ccb0854d32d0e5ffe15874a4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5535358
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Adam Klein <adamk@chromium.org >
Commit-Queue: Adam Klein <adamk@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1300236}
2024-05-13 19:56:29 +00:00
Eva Herencsarova
f3c64baf87
[v8][wasm][code flushing][gin] Add flag and field trial for code flushing
...
Prepare launch via Finch by adding a gin feature and field trial for
Liftoff code flushing.
Bug: 339120678
Change-Id: Iff319621817d4ddfa3ed9c6dcdd8965c3c444528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526355
Commit-Queue: Eva Herencsárová <evih@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1299164}
2024-05-10 10:47:29 +00:00
danakj
95305d27de
Remove use of the pointer version of RandBytes, use span always
...
The pointer-based crypto::RandBytes() overload can't be removed until
nearby stops using it: https://crrev.com/c/5529443 will do this.
The pointer-based base::RandBytes() will be removed next.
Bug: 40284755
Change-Id: I72c79e23e120f988b091dd2576de180a1c60d2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514816
Commit-Queue: danakj <danakj@chromium.org >
Reviewed-by: Daniel Cheng <dcheng@chromium.org >
Owners-Override: Daniel Cheng <dcheng@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1298850}
2024-05-09 20:38:44 +00:00
Michael Lippautz
52050f0097
fieldtrial: Enable V8's --cppheap-optimize-sweep-for-mutator
...
Description see https://crrev.com/c/5454401 .
Improves
- S3: +2%
- MM: +0.6%
Bug: chromium:333981063
Change-Id: I441ec2fdba9d771b239202dfba912ffc9c58f2f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490661
Commit-Queue: Michael Lippautz <mlippautz@chromium.org >
Reviewed-by: Anton Bikineev <bikineev@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1293286}
2024-04-26 22:09:07 +00:00
Michael Lippautz
dc5c863778
fieldtrial: Enable V8's --idle-gc-on-context-disposal
...
Bug: chromium:333423696
Change-Id: I8082668bbdab45cc7aebd517674cf0706e202966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464468
Commit-Queue: Michael Lippautz <mlippautz@chromium.org >
Reviewed-by: Omer Katz <omerkatz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1291319}
2024-04-23 16:02:41 +00:00
Alison Gale
81f4f2c793
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
...
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/ <old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/ <old id>)
- TODO(https://issues.chromium.org/u/1/issues/ <old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Iee14d10d544e9f0ec046117cc4ec8a55c427adc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469947
Reviewed-by: Darryl James <dljames@chromium.org >
Owners-Override: Alison Gale <agale@chromium.org >
Commit-Queue: Alison Gale <agale@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1290838}
2024-04-22 19:33:31 +00:00
Shu-yu Guo
b962c6cdb7
[gin] Remove features::kJavaScriptSymbolAsWeakMapKey
...
The proposal shipped in Nov 2022, and the V8 flag was removed in Apr
2023.
Bug: v8:12947
Change-Id: I29265818fffeed8f666eeeb0df3769830d69357a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5448481
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1286358}
2024-04-12 08:31:18 +00:00
Shu-yu Guo
ed0873a2c6
[gin] Remove features::kJavaScriptRegExpUnicodeSets
...
The feature shipped in Feb 2023.
Bug: v8:11935
Change-Id: I2ac9c67c96f924011daa2de45781ce7f5f1cc237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5448652
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1286357}
2024-04-12 08:30:42 +00:00
Md Hasibul Hasan
fcbd62e3c8
Convert base::StringPiece to std::string_view in //gin
...
The changes of this CL are made using the following script.
```
target_directory="gin"
replace_string_in_files() {
old_string="$1"
new_string="$2"
find "$target_directory" -type f \( -name "*.cc" -o -name "*.h" \) \
-exec sed -i '' "s/$old_string/$new_string/g" {} +
}
delete_include() {
find "$target_directory" \( -name "*.h" -o -name "*.cc" \) -print0 | while IFS= read -r -d '' file; do
grep -v '#include "base/strings/string_piece.h"' "$file" > "$file.tmp" && mv "$file.tmp" "$file"
done
}
add_include() {
find "$target_directory" \( -name "*.h" -o -name "*.cc" \) -print0 | while IFS= read -r -d '' file; do
local include_added=false
local tempfile=$(mktemp)
if grep -qE 'std::(string|u16string)_view' "$file"; then
while IFS= read -r line; do
echo "$line" >> "$tempfile"
if [[ $line =~ ^\s*#include ]]; then
if ! $include_added; then
echo "#include <string_view>" >> "$tempfile"
include_added=true
fi
fi
done < "$file"
mv "$tempfile" "$file"
if $include_added; then
echo "Added #include <string_view> after the first include line in $file"
else
echo "No include line found in $file"
fi
else
echo "std::string_view not found in $file"
fi
done
}
replace_string_in_files "base::StringPiece16" "std::u16string_view"
replace_string_in_files "base::StringPiece" "std::string_view"
delete_include
add_include
```
Replaced base::StringPiece16 with std::u16string_view
Replaced base::StringPiece with std::string_view
Removed header "base/strings/string_piece.h"
Added header "<string_view>" where applicable
Bug: 40506050
Change-Id: I80c5edb8fdcbed7e003589473a6a91f0920a4bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5431593
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1285023}
2024-04-10 10:38:39 +00:00
Leszek Swirski
2575711dc0
[v8] Add gin flag for --baseline-batch-compilation
...
Change-Id: Iae961676e9a957df25a506676b4fbd7ea99c6857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5435123
Auto-Submit: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1284458}
2024-04-09 14:53:31 +00:00
Shu-yu Guo
225e8b67d6
[gin] Remove features::kJavaScriptParseJsonWithSource
...
The feature has shipped since Mar 2023.
Bug: v8:12955
Change-Id: I43ce6ead6607cb4a744d94af4a8062d0b64a344d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5427171
Commit-Queue: Adam Klein <adamk@chromium.org >
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Adam Klein <adamk@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1283240}
2024-04-05 17:52:52 +00:00
Simon Zünd
09d366b822
[gin] Add flag for V8 Error.stack change
...
This CL adds a kill switch for https://crrev.com/c/5378709 .
R=syg@chromium.org
Bug: 327467399
Change-Id: Ia4d0486d402df8f9cb82a814959c12d84d8a7b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5382165
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Auto-Submit: Simon Zünd <szuend@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1276214}
2024-03-21 14:53:37 +00:00
Etienne Pierre-doray
21b714dfd6
[tasks] Add kV8ConcurrentMaglevHighPriorityThreads feature to control concurrent-maglev-high-priority-threads
...
Bug: 329474305
Change-Id: Id9a07d44cfd5421c9b29f084d6d833981b3dcc13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383906
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1276153}
2024-03-21 12:56:16 +00:00
Daniel Lehmann
c937085fd9
[gin] Add slow histogram for V8 JCC erratum finch
...
This allows us to observe the effect on V8.ExecuteMicroSeconds, i.e.,
the overall time spent in JS execution in V8 with and without the
JCC erratum performance mitigation enabled.
Bug: v8:14225
Change-Id: Idc7b868e3685f91ec1abcebb5ddc84d64344302a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5376492
Auto-Submit: Daniel Lehmann <dlehmann@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1274092}
2024-03-18 12:55:50 +00:00
Olivier Flückiger
d36f6b5c80
gin: Fix the V8ProfileGuidedOptimization flag
...
Enable both flags (as was initially intended) and add the negative variant.
Bug: chromium:41490281
Change-Id: I4b9adc4c36b6d16952d510b7e97ce110a59d343b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5352654
Auto-Submit: Olivier Flückiger <olivf@chromium.org >
Commit-Queue: Olivier Flückiger <olivf@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1272210}
2024-03-13 16:44:06 +00:00
Olivier Flückiger
4f16acc1af
gin: Add missing kill switch for V8EfficienceyModeTiering experiment
...
Bug: chromium:41485666
Change-Id: Iaa41dcc2a5a5844ca6f2490592026b67709b90f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5355932
Commit-Queue: Leszek Swirski <leszeks@chromium.org >
Auto-Submit: Olivier Flückiger <olivf@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1271578}
2024-03-12 15:36:58 +00:00
Arthur Sonzogni
5bc3326c91
Cleanup: Format <optional> include order.
...
This is an automated patch. Please avoid assigning unrelated bug.
#cleanup
This is a follow-up to @thestig comment:
https://chromium-review.googlesource.com/c/chromium/src/+/5009410/7/pdf/accessibility_helper.cc#11
Several developers, including myself rewrote optional without properly
reordering the #includes at the beginning.
This patches automatically fixes it.
Script:
-------
```
function replace {
echo "Replacing $1 by $2"
git grep -l "$1" \
| cut -f1 -d: \
| grep -v \
-e "*win*" \
-e "third_party/*" \
-e "tools/*" \
| grep \
-e "\.h" \
-e "\.cc" \
| sort \
| uniq \
| xargs sed -i "s/$1/$2/g"
}
replace "#include <optional>" ""
git add -u
git commit -m "remove optional"
git revert HEAD --no-commit
git add -u
echo "Formatting":
echo "IncludeBlocks: Regroup" >> ".clang-format"
echo "IncludeIsMainRegex: \"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\"" >> ".clang-format"
git add -u
git cl format --upstream=HEAD
git checkout origin/main -- ".clang-format"
git add -u
git commit -m "revert with format"
git reset --soft origin/main
git add -u
git commit -m "Automated format"
```
cleanup: This is a no-op patch formatting includes.
Bug: 40288126
Change-Id: I5f61b1207c097a4c6b20a034f9d1b323975b1851
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5335142
Owners-Override: Lei Zhang <thestig@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1267143}
2024-02-29 19:39:05 +00:00
Daniel Lehmann
456950c7ff
[gin] Add feature for V8 JCC erratum mitigation
...
...such that we can observe real-world performance impact via a Finch
trial (which I will set up subsequently.)
Bug: v8:14225
Change-Id: Ia26b42bdaa1e74e068aed6684387f7357132ab9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5281924
Reviewed-by: Clemens Backes <clemensb@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Commit-Queue: Daniel Lehmann <dlehmann@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1258477}
2024-02-09 14:05:54 +00:00
Shu-yu Guo
bf2f7aa60d
[gin] Add flag for RegExp duplicate named groups
...
Bug: v8:13173
Change-Id: I3787f60c16ea27955612af1c7e1f734b10b0b2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5252327
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1254649}
2024-01-31 19:01:55 +00:00
Peter Boström
d9f666879b
Mark LOG(FATAL) [[noreturn]]
...
This removes dead code as a result of making sure that the compiler
knows that LOG(FATAL) is [[noreturn]] directly within the translation
unit.
LOG(DFATAL) and DLOG(FATAL) are intentionally not [[noreturn]] as they
can't be in the release build.
Except for invariants already split out in crrev.com/c/5195484 it's not
trivial to me that any of the the remaining FATALs are invariant
failures within our code, so they were not updated to use CHECKs.
Bug: 1409729
Change-Id: I59e44a5bb53d69ae44600f833146b72c07edf81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191363
Reviewed-by: Lei Zhang <thestig@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Owners-Override: Lei Zhang <thestig@chromium.org >
Commit-Queue: Peter Boström <pbos@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1247836}
2024-01-17 00:00:20 +00:00
Olivier Flückiger
43e22a76c0
Reland "gin: add V8ProfileGuidedOptimization feature and fieldtrial config"
...
This is a reland of commit 703c5d7ce7https://chromium-review.googlesource.com/c/chromium/src/+/5185434
> Auto-Submit: Olivier Flückiger <olivf@chromium.org >
> Reviewed-by: Camillo Bruni <cbruni@chromium.org >
> Reviewed-by: Leszek Swirski <leszeks@chromium.org >
> Commit-Queue: Camillo Bruni <cbruni@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1245821}
Bug: chromium:1517302
Change-Id: I8b04d17026ad995ce2fd3c340bdbc248b116dd53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189021
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Commit-Queue: Olivier Flückiger <olivf@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1247464}
2024-01-16 12:46:20 +00:00
Rezvan Mahdavi Hezaveh
dde4721b8e
[gin] Add flag for set methods
...
This CL adds a kill switch for set methods flag in v8.
Bug: v8:13556
Change-Id: I506705ab2ba97a27fffd3065625e6838105e7f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5187068
Reviewed-by: Adam Klein <adamk@chromium.org >
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1246706}
2024-01-12 22:21:44 +00:00
Andreea Costinas
bb40a38506
Revert "gin: add V8ProfileGuidedOptimization feature and fieldtrial config"
...
This reverts commit 703c5d7ce7https://chromium-review.googlesource.com/c/chromium/src/+/5185434
> Auto-Submit: Olivier Flückiger <olivf@chromium.org >
> Reviewed-by: Camillo Bruni <cbruni@chromium.org >
> Reviewed-by: Leszek Swirski <leszeks@chromium.org >
> Commit-Queue: Camillo Bruni <cbruni@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1245821}
Bug: chromium:1517302, b/318757609
Change-Id: Ifd52bdd06eeb1080f3bc351a98aa4a551b817417
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191153
Auto-Submit: Andreea Costinas <acostinas@google.com >
Commit-Queue: Andreea Costinas <acostinas@google.com >
Reviewed-by: Andreea Costinas <acostinas@google.com >
Owners-Override: Andreea Costinas <acostinas@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1246367}
2024-01-12 10:24:57 +00:00
Olivier Flückiger
703c5d7ce7
gin: add V8ProfileGuidedOptimization feature and fieldtrial config
...
Bug: chromium:1517302
Change-Id: I24ca73f680479bc406135a7f9dba316c69602ae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185434
Auto-Submit: Olivier Flückiger <olivf@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Commit-Queue: Camillo Bruni <cbruni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1245821}
2024-01-11 14:35:14 +00:00
Nicolò Ribaudo
cc6f957216
[gin][import-attributes] Add base feature for import attributes
...
Bug: v8:13856
Change-Id: I717b319914a518244a05162ee8ff606967d49165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5176911
Reviewed-by: Adam Klein <adamk@chromium.org >
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1244718}
2024-01-09 16:44:57 +00:00
Dave Tapuska
b9272751a7
[gin] Remove some long expired histograms
...
- Purge code since they haven't been active in a few years.
Bug: 1508059
Change-Id: I85b0529aeceb2faafdaa6f51d723b4485a2a70cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5105691
Commit-Queue: Dave Tapuska <dtapuska@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1241943}
2024-01-02 16:13:20 +00:00
Shu-yu Guo
924f273d09
[gin] Add base feature for regexp modifiers
...
Bug: v8:12956
Change-Id: Idb718793747d65fa4252ab267f207ccd6a73b77e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5142292
Auto-Submit: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Adam Klein <adamk@chromium.org >
Commit-Queue: Adam Klein <adamk@chromium.org >
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1239894}
2023-12-20 23:32:14 +00:00
Olivier Flückiger
c722bf48d2
gin: add kV8EfficiencyModeTiering feature and fieldtrial config
...
Bug: chromium:1513093, v8:14515
Change-Id: I3dbc8c95c5689cb7c349f3c48cc6e9edf9c46afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5132394
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Auto-Submit: Olivier Flückiger <olivf@chromium.org >
Commit-Queue: Camillo Bruni <cbruni@chromium.org >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1239645}
2023-12-20 12:47:42 +00:00
Manos Koukoutos
183e930def
[v8][wasm] Add blink flag for Turboshaft wasm instruction selection
...
Bug: chromium:1496282
Change-Id: I412cd642faf69351170d3f92515e09dc636b1b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076859
Reviewed-by: Leszek Swirski <leszeks@chromium.org >
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Commit-Queue: Manos Koukoutos <manoskouk@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1231941}
2023-12-01 15:43:05 +00:00
