As a part of Files.app's re-design, app name should be gone.
BUG=402344
TEST=none
Review URL: https://codereview.chromium.org/862263002
Cr-Commit-Position: refs/heads/master@{#312575}
In the current implementation |web_encrypted_media_client_| is leaked.
BUG=450777
Review URL: https://codereview.chromium.org/865683004
Cr-Commit-Position: refs/heads/master@{#312569}
All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now.
BUG=442514
Review URL: https://codereview.chromium.org/824243004
Cr-Commit-Position: refs/heads/master@{#312568}
This CL implements Bluetooth Audio Sink API for ChromeOS platform,
where user applications can register/unregister a BT audio sink
via BlueAdapter interface. This API acts as a middle layer hiding
the components of BlueZ/D-Bus.
BUG=441581
Review URL: https://codereview.chromium.org/787743002
Cr-Commit-Position: refs/heads/master@{#312562}
Fix the GPU tests' cloud_storage_test_base to follow this requirement.
BUG=450673
Review URL: https://codereview.chromium.org/865653004
Cr-Commit-Position: refs/heads/master@{#312561}
The ffmpeg build on mips is broken which manifests in build errors when
z,defs is specified. The owners of this build would like the compile
time error to be suppressed for now while they work on a proper fix.
BUG=450771,371125
Review URL: https://codereview.chromium.org/864193002
Cr-Commit-Position: refs/heads/master@{#312557}
All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now.
BUG=442514
Review URL: https://codereview.chromium.org/809553005
Cr-Commit-Position: refs/heads/master@{#312553}
The current v1 web-app allows users to sign in as any user. Some users may
be signed in using a different account than their chrome profile.
When these users upgrade to the v2 app, their host list will be empty and
it is not straightforward why.
This CL shows a migration tip to inform the users to sign-in to their
previous account if necessary.
BUG=369835
Review URL: https://codereview.chromium.org/848993002
Cr-Commit-Position: refs/heads/master@{#312549}
The print preview dialog uses the initiator WebContents to determine its
size. For prints from embedded GuestViews, this can cause print preview
dialogs to be smaller than normal. This CL fixes this by changing
PrintPreviewDialogDelegate::GetDialogSize() to follow the chain of
GuestView embedders to find the outermost WebContents and use it to
determine the dialog size.
BUG=450564
Review URL: https://codereview.chromium.org/867493002
Cr-Commit-Position: refs/heads/master@{#312545}
glFenceSync
glIsFence
glDeleteFence
Most of the work is to deal with the fact that GLsync is not like any other ID types (GLuint).
BUG=429053
TEST=gpu_unittests
Review URL: https://codereview.chromium.org/859043005
Cr-Commit-Position: refs/heads/master@{#312544}
Compiling with -Wl,-z,defs and asan requires declaring a dependency on
//build/config/sanitizers:deps in every shared_library and executable,
however piles and piles of targets do not do this yet so this flag busts
the asan/etc builds in GN. Disable for now so we can add the
dependencies bit by bit.
R=thakis@chromium.org
BUG=371125
Review URL: https://codereview.chromium.org/810563008
Cr-Commit-Position: refs/heads/master@{#312543}
The previous design provided a callback so that an external function could log the progress,
but since it's not possible to log anything until the signal strategy has connected, that
doesn't make a lot of sense. The new design instead tracks progress internally and sends it
when the connection is established.
BUG=432171
Review URL: https://codereview.chromium.org/855003008
Cr-Commit-Position: refs/heads/master@{#312542}
components/nacl/renderer/ had three mappings from PP_Instance IDs:
* mapping to NexeLoadManager
* mapping to JsonManifest
* mapping to InstanceInfo
Merging these into one will make it easier to add more per-PP_Instance
state in the future.
This also makes the lifetime of the objects mapped from PP_Instances
clearer. This should fix a leak of InstanceInfo if untrusted code
never calls the StartPpapiProxy IPC (though the IPC::ChannelHandle in
it will still leak since this isn't owned).
BUG=428030
TEST=NaCl tests in browser_tests
Review URL: https://codereview.chromium.org/856583003
Cr-Commit-Position: refs/heads/master@{#312540}
These tests are essentially copies of the HID device add and remove
event tests. In order to reconcile issues with the MockUsbService
lifetime it is now tracked by a MessageLoop::DestructionObserver at the
generic UsbService level. This is similar to the pattern used by the
HidService until it was moved to the UI thread and could use a
LazyInstance.
BUG=411715
Review URL: https://codereview.chromium.org/800963005
Cr-Commit-Position: refs/heads/master@{#312538}
Due to crbug.com/445048, extensions without incognito: split within their manifest no longer run outside of a logged in user session. This caused some component extensions to stop working in specific contexts (e.g. ChromeVox in OOBE).
BUG=450705
TEST=manual.
Review URL: https://codereview.chromium.org/862183002
Cr-Commit-Position: refs/heads/master@{#312537}
All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now.
BUG=442514
Review URL: https://codereview.chromium.org/860323002
Cr-Commit-Position: refs/heads/master@{#312535}
This CL is the first step in a series of CLs to improve the WebContentsObserver interface and make it more consistent for RenderFrame(Host) notifications. It renames FrameDetached to FrameDeleted, to make it more generic and improved comments to reflect what objects the notification is about.
BUG=450799
Review URL: https://codereview.chromium.org/865723002
Cr-Commit-Position: refs/heads/master@{#312534}
SyncController handles the coordination of sync state
between the invalidation controller, the Android sync
settings, and the native sync code. Sync state can be
changed from four places:
- The Chrome UI, which will call SyncController directly.
- Native sync, which can disable it via a dashboard stop
and clear.
- Android's Chrome sync setting.
- Android's master sync setting.
SyncController implements listeners for the last three
cases. When master sync is disabled, we are careful to not
change the Android Chrome sync setting so we know whether
to turn sync back on when it is re-enabled.
BUG=428882
Review URL: https://codereview.chromium.org/852473002
Cr-Commit-Position: refs/heads/master@{#312533}
1. add checkbox
2. add new pref
3. move checkbox to top of dialog (near mac contact book checkbox)
BUG=446698
Review URL: https://codereview.chromium.org/858053003
Cr-Commit-Position: refs/heads/master@{#312532}
Mac was the only platform to do this, and more recent versions
of the OS do not support it anymore. Callers to these functions
have been removed from the Blink side.
BUG=248742
Review URL: https://codereview.chromium.org/838603002
Cr-Commit-Position: refs/heads/master@{#312529}
Take the set of KeyInformation and pass it on to blink.
Layout tests will be updated to verify this event in a subsequent CL.
BUG=432671
TEST=existing EME tests pass
Review URL: https://codereview.chromium.org/855773002
Cr-Commit-Position: refs/heads/master@{#312528}
