In some cases, we'll fail to create an SkBitmap (for instance, when
printing via `TestRunner::PrintFrameToBitmap()`. We handle those cases
safely in general, but we missed a check against the color space here.
This CL punts out of image encoding early when it's unnecessary (and
impossible).
Bug: 397018488
Change-Id: If5a43f24312639391d482081671963e151040cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287486
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1423778}
Encoding associated interfaces passed as function call arguments relies
on the correct calculation of the dimensions of the paramStructSpec of
the said function call.
This is done in `computeStructDimensions` which internally calls
`computeDimensions` on each struct field.
The issue comes from `computeStructDimensions` assuming all calls to
`computeDimensions` return a numInterfaceIds which is not the case.
This fix makes sure to check if a numInterfaceIds is returned before
updating the `numInterfaceIds` for the paramStructSpec dimensions.
Change-Id: Iee4ae5d84c697450f800cf1c46aaa83bfb5ef5b6
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6272375
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Ali Hijazi <ahijazi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421086}
Web tests depend on Ahem being available as a system font. To achieve
this, the DWriteFontProxy sideloads Ahem in its internal collection.
This doesn't provide Ahem to the browser process' underlying font
manager, which makes it so FontDataManager can't see Ahem in web tests.
This CL sideloads the font in the browser's dwrite font manager, which
is used by the FontDataManager. This allows web tests that depend on
Ahem to pass when using FontDataManager.
Bug: None
Change-Id: Id56da6ac99070a4ac7f65436b86e68cd5c6de320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250577
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418296}
Target.exposeDevToolsProtocol creates a new DevToolsAgentHostClient that
does not inherit permissions by default. To support WebDriver
implementation that relies on exposeDevToolsProtocol to create isolated
sessions, this CL allows the client to specify that current client
permissions need to be inherited. This is needed to let WebDriver access
Extensions domain commands to implement
https://w3c.github.io/webdriver-bidi/#module-webExtension
Bug: 393500934
Change-Id: Iaa2b339950ce1e22125f4872c0e962055aa183ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6217068
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418087}
Graphite has stuck in fieldtrial_testing_config.json and we are
experimenting on stable in Mac-ARM, so it's time to move the layout tests
on this platform to use Graphite. Rebaselines tests as necessary via
third_party/blink/tools/blink_tool.py rebaseline-cl .
In this CL we move only Mac14 to limit the scope of the change. We will
follow up with other OS versions.
Sheriffs: If this CL results in layout test failures please
rebaseline/add suppressions if at all feasible and CC me rather than
reverting the CL.
Include-Ci-Only-Tests: true
Bug: 40937352
Change-Id: I123cccc7ee9c7cec32fe8f4596c744a495b6bf25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179215
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413635}
Replace WebVector (which has been an alias of std::vector since
crrev.com/c/6204022) with std::vector.
function cg() {
git grep --name-only "$1" -- *.mm *.h *.cc
}
sed -i 's/include.*web_vector.h"/include <vector>/' `cg web_vector.h`
sed -i '/^using blink::WebVector;/d' `cg 'using blink::WebVector'`
sed -i '/^using ::blink::WebVector;/d' `cg 'using ::blink::WebVector'`
sed -i 's/blink::WebVector\b/std::vector/g' `cg blink::WebVector`
sed -i 's/\bWebVector\b/std::vector/g' `cg WebVector`
git checkout -- third_party/blink/public/platform/web_vector.h
git cl format
Only manual changes are to remove unused "#include <vector>" added by
the above script, based on presubmit warnings.
BYPASS_LARGE_CHANGE_WARNING=`git cl split` will create too many CLs needing too many reviewers while this CL doesn't need much manual review.
Bug: 40865165
Change-Id: Ib70af44863ceaa73f470c77abe74d8994e2822a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6209609
Owners-Override: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1412669}
This allows Headless to explicitly tell content what it's trying to do
rather than patch out the platform underneath content, which frees
content to do reimplementation of popup menus.
Bug: 389067059
Change-Id: If9996c55f5c5313f1abe54731c08c8585a04a3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187262
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409664}
Converts to the functionally-equivalent new API that holds the
SharedMemoryMapping inside the ClientSharedImage and exposes it via
ScopedMapping.
Bug: 40064122
Change-Id: I185a87ec0fb121c9235d17472dc9f057bf4627ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110451
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398531}
- Remove IS_CHROMEOS_LACROS code
- Replace IS_CHROMEOS_ASH with the equivalent IS_CHROMEOS
- Similarly for is_chromeos_lacros/is_chromeos_ash.
- Drop obsolete includes/build dependencies.
- Drop lacros-chrome browser tag from gpu tests
- Drop obsolete skip directives from gpu tests
No change in behavior.
Bug: b:365742770 , b:365741912
AX-Relnotes: n/a.
Change-Id: I594d3677a9855d0649deba3ad836a1b3804440f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097832
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398368}
Remove code behind IS_CHROMEOS_LACROS, as well as the following
obsolete files in chrome/browser/speech:
- tts_client_factory_lacros.*
- tts_client_lacros.*
- tts_external_platform_delegate_impl_lacros.*
- tts_lacros.*
Also remove interfaces that no longer have an implementation:
- content::ExternalPlatformDelegate
- content::RemoteTtsEngineDelegate
No change in behavior.
AX-Relnotes: n/a.
Bug: b:373971535, b:365741912
Change-Id: Iea8014f30e139172ee8db1aede34964144ca2577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087237
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/main@{#1395245}
Rename SharedImageUsage SHARED_IMAGE_USAGE_CPU_WRITE to
SHARED_IMAGE_USAGE_CPU_WRITE_ONLY in order to clarify the intent that
this usage is only meant for write only and not read.
This was required as all the other WRITE usages we have also implies
READ as well.
This CL is a no-op and strictly just a rename.
Bug: 40264379
Change-Id: I7e7a4e5102ad422d1b73b9cf02751c6944cfa12e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6071632
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1393191}
Take into account third party cookie blocking flags when resetting the
third party cookie blocking state after each test.
This allows us to run all web tests with or without third party cookie
blocking.
Without this change, forcing third party cookie blocking through flags
would only work for the first test, since third party cookie blocking
would be disabled after the first.
Change-Id: Ic75e08d2cfd0022513a8cc8773980de52f98a828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049845
Auto-Submit: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388449}
There are exactly four use-cases that create layer with flipped = true:
* DrawingBuffer, flip depends on composition and MESA_framebuffer_flip
* ImageLayerBridge: This used to update flip for each resource
* PepperPluginInstanceImpl for Graphics3D case. This is the only case
which uses SetTransferableResource instead of TextureClient
* TestPlugin: Always uses bottom-left.
This CL makes TransferableResource adjustment right the place where
we pass it to TextureLayer, to make sure it's no-op.
Follow-up will push them closer to place where we create the resource.
This allows to remove flip from TextureLayer entirely.
Bug: 378688985
Change-Id: Ide4b81711db84ecb469bf3ee3731ec3e055489fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039385
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388225}
TextureLayer was flipped by default, but most production use-cases
would call SetFlipped right after that. This CL adds param to ctor to
avoid default value.
It also updates all unit tests that don't care about flipped to pass
false.
Bug: 378688985
Change-Id: I33235d0970bc023155ae9bb70c591c7f4239aa0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039088
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388200}
In most cases NOTREACHED() is now a better option. Also performs
dead-code removal.
Bug: 40122554
Low-Coverage-Reason: OTHER Should-be-unreachable code
Change-Id: I3d9054619242c472feadab98d9de4024c74d4992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013928
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1385678}
Suppress GL_DEBUG_TYPE_PERFORMANCE log messages for web tests that can
get sent to the JS console and cause unnecessary test failures due to
test output log expectation comparisons.
Tested by removing suppressions for tests due to such failures in PS5
and adding mac-skia-alt-arm64-blink-rel bot.
Bug: 374090995
Change-Id: Id211e17e0f92f29af2faaadb9f806323162d9437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6018367
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382695}
This adds bits on LoadURLParams and NavigationRequest to indicate that
a new compositor is needed, and sets them to true when navigating to
about:blank?reset-web-test.
A follow-up patch will implement the new navigation behavior.
Bug: 40946696
Change-Id: I2284ed6c9ba2d082d41238c98916320b503fbeba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808877
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1381762}
It was previously possible for pickers like <select>'s picker to be
shown on top of the not-currently-focused tab, confusing the user.
With this change, the select picker must be the currently-focused
tab for the picker to be opened. This is akin to existing protections
for the tab being visible.
Fixed: 365089001
Change-Id: Id2b15f5d310cce877341d7e9d5a5c5d6da882887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5909884
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1377731}
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
The former is [[noreturn]] so this CL also performs dead-code removal
after the NOTREACHED().
This CL does not attempt to do additional rewrites of any surrounding
code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
This does clean up kCrashOnDanglingBrowserContext as both paths of the
kill switch are currently fatal. This has been rolled out for a long
time.
Bug: 40580068, 40062641
Change-Id: Ib88e710d003e2e48df3fc502ca54d2341d157a0e
Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel
Low-Coverage-Reason: OTHER Should-be-unreachable code
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5974816
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376522}
Move some more blink media code into platform/media from public/platform/media. This allows us to use KURL directly and
not go to a WebURL on some calls.
Apply INSIDE_BLINK macro to other code that is in platform/media so
it will use the internal types. This is necessary because this code uses
blink mojom types and we want to enforce that blink mojo headers are
only included inside blink. Fortunately this addresses some of the
discouraged type overrides in the media code.
BYPASS_LARGE_CHANGE_WARNING=File move
Change-Id: I712128d82bb7e1971548f22aaadfdf31a7393ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962517
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1374973}
For web tests this stops WindowEventDispatcher::SynthesizeMouseMoveEvent
from sending the renderer a mousemove, which it normally does on startup
and whenever we swap in a new RenderWidgetHostView.
The benefits of this change are:
- Eliminating potential flakiness by making the web tests more order-
agnostic. Tests can behave differently with the mouse at (0,0) versus
the position-unknown state which is restored in between test runs by
EventHandler::ResetLastMousePositionForWebTest. This also helps to
de-risk upcoming web test isolation changes (go/web-test-isolation).
- Aligning Windows and Linux behavior with Mac. AppKit sends a native
mousemove to a new on-screen RWHV, similar to what Aura synthesizes.
But AppKit does NOT send these mousemoves to headless web tests.
Bug: 374783343
Change-Id: I6b1d7234410cd6fa799954845bb5b50f5a2b82ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808379
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372147}
