1. Add enable_gpu_service_logging GN argument. This can be used in
Release builds without dcheck_always_on=true, and allows the
--enable-gpu-service-logging command line argument to work.
2. Add about flag 'Enable gpu service logging' to let non-rooted
devices enable the --enable-gpu-service-logging flag.
Bug: 839769
Change-Id: Ic6fe4d97aaa6deb51b1f4d30ac4e7aeeaf8b4700
Reviewed-on: https://chromium-review.googlesource.com/c/1401616
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622252}
This can be used in Release builds without dcheck_always_on=true, and
allows the --enable-gpu-client-logging command line argument to work.
Bug: 910783
Change-Id: I0720b7eb0c735de4d08ba50d69b41060eb387d63
Reviewed-on: https://chromium-review.googlesource.com/c/1357623
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612900}
This reverts commit f17419f416.
Reason for revert: Microsoft responded to twitter reports and fixed
their detection so this isn't needed anymore. I'm retaining the typo
fix though!
Original change's description:
> Modify markdown to satisfy Windows Defender
>
> debugging_gpu_related_code.md explains how to use a Chrome command-line
> switch which has been used for arbitrary code execution. Windows
> Defender therefore treats it as malware. This means that some Windows
> Chromium developers will get anti-virus warnings (with mandatory
> quarantining of the file). If Chrome is in a directory that is
> excluded from scanning then they will avoid warnings but will hit
> problems if they try to use Windows backup.
>
> This is all very silly since there is no way - short of manually
> following the steps, modify to be malicious - to activate this payload.
> Windows Defender even complains about the file created by this:
>
> > echo --no-sandbox --gpu-launcher="x" >foo.txt
>
> But, sometimes it's not worth arguing.
>
> This also fixes a typo.
>
> R=kainino@chromium.org
> BUG=851562
>
> Change-Id: I85403a1cb1667f45784684179927119058608d40
> Reviewed-on: https://chromium-review.googlesource.com/1096311
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566245}
TBR=brucedawson@chromium.org,kainino@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 851562
Change-Id: I60b09d8e6a698c1646f5c4bb0ecab16f999bfb9c
Reviewed-on: https://chromium-review.googlesource.com/1100255
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567294}
debugging_gpu_related_code.md explains how to use a Chrome command-line
switch which has been used for arbitrary code execution. Windows
Defender therefore treats it as malware. This means that some Windows
Chromium developers will get anti-virus warnings (with mandatory
quarantining of the file). If Chrome is in a directory that is
excluded from scanning then they will avoid warnings but will hit
problems if they try to use Windows backup.
This is all very silly since there is no way - short of manually
following the steps, modify to be malicious - to activate this payload.
Windows Defender even complains about the file created by this:
> echo --no-sandbox --gpu-launcher="x" >foo.txt
But, sometimes it's not worth arguing.
This also fixes a typo.
R=kainino@chromium.org
BUG=851562
Change-Id: I85403a1cb1667f45784684179927119058608d40
Reviewed-on: https://chromium-review.googlesource.com/1096311
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566245}