Null aggregatable reports are just a special case of aggregatable
reports, so this eliminates various redundant code paths.
This CL contains no intentional user-visible behavioral changes.
BYPASS_LARGE_CHANGE_WARNING=refactoring change with net-negative LoC
Change-Id: I3d0433297b831207174887587bbfdf8b5be0a90e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5709639
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373514}
This CL deprecates support for SDK version 22621, meaning we now
require version 26100 for all builds. It also updates mc.exe checks to operate using the new SDK version. Note that mc (and midl) output did not output anything new when regenerated, although crrev.com/c/5954139 removes some obsolete outputs.
The change to windows_version.cc caused the regular MSI installers to be regenerated. The branded installers did not change.
Since we now support only SDK version 26100, we can remove the conditional code compilation added in the original CL (crrev.com/c/5898835).
Bug: 362650376
Change-Id: I1150151f9105d9478c5ec23be53fd139118eddaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5949523
Reviewed-by: S Ganesh <ganesh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373513}
This contains a fix for expanding GPU telemetry tests that have a
variant applied to them so that the variant identifier doesn't appear as
part of the test name in the arguments.
NO_IFTTT=Bringing starlark implementation into parity with //testing/buildbot re:stripping variant ID from test name
Bug: 40258588
Change-Id: Ifd281b5c68ba02998156c6a2875ce7a2591db59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958194
Commit-Queue: Wanda Mora <morawand@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Wanda Mora <morawand@google.com>
Cr-Commit-Position: refs/heads/main@{#1373512}
Update our process for generating the intermediate build output
that we check in. The main changes are extending remc.bat to do a
more complete job in generating the mc files automatically, and
removing old mc output in base/trace_event that we don't need
since crrev.com/c/2171974 removed the corresponding build target.
Since remidl.bat has been superseded by tools/win/update_idl.py,
we remove it. We update the readme to mention how the outputs can
be regenerated using the scripts.
I also tried regenerated the mc and midl output for the 26100 SDK
update, but nothing needed updating.
Also some metadata changes in the readme to satisfy presubmits.
Bug: 362650376
Change-Id: I6b647672a6491d53c1dbd9b2eb9e0fee51c5fcbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954139
Reviewed-by: S Ganesh <ganesh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Devon Loehr <dloehr@google.com>
Cr-Commit-Position: refs/heads/main@{#1373511}
- Tabs, Extensions, and System will be the default categories. Platform specific categories may be added in later (e.g. Chrome Apps, ARC, etc.)
- Clicking on these categories will filter the list of processes shown in the table.
- The Search Bar (when implemented) will provide an additional level of granularity for the user (e.g. users that have hundreds of tabs open).
Screenshot Demo: https://screenshot.googleplex.com/5m33GxHYqYSU9mX
Change-Id: I3fa707f393596a265b863ca28d8b94cce884c36f
Bug: b:366251764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5926542
Commit-Queue: Michael Wojcicka <mwoj@google.com>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373509}
Android S+ changed how they grant Bluetooth permissions to apps. While
the production code was fixed in crrev.com/c/3064219, tests were left
broken. crrev.com/c/5887570 fixed it, so we can re-enable them now.
BUG=40206151
TEST=CQ
Change-Id: I681ceb2356ec90c5377ae18fa923527a0b3169bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5957884
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Garfield Tan <xutan@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#1373504}
It appears that there is no unsafe buffers usage in this file and the
annotation was either a false positive or the root cause has been
addressed since it was added.
Bug: 40285824
Change-Id: Ib3ef84356d96d986c9a1f858466a926084f9181a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953276
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373499}
`VariationsCommandLine::ToString()` could add the `--disable-field-trial-config` flag to the variations command output, which will raise a `ValueError: Wrong format, expected name=value, got disable-field-trial-config` error when bisecting.
Bug: None
Change-Id: Ie741ec12730baeea3ff19edee17e77cfdb58f006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960724
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373498}
This CL cleans up all haTS implementation related to PrivacySandbox4 settings.
NO_IFTTT=if/change block around a larger section then needed,
thus affecting my code. To be addressed in b:372479795.
Bug: b:369351303
Change-Id: Iaac9c08d2f6abf999d4ac7126a2427e16ba59a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908102
Commit-Queue: Aashna Sheth <aashnas@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Abe Boujane <boujane@google.com>
Reviewed-by: Alvin Lam <alvingo@google.com>
Cr-Commit-Position: refs/heads/main@{#1373495}
These histograms are still useful to check MIDI usage as we finalize
the Web MIDI specification.
Also make mjwilson the first owner.
Bug: 374763937
Change-Id: I3297c09d8f024f6aad9b7bb31418f0c5219fdcf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958173
Commit-Queue: Michael Wilson <mjwilson@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373494}
In particular, all the SVG code is placed in one place, and several
instances of
if (foo)
builder.SetFlag();
if (bar)
builder.SetFlag();
have been combined.
Change-Id: I9e34a5696157ffd5bcbfcda946e3fc24c1bd87aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962456
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373489}
The telemetry API was stubbed out a few years ago but our hosts
keep sending events which are ignored. This CL removes the Me2Me
impl as it ends up writing errors to the host log for robots which
do not have a Me2Me host OAuth scope. It2Me logging will be
removed in a separate CL.
Change-Id: I6bc890aad032088cf2c5d17af9a4838cd1227639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5948624
Auto-Submit: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373484}
Add support to the `tools/perf/crossbench_result_converter.py` to convert `loadline_probe.csv` to `perf_results.json` with histogram JSON format.
Bug: 371988599
Change-Id: I3442bed85f631f319d599ca3a5f67b3409ff7476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960202
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Farid (Mojtaba) Faridzad <faridzad@google.com>
Cr-Commit-Position: refs/heads/main@{#1373481}
As Chrome does no longer contain chrome-headless-shell code we are
removing workarounds which were activated in presence of the "headless"
flag in the browser command line arguments.
Bug: 42323387
Change-Id: Ieb2cc8224a190b5839ff02bedc1a840cd0f220aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961602
Reviewed-by: Alex N. Jose <alexnj@chromium.org>
Commit-Queue: Vladimir Nechaev <nechaev@chromium.org>
Commit-Queue: Alex N. Jose <alexnj@chromium.org>
Auto-Submit: Vladimir Nechaev <nechaev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373476}
The platform-specific assertion that this was originally added
for was intended for chromeos and cast devices, which both used
ozone. However, cast devices running on Android use the same
stack as clank, which considers these failures recoverable.
It was only because of a point of confusion in migrating the old
IS_CHROMECAST flags to IS_CASTOS and IS_CAST_ANDROID that Android
cast receivers were added to this list.
Bug: 374700681
Test: repro steps in bug
Change-Id: I205c7d6c5a1031755a4d182cdb110f02dc8dc4ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958178
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373472}
The `is_third_party_request` metadata is only used externally in the
CookieSettings to determine whether a 3PC related cookie access should result in an issue in DevTools.
Bug: 371586244
Change-Id: If2a3135b3e8800e3d4e89ce61a37adb0ec51ed02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5920217
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373466}
