0
Commit Graph

31 Commits

Author SHA1 Message Date
b445bdfb10 android_debugging_instructions.md: Point out that GDB is broken
Bug: 1266055
Change-Id: I20603508f963aa84f73a5845d0dea59092a91eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5063508
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1229351}
2023-11-27 16:35:28 +00:00
46cb4f7cfe Remove components/autofill_assistant
b: b:259509313
Change-Id: I9063e8d72ee15933c3bf3425295e583a81eeb80c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4075567
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Florian Gauger <fga@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1080337}
2022-12-07 15:08:17 +00:00
ffc475b8a2 Add instructions for accessing Android app data directories on a non-rooted device
This is based on agrieve@'s instructions in https://bugs.chromium.org/p/chromium/issues/detail?id=1375035#c23

Change-Id: I5f750da97a41fed16b91dde9de18877cf205c63a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4006398
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067580}
2022-11-04 17:55:08 +00:00
f189506013 android_debugging_instructions.md: Add fix for "Attach to Local Process"
Change-Id: Ib9fae5803392c2af7f5951b6645f2b9dc07e9506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715369
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015971}
2022-06-20 18:48:45 +00:00
046f987e02 [COIL] Change chromium code search type links to use main rather than master for docs
See this doc: go/chromium-coil-change for more info
    BUG=1210385

Change-Id: I6cd8548301e360bae8e71384dbd8ef11aa6c985f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2902904
Reviewed-by: My Nguyen <myy@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Auto-Submit: John Palmer <jopalmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885851}
2021-05-24 01:24:56 +00:00
12ddacb255 Add link to internal Android debugging instructions
Bug: None
Change-Id: Ia5efcfaf1a165487e4b449eebfa5f42448539d35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416455
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808178}
2020-09-18 01:29:25 +00:00
cdbc63e812 Delete chrome_public_modern_apk
Leaves chrome_public_modern_bundle (not sure if we want to change this).
Leaves chrome_public_apk, because that is what people (and bots) are used to
using.

TBR=dpranke  # Holiday and want to fix downstream.

Bug: 1097998
Change-Id: I9f7afbdc2ab027066507b1e64021c6722de55a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258364
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785066}
2020-07-03 16:16:57 +00:00
17a59653c6 Reland : Make java_deobfuscate not require being built first
This reverts commit 036098e4d0.

Reason for revert: No changes to this commit.
Fixed by: 02aeb6b215

Original change's description:
> Revert "Reland "Make java_deobfuscate not require being built first""
> 
> This reverts commit d80699f215.
> 
> Reason for revert: Broke swarming again:
> https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel/783
> 
> Original change's description:
> > Reland "Make java_deobfuscate not require being built first"
> > 
> > This reverts commit 0b8c0e6a09.
> > 
> > Reason for revert: Fixed runtime deps
> > 
> > Original change's description:
> > > Revert "Make java_deobfuscate not require being built first"
> > >
> > > This reverts commit 962e70305e.
> > >
> > > Reason for revert: Failing on swarming
> > > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747
> > >
> > > Original change's description:
> > > > Make java_deobfuscate not require being built first
> > > >
> > > > Makes the tool easier to use, and easier to document how to use by not
> > > > requiring it to be built first. We have only a single non-prebuilt .java
> > > > file, so it's easy enough to just check in the .class file for it.
> > 
> > Bug: 995290
> > Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Sam Maier <smaier@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751322}
> 
> TBR=agrieve@chromium.org,smaier@chromium.org
> 
> Change-Id: I7510d193931940176178ad6f68122f634ed59e93
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 995290
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108612
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751394}

TBR=agrieve@chromium.org,smaier@chromium.org

Bug: 995290
Change-Id: Ia51d50638d859d27e081ff0689b4c5877a02e8c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109817
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751713}
2020-03-19 18:14:53 +00:00
036098e4d0 Revert "Reland "Make java_deobfuscate not require being built first""
This reverts commit d80699f215.

Reason for revert: Broke swarming again:
https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel/783

Original change's description:
> Reland "Make java_deobfuscate not require being built first"
> 
> This reverts commit 0b8c0e6a09.
> 
> Reason for revert: Fixed runtime deps
> 
> Original change's description:
> > Revert "Make java_deobfuscate not require being built first"
> >
> > This reverts commit 962e70305e.
> >
> > Reason for revert: Failing on swarming
> > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747
> >
> > Original change's description:
> > > Make java_deobfuscate not require being built first
> > >
> > > Makes the tool easier to use, and easier to document how to use by not
> > > requiring it to be built first. We have only a single non-prebuilt .java
> > > file, so it's easy enough to just check in the .class file for it.
> 
> Bug: 995290
> Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751322}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: I7510d193931940176178ad6f68122f634ed59e93
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 995290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108612
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751394}
2020-03-18 17:50:03 +00:00
d80699f215 Reland "Make java_deobfuscate not require being built first"
This reverts commit 0b8c0e6a09.

Reason for revert: Fixed runtime deps

Original change's description:
> Revert "Make java_deobfuscate not require being built first"
>
> This reverts commit 962e70305e.
>
> Reason for revert: Failing on swarming
> https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747
>
> Original change's description:
> > Make java_deobfuscate not require being built first
> >
> > Makes the tool easier to use, and easier to document how to use by not
> > requiring it to be built first. We have only a single non-prebuilt .java
> > file, so it's easy enough to just check in the .class file for it.

Bug: 995290
Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751322}
2020-03-18 14:14:30 +00:00
0b8c0e6a09 Revert "Make java_deobfuscate not require being built first"
This reverts commit 962e70305e.

Reason for revert: Failing on swarming
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747

Original change's description:
> Make java_deobfuscate not require being built first
> 
> Makes the tool easier to use, and easier to document how to use by not
> requiring it to be built first. We have only a single non-prebuilt .java
> file, so it's easy enough to just check in the .class file for it.
> 
> Bug: 995290
> Change-Id: I7b934b3337eccb044a470dd92270ce7338b1fd20
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106257
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750855}

TBR=agrieve@chromium.org,smaier@chromium.org

Change-Id: Ic279958503760f08a5a4885391705a89db8f982f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 995290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107680
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751026}
2020-03-17 17:46:07 +00:00
962e70305e Make java_deobfuscate not require being built first
Makes the tool easier to use, and easier to document how to use by not
requiring it to be built first. We have only a single non-prebuilt .java
file, so it's easy enough to just check in the .class file for it.

Bug: 995290
Change-Id: I7b934b3337eccb044a470dd92270ce7338b1fd20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106257
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750855}
2020-03-17 04:04:03 +00:00
93b8eb80e9 doc: replace isolateserver.py with isolate
python client is being deprecated.

Bug: 984869
Change-Id: I94a7445b903d8806fe520788998e1e0e4b96326c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029566
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736814}
2020-01-30 12:11:28 +00:00
e0021d3971 Update Android debugging docs to suggest adb logcat.
I wasn't able to see my LOG(INFO) output when running the test
binary with `logcat -v` added, but a colleague suggested `adb logcat`,
which worked. This CL updates the Android debugging docs to suggest
`adb logcat` for viewing printed log lines.

Change-Id: Iec2152b9fb5ca265239e7515482ff7be823eddca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023390
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736386}
2020-01-29 16:02:58 +00:00
e2b55cc552 Documentation: remove ASAN setup prior to running gdb on android
R=agrieve@chromium.org

Change-Id: I958743633dfca88c9f7b20aa1af2bd34719970bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841577
Auto-Submit: Stefan Zager <szager@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703005}
2019-10-04 19:57:54 +00:00
abcac41a5a android_debugging_instructions.md: Add link to go/chromejavadeobfuscation
Change-Id: I1f1b5755b350b22e77a1c51791d8b3e35923f027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753874
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686867}
2019-08-14 17:16:18 +00:00
3269af137e docs: Add instructions for deobfuscating buildbot stack traces
Bug: 978032
Change-Id: I7609a9e5191a04d13f97930b1630904664d1bccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685592
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674151}
2019-07-02 19:02:45 +00:00
f57cceafd4 Change Android SDK path to third_party/android_sdk/public
third_party/android_tools/sdk will be gradually deprecated and replaced with third_party/android_sdk/public

Bug: 659808
Change-Id: I7e006f12723cf9a4dbce3c9d87b728e4e662b6c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518245
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641769}
2019-03-18 21:31:23 +00:00
e453b98fd3 android_debugging_instructions.md: Add vscode native code debugging
And also freshen up the doc in general.

Change-Id: Icb783a45d2f418db9147042f6af1977af6eeba29
Reviewed-on: https://chromium-review.googlesource.com/c/1288954
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601562}
2018-10-22 14:17:17 +00:00
0f8750b3d1 docs: Debugging Robolectric tests in Android Studio
NOTRY=true  # docs update

Bug: None
Change-Id: I1c3c71e1d1813b71de780e2e50accdedd1acadfe
Reviewed-on: https://chromium-review.googlesource.com/804137
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522882}
2017-12-08 21:42:15 +00:00
4fe99743ac Android: Tweaks for --wait-for-java-debugger
* Add the flag to junit tests
* Better log statements
* Updated docs

Change-Id: If967015a697ef6a840f26f2311768230b874ab46
Reviewed-on: https://chromium-review.googlesource.com/786970
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519007}
2017-11-23 19:43:16 +00:00
6a686c5c5d android_debugging_instructions.md: Link to android_studio.md
NOTRY=true  # docs update

Change-Id: I4f5840875d6d5256ef14b12de5364643a751f1e4
Reviewed-on: https://chromium-review.googlesource.com/700420
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506406}
2017-10-04 16:25:22 +00:00
f8b7d9b8f8 Android: Remove --wait-for-java-debugger Chrome flag
It's superseded by the --wait-for-java-debugger wrapper script flag.

The wrapper scripts use "am set-debug-app -w", which cause the
debugger to attach before any application code has been loaded
and is much more useful since it allows breakpoints during
start-up.

TBR=sanfin

Change-Id: Ib4a8f64a33e089c571d0c441415afabe6a8031dc
Reviewed-on: https://chromium-review.googlesource.com/697905
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506281}
2017-10-04 02:43:47 +00:00
0904ce1533 Reland "Android: Add --wait-for-java-debugger to test_runner.py"
This reverts commit f7b7b5ab8c.

Reason for revert: Will update when ready.

Change-Id: I5478e9a738b64a6a34a9937e080b59583f7c3f16
Reviewed-on: https://chromium-review.googlesource.com/698544
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506174}
2017-10-03 21:09:12 +00:00
f7b7b5ab8c Revert "Android: Add --wait-for-java-debugger to test_runner.py"
This reverts commit d77bb0d559.

Reason for revert: Fails on Android Cronet Perf bot(s).

I    0.000s Main  command: ... Android_Cronet_x86_Builder ... test_runner.py perf ...
E    0.001s Main  Unrecognized error occurred.
Traceback (most recent call last):
  File ".../src/build/android/test_runner.py", line 1001, in main
    return RunTestsCommand(args)
  ...
  File ".../src/build/android/pylib/local/device/local_device_environment.py", line 148, in __init__
    self._wait_for_java_debugger = args.wait_for_java_debugger
AttributeError: 'Namespace' object has no attribute 'wait_for_java_debugger'
  ...
Original change's description:
> Android: Add --wait-for-java-debugger to test_runner.py
  ...
> 
> Change-Id: I7cd58c747534b3b539afcc84fcbae48475c4d9c3
> Reviewed-on: https://chromium-review.googlesource.com/693218
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Yoland Yan <yolandyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506049}

TBR=agrieve@chromium.org,yolandyan@chromium.org

Change-Id: I7cf9a5e3c52f29b24df77e0e27eb6272416c5f30
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/698127
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506097}
2017-10-03 17:58:29 +00:00
d77bb0d559 Android: Add --wait-for-java-debugger to test_runner.py
I used this to debug test listing in the instrumentation test runner.
This is nicer that using set-debug-app separately, because it disables
all timeouts (or else the process gets killed as you're debugging).

Change-Id: I7cd58c747534b3b539afcc84fcbae48475c4d9c3
Reviewed-on: https://chromium-review.googlesource.com/693218
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506049}
2017-10-03 15:44:40 +00:00
c81af4a673 Android: Update docs to use generated apk wrapper scripts
BUG=674250

Change-Id: I336a67f3d528c52ec1d92dd18efd33f4efca84a7
Reviewed-on: https://chromium-review.googlesource.com/586471
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489692}
2017-07-26 18:02:13 +00:00
a350dbdbfe android: Convert java_deobfuscate.py to Java
This allows it to not buffer output lines, which is essential when
piping logcat through it.

BUG=713710

Review-Url: https://codereview.chromium.org/2956153003
Cr-Commit-Position: refs/heads/master@{#484281}
2017-07-05 15:27:17 +00:00
6a94be3b51 [Android] Remove --test-arguments arg from test_runner.py.
Deprecated in favor of passing such arguments to test_runner.py
directly.

BUG=700366

Review-Url: https://codereview.chromium.org/2855483003
Cr-Commit-Position: refs/heads/master@{#471096}
2017-05-11 22:38:43 +00:00
8c9318ff00 Add basic debugging instructions for Android Studio.
The docs still need to be updated with more detailed instructions and
tips, but currently the docs don't even mention debugging in Android
Studio.

BUG=620034

Review-Url: https://codereview.chromium.org/2740353003
Cr-Commit-Position: refs/heads/master@{#456185}
2017-03-10 22:16:35 +00:00
c75738d047 Port Android debugging instructions to Markdown
This CL ports the debugging instructions from the Chromium wiki
to Markdown format. The previous location for the documentation
was:
https://www.chromium.org/developers/how-tos/debugging-on-android

BUG=None

Review-Url: https://codereview.chromium.org/2203123006
Cr-Commit-Position: refs/heads/master@{#418332}
2016-09-13 19:28:12 +00:00