Merges various parts of the GPU Gold documentation from
gpu_pixel_testing_with_gold.md into the other parts of the GPU
documentation. Also removes references to the legacy pixel tests and
their triage process since the code for them has been removed.
Bug: 985007
Change-Id: I19d5480de77f1066046ef8fe0f076264cff01ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721523
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681868}
Removes all the code that was only used by the legacy (cloud
storage-based) GPU pixel tests since Gold is now used everywhere.
Additionally, moves much of the remaining code out of
cloud_storage_integration_test_base and into specific subclasses since
it was only actually being used by one subclass.
This is pretty much cut/paste work - refactoring work to make the code
more readable will come in a follow-up CL.
Bug: 985007
Change-Id: Ifd42142629f641e737675b5b4c0b1091b98b9757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715626
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680655}
Adds a --local-run flag to the GPU pixel tests. This causes goldctl to
run in --dryrun mode (i.e. no uploads) and makes the test runner output
file:// URLs to the produced images. This makes it much more suitable
for local runs, since Gold's normal usage mode is designed to be used on
the bots.
Bug: 985418
Change-Id: I70021679e725d619c9dfc38598655c881b2dcb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713588
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679778}
Adds a small section to the GPU Skia Gold Markdown documentation
explaining how to find a failed swarming task for a bad image in the
rare case that a bad image is found without a link to the failed build.
Bug: 965234
Change-Id: I257c95ed686f8b6902bd0739b9a1bb93054906f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700293
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677127}
Updates some portions of the GPU Skia Gold markdown documentation, such
as the new triage process using the links reported in Milo.
Bug: 965234
Change-Id: If22ee0f6e7af1054df98630f2f9ebb616a8fdbf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668092
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675816}
Adds Markdown documentation on the GPU team's Skia Gold-enabled pixel
tests, such as how to triage images, how they work, and how to modify
Gold if necessary.
Bug: 965234
Change-Id: Ie77c9679e458d7196af1457edbf2b06f45799f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638739
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668976}
The section on pixel tests lists an output link format. However for the
pixel_skia_gold_tests the link format is different.
This updates the docs to include a note about the differences in links, with an
example.
Change-Id: I444c5391a3c05561b4177a76a7d3db70d4f03361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638548
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665247}
The documentation for creating a new VM for the GPU bots says to run
gen.star. That file no longer exists. It is now main.star.
This CL updates the documentation to reflect this change.
TBR=kbr@chromium.org
Bug: 963242
Change-Id: Ie8cb26cf92bb59c38af12dca01934a536c299314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612346
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659772}
Change links pointing to old expectation's files and folders to links pointing
to new expectation's files and folders.
Bug: chromium:698902
No-Try: True
Change-Id: Icbf5220c12b303c838a3ae2a60de95b2b63a4015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606966
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659271}
This is a reland of fab66bae04
Includes necessary change to luci-scheduler.cfg and updated docs.
Original change's description:
> Add new ANGLE Linux and Mac tester configs.
>
> These configs will replace linux_angle_rel_ng and mac_angle_rel_ng.
> They initially mirror the configuration but will soon be updated to
> run only the subsets of tests that are most relevant to ANGLE. This
> should reduce flakiness in ANGLE and reduce load for Chrome.
>
> Also updates related configuration files to include linux-angle-rel
> and mac-angle-rel.
>
> Bug: 822310
> Change-Id: I2b40ed45f5d9e105c088ab166bd2207c96280151
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551463
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647854}
Bug: 822310
Tbr: jbudorick@chromium.org
Change-Id: Iaeeffc7b089b05d379bb353d627d13b39fd43704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554296
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648727}
All 4 GPU command decoders (GLES2, Passthrough, Raster, WebGPU) needs
the SyncToken facilities. We move it to the CommonDecoder so they all
share their implementation. This requires adding a DecoderClient
argument to the CommonDecoder so that OnFenceSyncRelease can be called.
BUG=chromium:948613
Change-Id: I286f37be0068e7347782b07003b1663f9387c1ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549054
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647507}
In order to effect seamless driver upgrades across the Swarming fleet,
make the following configurations:
Win10 Quadro P400
Linux Quadro P400
Win10 Intel HD 630
Linux Intel HD 630
refer to "stable" versions of their graphics drivers, defined in
Swarming's bot_config.py. In this way, the definitions of these stable
versions can be changed on the fly.
Bug: 920665, 925587
Change-Id: I28f0393a5d11223be32ba25b93148667c117bc98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517105
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641390}
These bots were renamed already in the CQ, but docs weren't updated.
This CL updates everything I could find in chromium/src.
TBR=mef, kbr, odejesush, miu, tkent
Bug: 888810
Change-Id: I4c1d5ecb829c192a6f0f91160e2b4f8162f114a6
Reviewed-on: https://chromium-review.googlesource.com/c/1464135
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631055}
In fact it is not necessary to set this env var but it is worth
mentioning to show that VA-API also works when the gpu process
is running in sandbox mode.
Bug: 917091
Change-Id: I0d7b43dcff4d7887e945b5d54d8d13d5244d1544
Reviewed-on: https://chromium-review.googlesource.com/c/1433032
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625717}
1. Add enable_gpu_service_logging GN argument. This can be used in
Release builds without dcheck_always_on=true, and allows the
--enable-gpu-service-logging command line argument to work.
2. Add about flag 'Enable gpu service logging' to let non-rooted
devices enable the --enable-gpu-service-logging flag.
Bug: 839769
Change-Id: Ic6fe4d97aaa6deb51b1f4d30ac4e7aeeaf8b4700
Reviewed-on: https://chromium-review.googlesource.com/c/1401616
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622252}
This CL adds a vaapi.md entry to docs/gpu, explaining how to trace its
cpu/memory/power consumption, and to verify/debug its installation.
Bug: 912295, 514914
Change-Id: Ieb7ad033e20f1211a9ae170af9378296a58c0689
Reviewed-on: https://chromium-review.googlesource.com/c/1383147
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618265}
This can be used in Release builds without dcheck_always_on=true, and
allows the --enable-gpu-client-logging command line argument to work.
Bug: 910783
Change-Id: I0720b7eb0c735de4d08ba50d69b41060eb387d63
Reviewed-on: https://chromium-review.googlesource.com/c/1357623
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612900}
The bots have been upgraded to 10.13.6 and the graphs had to be
updated as well.
Bug: 885337
Tbr: zmo@chromium.org
No-Try: True
Change-Id: I676817f3595fee7667c521437bdb907299c08bab
Reviewed-on: https://chromium-review.googlesource.com/1239413
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593332}
The original sample is outdated so replace with a newer one.
BUG=838970
Change-Id: Id257239e3fdb6424bd7bb9b3bdaea563dd1743dc
Reviewed-on: https://chromium-review.googlesource.com/1228783
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592106}
This reverts commit f17419f416.
Reason for revert: Microsoft responded to twitter reports and fixed
their detection so this isn't needed anymore. I'm retaining the typo
fix though!
Original change's description:
> Modify markdown to satisfy Windows Defender
>
> debugging_gpu_related_code.md explains how to use a Chrome command-line
> switch which has been used for arbitrary code execution. Windows
> Defender therefore treats it as malware. This means that some Windows
> Chromium developers will get anti-virus warnings (with mandatory
> quarantining of the file). If Chrome is in a directory that is
> excluded from scanning then they will avoid warnings but will hit
> problems if they try to use Windows backup.
>
> This is all very silly since there is no way - short of manually
> following the steps, modify to be malicious - to activate this payload.
> Windows Defender even complains about the file created by this:
>
> > echo --no-sandbox --gpu-launcher="x" >foo.txt
>
> But, sometimes it's not worth arguing.
>
> This also fixes a typo.
>
> R=kainino@chromium.org
> BUG=851562
>
> Change-Id: I85403a1cb1667f45784684179927119058608d40
> Reviewed-on: https://chromium-review.googlesource.com/1096311
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566245}
TBR=brucedawson@chromium.org,kainino@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 851562
Change-Id: I60b09d8e6a698c1646f5c4bb0ecab16f999bfb9c
Reviewed-on: https://chromium-review.googlesource.com/1100255
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567294}
debugging_gpu_related_code.md explains how to use a Chrome command-line
switch which has been used for arbitrary code execution. Windows
Defender therefore treats it as malware. This means that some Windows
Chromium developers will get anti-virus warnings (with mandatory
quarantining of the file). If Chrome is in a directory that is
excluded from scanning then they will avoid warnings but will hit
problems if they try to use Windows backup.
This is all very silly since there is no way - short of manually
following the steps, modify to be malicious - to activate this payload.
Windows Defender even complains about the file created by this:
> echo --no-sandbox --gpu-launcher="x" >foo.txt
But, sometimes it's not worth arguing.
This also fixes a typo.
R=kainino@chromium.org
BUG=851562
Change-Id: I85403a1cb1667f45784684179927119058608d40
Reviewed-on: https://chromium-review.googlesource.com/1096311
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566245}
Redefine the chromium.gpu, chromium.gpu.fyi and client.v8.fyi
waterfalls and test suites in waterfalls.pyl and test_suites.pyl,
respectively.
The goal of this conversion was to generate these three waterfalls'
JSON files almost exactly as they currently are, which has been
achieved. There are however many cleanups that should be done to
simplify the test suites and the configurations of the GPU bots, which
will be done in follow-on CLs and bugs.
Added a few needed features to the testing/buildbot version of the
generator script. Covered these in the unit tests; the coverage test
continues to pass. Deleted the old GPU script and updated docs that
referred to it.
Tbr: dpranke@chromium.org
Tbr: jbudorick@chromium.org
Tbr: ynovikov@chromium.org
Tbr: geofflang@chromium.org
Tbr: jmadill@chromium.org
Bug: 844815
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4e472d0e55a700fe3cec5043dcd260d31de8fd41
Reviewed-on: https://chromium-review.googlesource.com/1067132
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563939}
