This reverts commit f17419f416.
Reason for revert: Microsoft responded to twitter reports and fixed
their detection so this isn't needed anymore. I'm retaining the typo
fix though!
Original change's description:
> Modify markdown to satisfy Windows Defender
>
> debugging_gpu_related_code.md explains how to use a Chrome command-line
> switch which has been used for arbitrary code execution. Windows
> Defender therefore treats it as malware. This means that some Windows
> Chromium developers will get anti-virus warnings (with mandatory
> quarantining of the file). If Chrome is in a directory that is
> excluded from scanning then they will avoid warnings but will hit
> problems if they try to use Windows backup.
>
> This is all very silly since there is no way - short of manually
> following the steps, modify to be malicious - to activate this payload.
> Windows Defender even complains about the file created by this:
>
> > echo --no-sandbox --gpu-launcher="x" >foo.txt
>
> But, sometimes it's not worth arguing.
>
> This also fixes a typo.
>
> R=kainino@chromium.org
> BUG=851562
>
> Change-Id: I85403a1cb1667f45784684179927119058608d40
> Reviewed-on: https://chromium-review.googlesource.com/1096311
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566245}
TBR=brucedawson@chromium.org,kainino@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 851562
Change-Id: I60b09d8e6a698c1646f5c4bb0ecab16f999bfb9c
Reviewed-on: https://chromium-review.googlesource.com/1100255
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567294}
debugging_gpu_related_code.md explains how to use a Chrome command-line
switch which has been used for arbitrary code execution. Windows
Defender therefore treats it as malware. This means that some Windows
Chromium developers will get anti-virus warnings (with mandatory
quarantining of the file). If Chrome is in a directory that is
excluded from scanning then they will avoid warnings but will hit
problems if they try to use Windows backup.
This is all very silly since there is no way - short of manually
following the steps, modify to be malicious - to activate this payload.
Windows Defender even complains about the file created by this:
> echo --no-sandbox --gpu-launcher="x" >foo.txt
But, sometimes it's not worth arguing.
This also fixes a typo.
R=kainino@chromium.org
BUG=851562
Change-Id: I85403a1cb1667f45784684179927119058608d40
Reviewed-on: https://chromium-review.googlesource.com/1096311
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566245}
Redefine the chromium.gpu, chromium.gpu.fyi and client.v8.fyi
waterfalls and test suites in waterfalls.pyl and test_suites.pyl,
respectively.
The goal of this conversion was to generate these three waterfalls'
JSON files almost exactly as they currently are, which has been
achieved. There are however many cleanups that should be done to
simplify the test suites and the configurations of the GPU bots, which
will be done in follow-on CLs and bugs.
Added a few needed features to the testing/buildbot version of the
generator script. Covered these in the unit tests; the coverage test
continues to pass. Deleted the old GPU script and updated docs that
referred to it.
Tbr: dpranke@chromium.org
Tbr: jbudorick@chromium.org
Tbr: ynovikov@chromium.org
Tbr: geofflang@chromium.org
Tbr: jmadill@chromium.org
Bug: 844815
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4e472d0e55a700fe3cec5043dcd260d31de8fd41
Reviewed-on: https://chromium-review.googlesource.com/1067132
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563939}
This was a difficult bug to track down and is worth mentioning as a
reason to prioritize stamping out flakiness on the waterfall.
Bug: 840988
Change-Id: If2c56a80b02178ddc28efd44d73ec440a2aa2e0c
Tbr: rjkroege@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1054585
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557758}
Worked with zmo@ to develop this documentation along with the example
CLs.
Also added top-level links to the GPU docs and cleaned up some other
now-incorrect documentation. More cleanups are still needed.
Bug: 838970
Tbr: zmo@chromium.org
Change-Id: I40e07adf864974a645490627f5a055ce686237a3
Reviewed-on: https://chromium-review.googlesource.com/1041273
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555661}
Also fixup some documentation links for GPU optional bots.
Also change a PRESUBMIT.py's master name for win_angle_rel_ng.
TBR=kbr@chromium.orgTBR=sky@chromium.org
BUG=chromium:815092
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ifda505e121f67f922f19da466a37b7f6266cea05
Reviewed-on: https://chromium-review.googlesource.com/1008182
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550188}
