Enable JavaScript in the Pepper-free viewer. Use a separate isolate than
Blink's for PDFium. This is fine, even on the same thread, because
PDFium only makes scoped entries to its V8 isolate, so there's no danger
of jumping back into Blink with PDFium's isolate being the current one.
The Unseasoned Viewer does not respect content settings yet.
Bug: 1111024
Change-Id: I8f92997d6d6fcb8f9b42c621da9230b26a63b998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003541
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900586}
blink::WebString's allocators can only be used if Blink is initialized.
Instead of initializing Blink, just avoid using blink::WebString in the
few places they're used in the Pepper process, at least for as long as
the Pepper process exists.
Change-Id: I73130fb840179a2c02e6ed6e1aeffae2e4f2f704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018059
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900584}
Speculative fix for crash at crbug.com/1219797, but is a clearly
correct null check regardless.
Test: Manually verified that switching between users at signin
screen correctly swaps between Smart Lock "sessions".
Bug: 1219797
Change-Id: I2b5768619716126bf2950f9902ad7f8c684cd244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977291
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#900582}
This CL makes a couple changes to how file type policies are controlled
to support building Chrome for Fuchsia.
1. We disable the File Type Policies component updater, since we can't
get a Fuchsia-specific version of the component.
2. We ship a minimal file type policy with all file types marked as
safe.
This effectively disables download protection without disabling other
Safe Browsing functionality. If Fuchsia is ever in need of download
protection, we can fairly easily modify this approach to ship a
different file type policy in the future.
Bug: 1056278
Change-Id: I835fcb70ea1bed63193be830f53ed57a9ea2d3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3012281
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900579}
Make the Blink implementation consistent with the spec, requiring
maxBufferSize to be specified for profiler instantiation.
Bug: 956688
Change-Id: Icbb85a4679b91bf47e6a173c9f048bb004c66cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3019395
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900576}
Before this patch, the entire test file is marked Fail even though each
file has ~15-20 tests in it, some of which Blink passes. If we were to
regress any of the tests we pass, we'd never know.
Firefox passes all these tests so I wrote a script that harvests
Firefox's offsetTop/Left values and stuffs them into data-offset-x/y.
Most recent similar patch is at
https://chromium-review.googlesource.com/c/chromium/src/+/2965267
Change-Id: I0bfcb3a5c08c3abac6238d79917065facc39aa63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3016361
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900574}
Adds a class to generate and write out a synthetic response containing
an application/x-google-chrome-pdf plugin. Implementation loosely
modeled on `content::DataURLLoaderFactory::CreateLoaderAndStart()`.
A future change will hook this into PdfURLLoaderRequestInterceptor, in
order to replace the response to the navigation request created by
PdfNavigationThrottle.
Bug: 1123621
Change-Id: Ibe410b5635749d598c5aa041dc15186968d2db28
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3016362
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900572}
Pipes the signal that the user has opened the password manager settings
page from the PasswordSectionElement, through the HatsHandler, to the
SentimentService. The service is then able to watch the provided
WebContents to ensure the user remains on settings for the required
period of time, before considering them eligible for a survey.
Bug: 1221076
Change-Id: I43d388e7fcc01ffec4d7f92da8cef927d8a36a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3013836
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#900571}
- When a top visit is removed, whether alone or along with the rest of
the visits in the cluster, the cluster should either be entirely
removed or restructured. This CL adds logic to refresh the list of
clusters in that scenario so those changes are reflected in the UI.
- Also fixes a bug when deleting related visits was not being reflected
in the UI.
screenshot/8bR4yCRaAU5PncX
Bug: 1173908
Change-Id: Ia4e08585ab158b12ae5bcd2bf73536bda7ba65a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998321
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900567}
A future update is planned for base timers that will change how
cancelled tasks are handled on the task queues. This mean that tests can
no longer depend on the number of tasks posted by a cancelled timer.
Bug: 1189304
Change-Id: Ie66ec1f22f7d4e5bc42b4213ec580b89d2966547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994828
Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900565}
We will experiment with both IPH and bubble accelerators,
let's see which works best by using a finch experiment.
Following Lure - add an IPH lure alternative
We want to run an experiment to see if IPH works better than the
bubble follow accelerator. This will provide the IPH variant.
The pulsing of the menu and menu button will come in a different
changelist.
Bug: b/191999620
Change-Id: If5fcfdd4e60bad854a69f0353c6e9d30bbeb8d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998309
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900564}
There are a number of issues related to using SwANGLE with
headless Ozone, and I need more time to debug them. This CL
turns off SwANGLE for headless Ozone for now, until all
headless related issues are fixed.
Bug: chromium:1228219
Bug: chromium:1227864
Change-Id: I127ef0d5f05b48edcbea01eb7df76c48019e041c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021045
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900559}
Initial skeleton for embedding. Host the "plate" (input views) and
"stage" (output views) in AppListBubbleAssistantPage. Hide the main
SearchBoxView when assistant is visible.
See go/bubble-launcher-assistant for brief design sketch. Screenshots:
https://screenshot.googleplex.com/6ooeYqFhFxzbHXvhttps://screenshot.googleplex.com/A7FWeFaJz4fxoST
Known issues:
- Background is white
- Clipping issues with rounded corners at bottom of bubble when the
assistant output is very tall, filed crbug.com/1226153
Bug: 1225794
Test: added to ash_unittests
Change-Id: I06bdb9bd2625b8d494161b684bcc859eb43192a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003135
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900556}
A change in Android S requires the PackageManager.MATCH_DEFAULT_ONLY
flag to be used when searching for apps that can handle a browsable
URL. Technically the old behavior was a bug, but still worked.
Change-Id: I6c7c8bd8236f48a18707b30879246a6f6c005d85
Bug: 1226468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021087
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900555}
Specifically converting MainPageBehavior, RouteObserverBehavior and
PasswordCheckBehavior.
Unfortunately files that inherit the GlobalScrollTargetBehavior can't
be switched to use RouteObserverMixin yet, since that behavior already
inherits from RouteObserverBehavior.
Bug: 1206112
Change-Id: I8b39505b57c07dcd5d0bc758e0e9ce84c988f395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3014175
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900550}
The main issue was that the wrong texture target was being used. The
logic in CanvasResourceProvider::CreateSharedImageProvider was not
correctly predicting that the canvas resource was a valid overlay
candidate, and thus should use GL_TEXTURE_RECTANGLE_ARB as its texture
target in order to work with IOSurface. The old logic was turning off
the SCANOUT bit due to lack of support for the
CHROMIUM_texture_storage_image extension, but it seems that
GPUMemoryBuffer supports scanout without that extension in the case
where rendering is done on the CPU.
The changes in canvas_resource.cc fix DCHECKS that were causing the
test to crash.
The changes in canvas_resource_provider.cc fix the bad texture
target issue.
Test coverage is provided by
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
Bug: 1215261
Change-Id: I5335f80125421c5590416fda20b89b749715a271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3016512
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900549}
performance.mark() can be called from both the main thread as well as
from any worker thread, so using a non-thread-safe constant is incorrect
and is currently causing a lot of tests to hit a race DCHECK.
Bug: 1227803
Change-Id: If264d4b8af20d3d3565daff37f62ab3b72462cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021005
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900547}
When the hostname of the capturing/captured tab is unknown there
is a fallback string. This CL fixes an inverted bool and uploads
the new, corrected screenshots' hashes.
Bug: 1224363
Change-Id: I20181b97b5224a3ba3b46f8322149f2b2410c776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021143
Auto-Submit: Elad Alon <eladalon@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900546}
When tab-fullscreen is active, both mouse-lock and unlock show the same
exit instruction on the top bubble ("Press Esc to exit fullscreen").
For use-cases where lock/unlock is called repeatedly, the exit bubble is
updated repeatedly without any change in exit instruction test, which
can keep the bubble visible for arbitrarily long time.
This CL skips bubble updates for unchanged exit instruction. So the
exit bubble can now hide after a while even with repeated mouse-lock
changes under active tab-fullscreen.
This deliberately skips browser-fullscreen because it has a different
exit key (F11) than mouse-lock. After a mouse-lock exit through Esc,
the user still needs to be reminded about F11 exit.
Bug: 143780
Change-Id: I5759d28dc39fdd8ae368389d326cf80eca82c7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3016198
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900541}
Use the `modals` API exposed as free function instead of the old
API going through the `ModalsProvider` class.
The class `ModalsProvider` is not removed yet to prevent breaking
the internal repository when this CL lands. It will be removed in
a followup CL once the sub-class has been deleted.
Bug: 1201182
Change-Id: Ica87744a7b57e5de70773c548cfbb0d89930e745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3009585
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900540}
