Danila Kuzmin
cf0bc74b4a
[OOBE][ChildAccount]: Reuse local user type on GAIA done timeout
...
Bug: 1288039
Change-Id: I5e250d02f26f638651379f4ac6db0f7f32e340a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652201
Reviewed-by: Roman Sorokin <rsorokin@chromium.org >
Commit-Queue: Danila Kuzmin <dkuzmin@google.com >
Cr-Commit-Position: refs/heads/main@{#1010510}
2022-06-03 10:40:52 +00:00
Jeffrey Young
62b03f2ce0
personalization: enterprise state for avatar image
...
When device avatar image is policy controlled, disable
user from accessing chrome://personalization/user page to
change device avatar image. Display an enterprise policy icon
over the avatar preview image.
Improve some a11y strings of user avatar image settings in
Personalization hub to notify users when avatar setting is
policy controlled.
BUG=b:224992078,b:230029542
TEST=unit_tests --gtest_filter="*PersonalizationAppUserProvider*"
TEST=browser_tests --gtest_filter="*PersonalizationAppUserPreview*"
Change-Id: I00c7b6dc0d8879ad9f0021459f5f60c3fbb4869a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594346
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Commit-Queue: Jeffrey Young <cowmoo@chromium.org >
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org >
Reviewed-by: Sam McNally <sammc@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1001326}
2022-05-10 03:13:47 +00:00
Irina Fedorova
b3b2e250f6
Add session-type crash keys to Crash Reports
...
If we set a crash key in Ash, but Lacros crashes, the crash key will not
be shown in a crash report. Because of it we need to set session-type
crash key in both Ash and Lacros.
Bug: b/207562010
Change-Id: I6c8cf34407dfc92109807a0fad774252495ec422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529211
Reviewed-by: Polina Bondarenko <pbond@chromium.org >
Reviewed-by: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Roland Bock <rbock@google.com >
Reviewed-by: Robert Sesek <rsesek@chromium.org >
Commit-Queue: Irina Fedorova <irfedorova@google.com >
Cr-Commit-Position: refs/heads/main@{#983454}
2022-03-21 19:46:18 +00:00
Roman Sorokin
b844459269
[known_user] Remove GetPref and introduce FindPath instead
...
Bug: 1150434
Change-Id: Icb9b11ba1c2dfb607ac93b87863e0375e6d26a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3516865
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Aga Wronska <agawronska@chromium.org >
Commit-Queue: Aga Wronska <agawronska@chromium.org >
Cr-Commit-Position: refs/heads/main@{#981338}
2022-03-15 21:51:59 +00:00
Roman Sorokin
80a1b6e415
known_user: Migrate off deprecated functions
...
Migrate off RemovePref, SetBooleanPref, SetStringPref to their KnownUser
versions.
Bug: 1150434
Change-Id: Ia1762b10b049da7c351f8bd8f6f8092b52f22748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3477160
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Reviewed-by: James Cook <jamescook@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#978661}
2022-03-08 10:03:37 +00:00
Roman Sorokin
6778f22dc4
known_user: Migrate off deprecated UpdateId to their KnownUser variant
...
Bug: 1150434
Change-Id: I84fcc49880609b769a28f668b122539cb4be4d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456545
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Commit-Queue: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/main@{#973519}
2022-02-21 15:10:16 +00:00
Roman Sorokin
7308a25c34
known_user: Migrate off deprecated *DeviceId functions
...
to their KnownUser variants
Bug: 1150434
Change-Id: Ib38240910385f1e0590dfb618c77d5932dc2ec82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456823
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: David Roger <droger@chromium.org >
Reviewed-by: Yusuke Sato <yusukes@chromium.org >
Commit-Queue: Yusuke Sato <yusukes@chromium.org >
Cr-Commit-Position: refs/heads/main@{#973028}
2022-02-18 18:49:33 +00:00
Roman Sorokin
f8946d7620
known_user: Migrate off deprecated *GAPSCookie functions
...
to their KnownUser variants.
Also a follow-up to the UpdateIsUsingSAMLPrincipalsAPI CL which was lost
in rebases
Bug: 1150434
Change-Id: I2725085f929d2e8c2ef724fee00836fed5a8da50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456544
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Danila Kuzmin <dkuzmin@google.com >
Commit-Queue: Danila Kuzmin <dkuzmin@google.com >
Cr-Commit-Position: refs/heads/main@{#971257}
2022-02-15 16:37:48 +00:00
Roman Sorokin
7f91141336
known_user: Migrate off deprecated (Set|Get)IsEnterpriseManaged function
...
to the KnownUser variant
Bug: 1150434
Change-Id: I1ab8438fa2a62d9d39cf0aa85973001f3bb9d36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449538
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Commit-Queue: Alexander Alekseev <alemate@chromium.org >
Cr-Commit-Position: refs/heads/main@{#971010}
2022-02-15 03:16:50 +00:00
Roman Sorokin
da7ce09014
known_user: Migrate off deprecated *ProfileRequiresPolicy functions
...
to their KnownUser versions
Bug: 1150434
Change-Id: I9f463ea9d3e48e8072975b814ef24b39809c344b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3452326
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#970725}
2022-02-14 18:38:21 +00:00
Roman Sorokin
b6d7589509
known_user: Migrate off *UsingSaml functions to their KnownUser versions
...
Bug: 1150434
Change-Id: I08e12cf72c175b3d9127021f63d4b65592ec85d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456946
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#970392}
2022-02-13 08:55:12 +00:00
Ahmed Nasr
d0db545651
Fix IsLoggedInAsGuest of FakeUserManager to be evaluated based on user type.
...
Bug: b:218917612
Change-Id: I3414ca1138951e94535c390f3851f6f23af02116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3454283
Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
Commit-Queue: Ahmed Nasr <anasr@google.com >
Cr-Commit-Position: refs/heads/main@{#970039}
2022-02-11 18:37:21 +00:00
Roman Sorokin
e30a4d195c
known_user: Migrate off deprecated SetAccountManager function
...
to the KnownUser variant
Bug: 1150434
Change-Id: Idee28461a39d511b2c41f4954dc5ed002c56c83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447040
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#968868}
2022-02-09 12:58:44 +00:00
Roman Sorokin
5b0eecb4a7
known_user: Migrate off deprecated SetUserLastLoginInputMethodId
...
to the KnownUser variant
Bug: 1150434
Change-Id: I2aed3a1467858b153714836b156a5f86fe53d0c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443543
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Commit-Queue: Alexander Alekseev <alemate@chromium.org >
Cr-Commit-Position: refs/heads/main@{#968173}
2022-02-08 04:18:34 +00:00
Roman Sorokin
c7c0312145
known_user: Remove deprecated functions
...
Migrate SetLastOnlineSignin, GetLastOnlineSignin, SetOfflineSigninLimit,
GetOfflineSigninLimit, SetPasswordSyncToken, GetPasswordSyncToken to
their KnownUser variants.
Bug: 1150434
Change-Id: I7c78dc3f69ead5310174f3aee867b76cbdca176a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3402216
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#966653}
2022-02-03 09:21:29 +00:00
Daniel Cheng
354945de1f
Migrate base::Value::GetList() to base::Value::GetListDeprecated(): 1/N.
...
GetList() will be reimplemented in a future CL with an updated
signature, so existing uses need to be renamed out of the way.
Unlike TakeList() and TakeDict(), GetList() is used quite widely. This
CL migrates a number of uses using the following set of automated steps:
sed -i "s|->GetList()|->GetListDeprecated()|g" \
$(git gs "GetList()" --name-only)
git checkout -- base/values_unittest.cc third_party/dom_distiller_js
git cl format
Bug: 1291666
Change-Id: I1b7a92fcb4874e7afb82d4bd092c1c9de2cc3d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430698
Reviewed-by: danakj chromium <danakj@chromium.org >
Owners-Override: danakj chromium <danakj@chromium.org >
Commit-Queue: Daniel Cheng <dcheng@chromium.org >
Cr-Commit-Position: refs/heads/main@{#966487}
2022-02-02 23:39:17 +00:00
Roman Sorokin
0e6f2c3eac
known_user: Replace GetIntegerPref with FindIntPath
...
To match the base::Value interface.
Also migrated off some deprecated methods.
Bug: 1287074, 1150434
Change-Id: Ic4f0b93b6e07c8917c45f4aa85fa1e8d129719c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3398128
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org >
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#966130}
2022-02-02 11:17:35 +00:00
Pavol Marko
5dfa35578c
known_user: Remove 3 deprecated functions
...
Migrate SaveKnownUser, SetChallengeResponseKeys,
GetChallengeResponseKeys to their KnownUser variants.
Bug: 1150434
Change-Id: Ic09e670c752c7f50477b228073b43e68d664ee66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427510
Reviewed-by: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Maksim Ivanov <emaxx@chromium.org >
Commit-Queue: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/main@{#965738}
2022-02-01 16:57:23 +00:00
Roman Sorokin
0aca5d136a
UserManagerBase: Nuke use of base::ListValue
...
Bug: 1187062, 1288884
Change-Id: I0d7d93cf8bdb9abbf52cf4950ae684eb7d1b44a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3420332
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Renato Silva <rrsilva@google.com >
Commit-Queue: Renato Silva <rrsilva@google.com >
Cr-Commit-Position: refs/heads/main@{#964090}
2022-01-27 16:52:32 +00:00
Roman Sorokin
3fe0161b9f
known_user: Replace GetBooleanPref with FindBoolPath
...
To match the base::Value interface.
Also migrated off some deprecated methods.
Bug: 1287074, 1150434
Change-Id: If57713136a367be6da0cc7ec0d5ac22063344d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3397839
Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org >
Reviewed-by: Mark Schillaci <mschillaci@google.com >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#962917}
2022-01-25 09:58:24 +00:00
Roman Sorokin
7f5c1d9170
known_user: Replace GetStringPref with FindStringPath
...
To match the base::Value interface.
Also migrated off some deprecated methods.
Bug: 1287074, 1150434
Change-Id: I2dfd2f8f2ecc2215c0b28834b372ee4013a9acef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3386463
Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
Reviewed-by: Nektarios Paisios <nektar@chromium.org >
Reviewed-by: Xiaoqian Dai <xdai@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#961837}
2022-01-21 09:09:43 +00:00
Roman Sorokin
e286d7e103
Migrate off deprecated DictionaryValue class in known_user
...
Bug: 1287074, 1150434
Change-Id: I2f68a9035d625a2324d983698a17d12e8eb80dcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3387790
Auto-Submit: Roman Sorokin <rsorokin@chromium.org >
Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
Reviewed-by: James Cook <jamescook@chromium.org >
Commit-Queue: James Cook <jamescook@chromium.org >
Cr-Commit-Position: refs/heads/main@{#960627}
2022-01-18 21:49:41 +00:00
Henrique Ferreiro
93dd33b9c5
Migrate ash/constants/ash_switches.* to namespace ash
...
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE .
Bug: 1157625, 1164001
Change-Id: Ia253571e495128dd9f571af94ced86ec2d1d3354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3394954
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org >
Owners-Override: Hidehiko Abe <hidehiko@chromium.org >
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com >
Cr-Commit-Position: refs/heads/main@{#960408}
2022-01-18 16:06:45 +00:00
Alex Turner
d02ded52fc
Modernize {Dictionary,List}PrefUpdate in /components/user_manager
...
This cl replaces instances of DictionaryPrefUpdateDeprecated, which
wraps the deprecated base::DictionaryValue, with DictionaryPrefUpdate,
which wraps base::Value. This cl also does the equivalent for
ListPrefUpdateDeprecated. A range of other base::Value modernization
changes are made to allow these replacements and as drive-by fixes.
This cl handles the directory /components/user_manager
This CL was uploaded by git cl split.
R=rsorokin@chromium.org
Bug: 1285745
Change-Id: I3d489edaccd9205e874eab886f5f55273c827e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3386126
Auto-Submit: Alex Turner <alexmt@chromium.org >
Reviewed-by: Roman Sorokin <rsorokin@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#959084}
2022-01-14 09:25:15 +00:00
Michael Ershov
c710886df4
[Code Health] Remove DictionaryValue::GetString
...
Replace deprecated DictionaryValue::GetString with a modern
alternative.
Bug: 1187036
Test: KnownUser* unit tests
Change-Id: I3e6d0ee0432c01455371f2d6aefed1673316f51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3378667
Auto-Submit: Michael Ershov <miersh@google.com >
Reviewed-by: Roman Sorokin <rsorokin@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#958034}
2022-01-12 12:41:37 +00:00
Alex Turner
82f2898b69
Begin ScopedUserPrefUpdate migration to modern base::Value
...
base::DictionaryValue and base::ListValue are deprecated. To allow for
incremental migration, a "Deprecated" suffix is added to the current
DictionaryPrefUpdate and ListPrefUpdate and new definitions using
base::Value are added. Future cls will convert uses from the old to new
typedefs.
Bug: 1285745
Change-Id: I05654d4ba4206691527f798dc12da3175aa4de37
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3376154
Reviewed-by: Dominic Battré <battre@chromium.org >
Reviewed-by: Kentaro Hara <haraken@chromium.org >
Owners-Override: Kentaro Hara <haraken@chromium.org >
Commit-Queue: Alex Turner <alexmt@chromium.org >
Cr-Commit-Position: refs/heads/main@{#957434}
2022-01-11 06:08:43 +00:00
Austin Sullivan
76ee98b502
[Code Health] base::Value cleanup after PrefService refactor
...
https://crrev.com/c/3343526 recently landed as a LSC, which
refactored the PrefService GetList() and GetDictionary() methods.
The blast radius of this interface was quite large, so bare minimum
changes were made at call sites.
This CL is part of an effort to clean up these call sites.
The unsplit version of this CL can be found at
https://crrev.com/c/3351044
base::Value refactor guidelines:
http://doc/1CwYuMXnVQsRsghwVzEkWj9GZzfERputSLQaKx5xLhjQ
This CL was uploaded by git cl split.
R=rsorokin@chromium.org
Bug: 1187001, 1187061, 1187062
Change-Id: I41dbad8a6bad521368fe4a46723a98b92b0b73a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3347695
Auto-Submit: Austin Sullivan <asully@chromium.org >
Reviewed-by: Roman Sorokin <rsorokin@chromium.org >
Commit-Queue: Roman Sorokin <rsorokin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#957022}
2022-01-10 12:09:12 +00:00
Austin Sullivan
7d219a2536
[Code Health] Refactor PrefService GetDict + GetList to use base::Value
...
LSC doc: go/prefservice-value-refactor
All type #5 changes are commented.
Bug: 1187001, 1187061, 1187062
Change-Id: Iafefe56f769b7cb4a05ed4afbfb6e9a561b4704a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343526
Reviewed-by: Kentaro Hara <haraken@chromium.org >
Owners-Override: Kentaro Hara <haraken@chromium.org >
Commit-Queue: Austin Sullivan <asully@chromium.org >
Cr-Commit-Position: refs/heads/main@{#952919}
2021-12-20 14:55:31 +00:00
Yeunjoo Choi
517a6be194
Move //{chromeos => ash/components}/login/auth
...
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE .
Change-Id: Ied32c2c1cc9e0303e3906e67a47804390727f78f
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329598
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org >
Owners-Override: Hidehiko Abe <hidehiko@chromium.org >
Commit-Queue: Yeunjoo Choi <ychoi@igalia.com >
Cr-Commit-Position: refs/heads/main@{#952194}
2021-12-16 01:42:30 +00:00
Tsuyoshi Horo
d4ac299b8c
CodeHealth: Replace DictionaryValue::Clear() with DictClear() [2/N]
...
DictionaryValue::Clear() is deprecated. So this CL changes the
call sites to use Value::DictClear().
Bug: 1187021
Change-Id: I06f76ce63dd1f57146e4108225f975a1d8c15f7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320768
Reviewed-by: Colin Blundell <blundell@chromium.org >
Commit-Queue: Tsuyoshi Horo <horo@chromium.org >
Cr-Commit-Position: refs/heads/main@{#949474}
2021-12-08 11:37:45 +00:00
Daniil Lunev
4c68956eab
cryptohome: Remove code supporting GAIA renaming
...
A lot of system components depend on stable userid (e.g. userid is mixed
into various encryption mechanisms), thus renaming the vaults is
infeasible.
BUG=462823
TEST=try bot
Change-Id: I3f0f83933e918515a2c54f9225f3e728a438013e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3278833
Reviewed-by: Maksim Ivanov <emaxx@chromium.org >
Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org >
Commit-Queue: Daniil Lunev <dlunev@chromium.org >
Cr-Commit-Position: refs/heads/main@{#949353}
2021-12-08 03:15:02 +00:00
Maks Orlovich
953f0faebc
Code health: port away from deprecated ListValue::GetString
...
This is a portion for /components/user_manager.
(And in some cases also adjust away from other deprecated Value APIs,
when convenient/nearby)
This CL was uploaded by git cl split.
R=achuith@chromium.org
Bug: 1187090
Change-Id: I0a2adff6174baf4a3cedde0dea92caeb1198afad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307383
Auto-Submit: Maksim Orlovich <morlovich@chromium.org >
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org >
Commit-Queue: Maksim Orlovich <morlovich@chromium.org >
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org >
Cr-Commit-Position: refs/heads/main@{#946051}
2021-11-29 18:58:16 +00:00
Keishi Hattori
0e45c020c4
Rewrite most Foo* field_ pointer fields to raw_ptr<Foo> field_.
...
DO NOT REVERT (unless absolutely necessary)! Report build breaks to keishi@(APAC)/glazunov@(EMEA)/sebmarchand@(NA) as soon as you see them. Fixes are expected to be trivial.
This commit was generated automatically, by running the following script: tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh on commit fe74bc434ehttps://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg/edit?usp=sharing
[2] https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ
Binary-Size: Increase of around 500kb was approved for MiraclePtr
Include-Ci-Only-Tests: true
No-Tree-Checks: true
No-Presubmit: true
Bug: 1272324, 1073933
Change-Id: I05c86a83bbb4b3f4b017f361dd7f4e7437697f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
Commit-Queue: Keishi Hattori <keishi@chromium.org >
Reviewed-by: Bartek Nowierski <bartekn@chromium.org >
Owners-Override: Bartek Nowierski <bartekn@chromium.org >
Cr-Commit-Position: refs/heads/main@{#945735}
2021-11-27 09:25:52 +00:00
Nan Lin
5e28dd263a
[Code Health] Remove usage of DictionaryValue::GetBoolean() under components
...
Bug: 1187033
Change-Id: Ib40209840043f4c657129c49f776af5bda4a0bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261897
Commit-Queue: Nan Lin <linnan@chromium.org >
Reviewed-by: Alan Screen <awscreen@chromium.org >
Reviewed-by: manuk hovanesian <manukh@chromium.org >
Reviewed-by: Marc Treib <treib@chromium.org >
Reviewed-by: Kristi Park <kristipark@chromium.org >
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org >
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Reviewed-by: Kevin McNee <mcnee@chromium.org >
Reviewed-by: Matt Jones <mdjones@chromium.org >
Cr-Commit-Position: refs/heads/main@{#940940}
2021-11-11 22:09:18 +00:00
Peter Boström
b9e2c27ca6
Remove unused "base/macros.h" in components/
...
Removes `#include "base/macros.h"` from files in components/ that do not
contain `ignore_result(`.
Bug: 1010217
Change-Id: Ic1ea0c59d63652bc896e80638a7ff919c872f1c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275012
Commit-Queue: Peter Boström <pbos@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Owners-Override: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#940666}
2021-11-11 05:31:49 +00:00
Gordon Seto
293e49874d
[CrOS Bluetooth] Create BluetoothPowerController.
...
Create BluetoothPowerController to manage setting the Bluetooth adapter
state, saving the state to prefs, and applying the pref on device
startup or user login. The logic in this class is largely taken from
the BluetoothPowerController in ash/system/bluetooth, except
CrosBluetoothConfig APIs are used instead of BluetoothAdapter and
ash-specific SessionManager methods are replaced with UserManager
equivalents. For design doc, see
go/cros-bluetooth-revamp-power-controller.
Bug: 1010321
Change-Id: I17c6e1a03d6368c8caf74e69f78b4e28cae37892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3263257
Commit-Queue: Gordon Seto <gordonseto@google.com >
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org >
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org >
Reviewed-by: Chad Duffin <chadduffin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#940471}
2021-11-10 20:44:52 +00:00
Nan Lin
26e10b33aa
[Code Health] Remove usage of ListValue::GetDictionary() under content
...
and components
Bug: 1187091
Change-Id: I55c151799e4e682b4a67f0e3c64789d802cd79b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259825
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org >
Reviewed-by: manuk hovanesian <manukh@chromium.org >
Reviewed-by: Matt Menke <mmenke@chromium.org >
Reviewed-by: Elad Alon <eladalon@chromium.org >
Reviewed-by: Ben Kelly <wanderview@chromium.org >
Reviewed-by: David Bokan <bokan@chromium.org >
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org >
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org >
Reviewed-by: Josh Simmons <jds@google.com >
Reviewed-by: Kristi Park <kristipark@chromium.org >
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Reviewed-by: Marc Treib <treib@chromium.org >
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com >
Commit-Queue: Nan Lin <linnan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#939907}
2021-11-09 18:25:45 +00:00
Roman Sorokin
fec445db94
[ash-chrome] Cleanup kOfflineSigninLimitDeprecated logic
...
The logic was introduced by http://crrev.com/c/2988030
Fixed: 1224318
Change-Id: I392336220c4e906fcb57760ff48ef08360a1e2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245539
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org >
Commit-Queue: Pavol Marko <pmarko@chromium.org >
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/main@{#937943}
2021-11-03 17:08:19 +00:00
Patrick Monette
643cdf6190
Replace base/task/ temporary forward headers with their final locations
...
Note to QA: This merely changes includes and should not be blamed
for files it touched.
Bug: 1255932
Change-Id: I1ce4e31efd5792ebf2080812e665cae838a54972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226943
Reviewed-by: Gabriel Charette <gab@chromium.org >
Owners-Override: Gabriel Charette <gab@chromium.org >
Cr-Commit-Position: refs/heads/main@{#932153}
2021-10-15 19:13:42 +00:00
Patrick Monette
3d7d70920a
Replace task-related headers to their equivalent in base/task/
...
This CL was generated by using tools/git/move_source_file.py to change
the includes for those files:
base/bind_post_task.h
base/deferred_sequenced_task_runner.h
base/post_task_and_reply_with_result_internal.h
base/sequenced_task_runner.h
base/sequenced_task_runner_helpers.h
base/single_thread_task_runner.h
base/task_runner.h
base/task_runner_util.h
base/updateable_sequenced_task_runner.h
Then formatted using "git cl format". DEPS files were fixed with a
simple search and replace script.
Bug: 1255932
Change-Id: I0d9b5ddd9260fde5e4581e6c6e0080bdb0ed2c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209175
Reviewed-by: Gabriel Charette <gab@chromium.org >
Owners-Override: Gabriel Charette <gab@chromium.org >
Commit-Queue: Gabriel Charette <gab@chromium.org >
Cr-Commit-Position: refs/heads/main@{#929867}
2021-10-08 20:27:23 +00:00
Bao-Duy Tran
27395e3789
Rename several "input method" to "input method ID".
...
... in CrOS Input Method Framework and adjacent zones,
... to better reflect reality; these are ID strings, not
InputMethodDescriptor or similar encapsulated metadata objects.
Bug: 1134465
Change-Id: I645dca1d527978425fdaa1ac7687297a258159ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205344
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org >
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org >
Reviewed-by: Darren Shen <shend@chromium.org >
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org >
Cr-Commit-Position: refs/heads/main@{#929562}
2021-10-08 04:10:22 +00:00
Peter Kasting
e5a38eddbd
Migrate "base::TimeDelta::FromX" to "base:X".
...
All changes were done automatically with git grep, sed, xargs, etc.
No-Presubmit: true
No-Try: true
Bug: 1243777https://chromium-review.googlesource.com/c/chromium/src/+/3198824
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Owners-Override: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Peter Boström <pbos@chromium.org >
Cr-Commit-Position: refs/heads/main@{#927512}
2021-10-02 03:06:35 +00:00
Peter Boström
9f667c3873
Remove DISALLOW_* macros from components/
...
This inlines all remaining DISALLOW_* macros in components/. This is
done manually (vim regex + manually finding insertion position).
IWYU cleanup is left as a separate pass that is easier when these macros
go away.
Bug: 1010217
Change-Id: I2409b6250d85e74e8c4b6863fbeeaaeacc37733c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194821
Commit-Queue: Peter Boström <pbos@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Owners-Override: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#927361}
2021-10-01 20:09:31 +00:00
Peter Boström
09c0182fae
Replace DISALLOW_COPY_AND_ASSIGN in components/
...
This replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes
where a local script is able to detect its insertion place (~Foo() is
public => insert before this line).
This is incomplete as not all classes have a public ~Foo() declared, so
not all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.
IWYU cleanup is left as a separate pass that is easier when these macros
go away.
Bug: 1010217
Change-Id: I917bfbff1357e9e2cfe330d242feff6bb73e1bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3167004
Reviewed-by: Daniel Cheng <dcheng@chromium.org >
Owners-Override: Daniel Cheng <dcheng@chromium.org >
Commit-Queue: Peter Boström <pbos@chromium.org >
Cr-Commit-Position: refs/heads/main@{#923103}
2021-09-20 22:43:27 +00:00
Nancy Wang
2503b3d58b
Delay the full restore init for the primary user when restart.
...
When the system restarts (e.g. reboot from a crash or the flag change),
the system might switch to the non-primary user during the system
startup phase to restore the last active account:
1. Create the primary user profile
2. Create the second user profile
3. Switch to the second user to restore the last active account.
For the step 1, "Create the primary user profile", the full restore
init process might create the notification or restore the browser and
apps. This might cause one of the below results:
A: the notification hidden in the system tray
B: the restored app windows are shown for the second profile after
switching to the second user.
So modify the full restore service to defer the init process of the
primary profile to wait for switching to the last active non-primary
user when the system restarts and the last active account is not the
primary user account.
Also start a timer for the primary user. If the non-primary user hasn't
become an active user, init the full restore process for the primary
user.
BUG=1246227
Change-Id: Ie502a33825a992e9023608ab79eb71364d30051b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140865
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org >
Commit-Queue: Nancy Wang <nancylingwang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#919441}
2021-09-08 20:57:16 +00:00
Tyler Garrett
1645591d76
Cros Reporting: Add RemoveUserReason to RemoveUser
...
This change adds the ablity to pass the reason for a user being removed.
This involves adding a parameter to the remove user function of
user_manager and it's derived classes.
Bug: b:190805740
Change-Id: I297cfed9c89b17f94464f4e428c0687cf3b6cfd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3105167
Commit-Queue: Tyler Garrett <tylergarrett@chromium.org >
Reviewed-by: Leonid Baraz <lbaraz@chromium.org >
Reviewed-by: Alexander Alekseev <alemate@chromium.org >
Reviewed-by: Mitsuru Oshima <oshima@chromium.org >
Cr-Commit-Position: refs/heads/main@{#919284}
2021-09-08 16:13:51 +00:00
Clark DuVall
f475a2eece
[Code Health] Remove ListValue::AppendString in remaining directories
...
This was an automated change done with a slightly modified copy of
//tools/clang/value_cleanup.
Bug: 1187102
Change-Id: Icfce1d18294583791cecccc56bc40a483689fcc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140652
Auto-Submit: Clark DuVall <cduvall@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Commit-Queue: Clark DuVall <cduvall@chromium.org >
Owners-Override: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#917935}
2021-09-03 02:10:15 +00:00
Clark DuVall
23192259d2
[Code Health] Remove ListValue::GetSize in //components
...
This was an automated change done with a slightly modified copy of
//tools/clang/value_cleanup.
Bug: 1187064
Change-Id: Ia4cad3eb393798a00a39577411076f3e614c1bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138835
Auto-Submit: Clark DuVall <cduvall@chromium.org >
Commit-Queue: Colin Blundell <blundell@chromium.org >
Reviewed-by: Colin Blundell <blundell@chromium.org >
Cr-Commit-Position: refs/heads/main@{#917646}
2021-09-02 13:46:33 +00:00
Victor Hugo Vianna Silva
56994180d0
[automated] Drop needless <vector> includes in /components/user_manager
...
This is among the most costful includes for the Chromium build.
https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html
This batch of CLs attempts to detect and remove leftover includes with a
heuristic: choose files which don't contain 'std::vector' or 'push_back'.
This doesn't really guarantee that std::vector is not being used, as
shown by the snippets below, so please review carefully.
```
auto v = GetVector();
MyVectorAlias v = GetVector();
my_vector_ = GetVector();
```
This CL was uploaded by git cl split.
R=antrim@chromium.org
Bug: 1233968
Change-Id: Ieaf85705e10d564eccb8063f64ee22faa904c5ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059447
Auto-Submit: Victor Vianna <victorvianna@google.com >
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org >
Commit-Queue: Victor Vianna <victorvianna@google.com >
Cr-Commit-Position: refs/heads/master@{#907117}
2021-07-30 14:36:47 +00:00
Ossama Mahmoud
aab0a274d2
OOBE: Make onboarding flow resumable
...
Currently, if the user shutdown the device or chrome crashed during
the onboarding flow, the rest of the screens in the onboarding flow
are skipped.
This is fixed by showing the last screen visited by the user before
the shutdown so that the user can continue the remaining onboarding
steps after the next log in.
Bug: 1209785https://chromium-review.googlesource.com/c/chromium/src/+/2897156
Commit-Queue: Ossama Mahmoud <osamafathy@google.com >
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org >
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org >
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org >
Cr-Commit-Position: refs/heads/master@{#905736}
2021-07-27 15:02:35 +00:00
