f7b270fdbb
sql: Have MetaTable expose a "delete the table" method
...
sql::MetaTable works by manipulating a caller-provided database to store
additional version information in a new metadata table. Some clients
using sql::MetaTable might start out with their databases unversioned
and switch to maintaining version metadata at a later time. In this
case, it can help to be able to test the no-metadata-maintained to
metadata-maintained upgrade. However, once a database begins using a
metadata table, it might be difficult to emulate the state of the
database prior to using a metadata table. Clearing out the initialized
metadata table can achieve this effect, but the name of the metadata
table is an implementation detail, so it's not possible to just delete
the table directly from test code. To get around this issue, this CL
adds an sql::MetaTable::DeleteTableForTesting method to do just that.
As one example, the child CL crrev.com/c/2908133 uses this method to
verify its database correctly handles an upgrade from a state with no
version written to disk.
Bug: None
Change-Id: I5d440e11196638a04ad16beb4002ed5d3e25af19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2920848
Commit-Queue: Victor Costan <pwnall@chromium.org >
Reviewed-by: Victor Costan <pwnall@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894658}
2021-06-22 13:27:19 +00:00
0c466221c8
Roll RTS model from -n2D54pE8... to K0eYZEjn0...
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC nodir@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: nodir@google.com
Change-Id: I4c205d8d1a61f3c6f28c28483de8c5c9d2813f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978759
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894657}
2021-06-22 13:23:35 +00:00
a0e238734a
[iOS] FindInPage: Clean up iOS 12 and fix Dark Mode bug
...
The bug occured because the overridesUserInterfaceStyle for this was in
the view that contained FindBarViewController's view, and
overridesUserInterfaceStyle from a view doesn't propagate down to
embedded view controllers. This has probably been around since the
Dark Mode migration.
Bug: 1222388
Change-Id: If733aa2964da965df8f5e2af77b1b6d05ec8d5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976972
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org >
Commit-Queue: Robbie Gibson <rkgibson@google.com >
Cr-Commit-Position: refs/heads/master@{#894656}
2021-06-22 13:20:26 +00:00
9fece697a0
Roll Perfetto Trace Processor Win from e7604c92fd03 to d26e648b7c82
...
e7604c92fd..d26e648b7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I87c2dbf7c5f461cc6068db8fb987b49179bc0af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978534
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894655}
2021-06-22 13:19:49 +00:00
66d773b118
CodeHealth: Remove use of DictionaryValue::Set in /components/policy
...
This change removes the use of DictionaryValue::Set and replaces with
Value::SetKey() or Value::SetPath().
This CL was uploaded by git cl split.
R=pmarko@chromium.org
Bug: 1187023
Change-Id: Icbc49d81ca54cac2b5ac3fff933a27db40a05dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972358
Auto-Submit: Fangzhen Song <songfangzhen@bytedance.com >
Commit-Queue: Pavol Marko <pmarko@chromium.org >
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894654}
2021-06-22 13:18:56 +00:00
ddb73473cf
Correctly support interpolation of integers
...
Previously <Integer> syntax for a custom property was equivalent to
<Number> with the exception of rounding. This creates a problem when
extracting the CSS value of the property with a large integer value.
Numbers (even if integer valued) are converted to exponential
form when generating the CSS text if the number of digits is 7 or
greater. These floating point representations are rejected when we try
and assign them to the property. The fix is to retain that we are
integer valued when generating CSS values.
Bug: 1217506
Change-Id: I45fcfe2007860b45b80aafb57fcf0b5002fb4bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2971254
Reviewed-by: Xida Chen <xidachen@chromium.org >
Commit-Queue: Kevin Ellis <kevers@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894653}
2021-06-22 13:13:00 +00:00
211c38928b
Roll Skia from 79e706ad238f to 0ba3bbf77893 (1 revision)
...
https://skia.googlesource.com/skia.git/+log/79e706ad238f..0ba3bbf77893
2021-06-22 kjlubick@google.com [canvaskit] Add perf tests for different font formats
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: tdenniston@google.com
Change-Id: Ibafe1d495d872fa0ef508c3d700c41e9df053485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978763
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894652}
2021-06-22 13:09:03 +00:00
1139a79f65
Refine expectations in NavigationBrowserTest.Bug1210234
...
The test NavigationBrowserTest.Bug1210234 is flaky on android. This CL
refines a bit the expectations in the test to help understand why that
is the case.
Bug: 1222320
Change-Id: I714808eccbb7a496833d35aa30ed3476d14d1fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978631
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org >
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894651}
2021-06-22 13:04:19 +00:00
fcae548355
Rename policy/scheduled_update_checker
...
Rename policy/scheduled_update_checker to policy/scheduled_task_handler since we will add classes that handle other scheduled tasks to the same path.
Bug: 1211256
Change-Id: I1abf5f254ed60545ccbf8d48a04b3709c11d4b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972631
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894650}
2021-06-22 13:04:09 +00:00
783371860e
mac: Remove things unneeded now that lld is in the default package
...
Bug: 1149587
Change-Id: Ie25a3bc4351a0866fecfdb35af84f8c8bb1b78f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976635
Commit-Queue: Nico Weber <thakis@chromium.org >
Auto-Submit: Nico Weber <thakis@chromium.org >
Reviewed-by: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894649}
2021-06-22 13:01:24 +00:00
888364d7bd
Roll Perfetto from 1ea38eb2db3f to 008f520b2e34 (1 revision)
...
1ea38eb2db..008f520b2e
2021-06-22 hjd@google.com ui: Update channels to current ui-stable and ui-canary
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If2eecb69637f15755190a2a08747474d01e47182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976997
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894648}
2021-06-22 13:00:45 +00:00
f9ba9b6442
Roll DevTools Frontend from 2ea873dac58e to 7b61feee22ee (6 revisions)
...
2ea873dac5..7b61feee22
2021-06-22 szuend@chromium.org [issues] Add details for the remaining Attribution Reporting API issues
2021-06-22 szuend@chromium.org [l10n] Improve descriptions and fix plurals
2021-06-22 jobay@chromium.org Reland "Improve Console display of strings"
2021-06-22 tvanderlippe@chromium.org Explicitly add terser to node_modules/
2021-06-22 tvanderlippe@chromium.org Cleanup TypeScript configuration files and root OWNERS
2021-06-22 pfaffe@google.com Mark asyncScopes as canceled on timeout
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: chromium:1190735,chromium:1208389
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8a67956537c32e7aed8f39031e26d0be6eb0a025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976996
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894647}
2021-06-22 12:56:26 +00:00
b62b499e73
heap: Remove redundant GC_PLUGIN_IGNORE macros.
...
Chrome builds successfully without these ignores.
Change-Id: Ife431dca999f9636b63f0365e03eac478823c23b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976119
Reviewed-by: Kentaro Hara <haraken@chromium.org >
Commit-Queue: Omer Katz <omerkatz@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894646}
2021-06-22 12:49:19 +00:00
9453aeaabb
[Android][Signin] Extract AccountInfoServiceProvider for instance manipulation
...
This CL extracts AccountInfoServiceProvider from AccountInfoServiceImpl
to group all the AccountInfoService instance manipulation methods in
one place and changes the implementation details to package-private.
Bug: 1187512
Change-Id: I2b0661e8c4dc22851756f17525f1885c6ab51a8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2975760
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org >
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894645}
2021-06-22 12:47:16 +00:00
ec14713903
mac/arm: Disable SystemSnapshotMacTest.CPUVendor
...
Should make crashpad_tests pass reliably on mac-arm64-rel-tests
Bug: 1222625,1222619
Change-Id: Iea1886fa069f241d0ca8ac792b66154acc426762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977038
Commit-Queue: Nico Weber <thakis@chromium.org >
Commit-Queue: Hans Wennborg <hans@chromium.org >
Auto-Submit: Nico Weber <thakis@chromium.org >
Reviewed-by: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894644}
2021-06-22 12:45:52 +00:00
0c873f4faa
Files app: Stop auto-generating JS module for common
...
* app_util.js async_util.js
* error_counter.js
* files_app_entry_types.js
* file_type.js
* file_operation_common.js
* filtered_volume_manager.js
* importer_common.js
* test_importer_common.js
* lru_cache.js
* mediasession_types.js
Bug: 1214953
Change-Id: Id4e1b7310d387f2c4b0c03b197de45f46c54c69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976122
Commit-Queue: Luciano Pacheco <lucmult@chromium.org >
Reviewed-by: Jeremie Boulic <jboulic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894643}
2021-06-22 12:41:44 +00:00
da7d5e8bda
Enforce value check for default values in policy pref mapping test
...
So far, prefs that should have a default value were indicated by
|expected_value|==true (default false). However, that alone did not
compare the actual pref's value, but just that it is unmanaged.
I'm trying to enforce all pref mapping tests to actually check the
pref's value in follow-up CLs. As a first step with this CL, I'm
changing the |expect_default| boolean to a |default_value| field.
That way, you don't have to set two fields (|value| and
|expect_default|) any longer and are automatically forced to provide
a value. Only one of |value| or |default_value| should be set for any
given pref.
I'm also planning on writing a more detailed how-to / best-practices
doc or page with more detailed instructions and samples for
policy_test_cases.json.
Bug: 1151251
Change-Id: If9f373e2ac2a9983cf277ef06b36d99af6d6ceb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2923542
Commit-Queue: Alexander Hendrich <hendrich@chromium.org >
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894642}
2021-06-22 12:41:24 +00:00
fdc25f679b
Settings: Convert privacy_page/ to Polymer class syntax, part1.
...
Bug: 1206112
Change-Id: I7c0c4539f8f89c109c36f805e2e88e472ed26cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976933
Commit-Queue: dpapad <dpapad@chromium.org >
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com >
Cr-Commit-Position: refs/heads/master@{#894641}
2021-06-22 12:37:59 +00:00
6ed262ba85
Check support for GLImageBackingFactory only once
...
The GetFactoryByUsage makes checks support for GLImageBackingFactory
twice, once without GMB and once with GMB with interop checks in
between. This needs to be corrected in order to move all factory calls
to an array to make it more cleaner.
Bug: 1215299
Change-Id: Iec321cfcddcca5c9d3bea05fdc3c9744ccc96e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2971973
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org >
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894640}
2021-06-22 12:37:13 +00:00
52ad2f048f
Files app: Stop auto-generating JS module for externs folder
...
* background_window.js
* command_handler_deps.js
* directory_change_event.js
* drive_dialog_controller.js
* entries_changed_event.js
* entry_location.js
* exif_entry.js
* files_app_entry_interfaces.js
* metadata_worker_window.js
* progress_center_panel.js
* volume_manager.js
* volume_info.js
* volume_info_list.js
Bug: 1214953
Change-Id: I06c310608c49cef951e2b20ca0c9d5cdb63f95aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973255
Commit-Queue: Luciano Pacheco <lucmult@chromium.org >
Auto-Submit: Luciano Pacheco <lucmult@chromium.org >
Reviewed-by: Jeremie Boulic <jboulic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894639}
2021-06-22 12:36:54 +00:00
4b383542ea
[DevTools] Rebaseline and reenable tests after https://crrev.com/c/2975279
...
Bug: chromium:1217595
Change-Id: If5e1c243b009c7da26d51d1583cf090e2be0bdd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973113
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894638}
2021-06-22 12:36:03 +00:00
9077189a56
mac/arm: Disable ClipboardUtilMacTest.CompareToWriteToPasteboard
...
Should make ui_base_unittests pass reliably on mac-arm64-rel-tests
Bug: 1222623,1222619
Change-Id: I662143c06be43f65cc8ba7e0139aa038355b3fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978054
Commit-Queue: Nico Weber <thakis@chromium.org >
Commit-Queue: Hans Wennborg <hans@chromium.org >
Auto-Submit: Nico Weber <thakis@chromium.org >
Reviewed-by: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894637}
2021-06-22 12:33:32 +00:00
ab2d6123cd
mac/arm: Stop running blink_web_tests for now
...
We need to green up the bot to move it to the main waterfall, so let's
disable all known failing tests for now and then re-enble them when they work.
Bug: 1098899,1222619
Change-Id: I1a7e9041680448f76dc488841b371e2734b8b571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976786
Commit-Queue: Nico Weber <thakis@chromium.org >
Commit-Queue: Hans Wennborg <hans@chromium.org >
Auto-Submit: Nico Weber <thakis@chromium.org >
Reviewed-by: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894636}
2021-06-22 12:31:39 +00:00
85343ca620
[Android] Rename SigninFragment to SyncConsentFragment in argument key names
...
This CL renames SigninFragment to SyncConsentFragment in argument key
names in SyncConsentFragment and SyncConsentFragmentBase.
Bug: 1169783
Change-Id: I5efc31df5180c156bef686c694f49e0076be9142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972701
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org >
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894635}
2021-06-22 12:29:11 +00:00
bbe277784a
Make CalculateWidthForTextCombine() to accept bidi control
...
This patch changes |CalculateWidthForTextCombine()| to accept bidi
control item in addition to text item, because bidi control items are
valid for combined text.
Bug: 1222069
Change-Id: If8826bfc961c25fa56050f0fbbbcd385712ece3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976284
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org >
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org >
Reviewed-by: Koji Ishii <kojii@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894634}
2021-06-22 12:21:05 +00:00
3ad01ebc86
libstdc++: add copy constructor for PendingMessage
...
libstdc++ requires a copy constructor for creating a reference to
std::queue<PendingMessage> from base::flat_map<Key, Mapped>[].
Bug: 957519
Change-Id: I79dd7e8ea0705543a5e28620eaec9644c1dfba80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973145
Reviewed-by: Rayan Kanso <rayankans@chromium.org >
Commit-Queue: Stephan Hartmann <stha09@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#894633}
2021-06-22 12:21:02 +00:00
36309832eb
T&S Sentiment: Add core trigger action logic
...
Extend the TrustSafetySentimentService with the concept of Triggers,
which will be actions performed by the user that make that user
eligible to receive a survey.
Each trigger requires the appropriate level of eligibility, with
a minimum number of NTP opens, and a time window.
This CL also introduces much of the suite of feature parameters used
to tweak the probability, and circumstances in which, a user receives
a survey.
Bug: 1221076
Change-Id: Ia8b43120879361604a78f0d2041193f0b82fe419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978492
Reviewed-by: Sean Harrison <harrisonsean@chromium.org >
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com >
Cr-Commit-Position: refs/heads/master@{#894632}
2021-06-22 12:15:29 +00:00
bbc0d058db
[Sheriff] Disable flaky test DisplayNotifications.
...
Bug:1222612
Change-Id: Icefc12943fbd94acb26f944cf6ec7df716ccffe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978871
Commit-Queue: Illia Klimov <elklm@google.com >
Owners-Override: Illia Klimov <elklm@google.com >
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894631}
2021-06-22 12:08:52 +00:00
7682c2b20d
[Sheriff] Disable several blink_web_tests.
...
Bug:1222097
Change-Id: I0f501b779cc2b725b2bb6ff614539eb66d8ea701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978494
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org >
Commit-Queue: Illia Klimov <elklm@google.com >
Owners-Override: Illia Klimov <elklm@google.com >
Cr-Commit-Position: refs/heads/master@{#894630}
2021-06-22 12:04:42 +00:00
c091d1acaa
Roll src-internal from 74a4b7dc59ab to 46ea298225fb (1 revision)
...
74a4b7dc59..46ea298225
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC elklm@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1206249
Tbr: elklm@google.com
Change-Id: Ice71d9310d14e7772e1cebbc9afcc0a05a6114e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978533
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894629}
2021-06-22 12:01:54 +00:00
626541105b
[Android] Migrate tryGetGoogleAccounts() usage in AccountTrackerService
...
This CL migrates the usage of the old tryGetGoogleAccounts() to the
new getAccounts() API in AndroidSyncSettings.
Bug: 1211294
Change-Id: I4ee6268647f8fcc4f87b8e4ad16b54bfcc38a878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2963822
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org >
Reviewed-by: Alice Wang <aliceywang@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894628}
2021-06-22 12:01:32 +00:00
8eea1b1993
Roll Perfetto Trace Processor Linux from e7604c92fd03 to d26e648b7c82
...
e7604c92fd..d26e648b7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I488d068b2ea0ddda4b091437d3d92a01a73e398c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978532
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894627}
2021-06-22 11:56:34 +00:00
b8aabcf414
content: Rename SetMainFrameImportance to SetPrimaryMainFrameImportance.
...
Make it explicit that SetImportance calls from the embedder only affect
the primary page's main frame.
Bug: 1220521
Change-Id: Ie36c01251e699da5fb8a8b99273ec3f50d66ea8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2966609
Auto-Submit: Khushal <khushalsagar@chromium.org >
Commit-Queue: Bo <boliu@chromium.org >
Reviewed-by: Bo <boliu@chromium.org >
Reviewed-by: Alexander Timin <altimin@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894626}
2021-06-22 11:55:03 +00:00
e49cd9e595
Update V8 to version 9.3.195.
...
Summary of changes available at:
df86229d..c2025aa9
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
R=hablich@chromium.org ,vahl@chromium.org ,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: Icb7848dcd56df3498e1ee37250fe2dcdb1ef46b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978674
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894625}
2021-06-22 11:53:52 +00:00
8cd7ad92b5
Clean-up policy pref mapping test and improve logging
...
Bug: 1151251
Change-Id: I9af4d38be3b46d8d2c7df35fe7156e597503e03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2923443
Commit-Queue: Alexander Hendrich <hendrich@chromium.org >
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894624}
2021-06-22 11:50:37 +00:00
7070738006
Enforce that all policies have a pref mapping test
...
The previous enforcement just checked that all policies were listed in
policy_test_cases.json once and only logged a warning if they didn't
have a proper test case. This lead to many policies having no test
definition here.
With this CL, the author is forced to give a |reason_for_missing_test|
explicitly if they don't add a test.
Bug: 1151251
Change-Id: I67f28c6deea74d00ae70cdcc106d93b4bcf5e331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919836
Commit-Queue: Alexander Hendrich <hendrich@chromium.org >
Reviewed-by: Pavol Marko <pmarko@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894623}
2021-06-22 11:46:16 +00:00
1689ed212b
Add BluetoothChooserAndroidDelegate and its Chrome implementation.
...
BluetoothChooserAndroidDelegate will handle embedder-specific
dependencies for BluetoothChooserDialog that can not be componentized.
It has a Java and a C++ counterpart.
Bug: 1076462
Change-Id: Ia50c2e95a2bedc2ca863f74ad669ca92a0775a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2975766
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org >
Reviewed-by: Colin Blundell <blundell@chromium.org >
Reviewed-by: Reilly Grant <reillyg@chromium.org >
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894622}
2021-06-22 11:45:25 +00:00
5be675ad8d
Roll DevTools Frontend from 03323f8a2688 to 2ea873dac58e (1 revision)
...
03323f8a26..2ea873dac5
2021-06-22 alexrudenko@chromium.org [Recorder] Recorder and replay click event offsets
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: chromium:1221043
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I385450cc288c5c08e29dade334a4b8253b9522b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977773
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894621}
2021-06-22 11:31:27 +00:00
3e78f1c82c
Roll Perfetto from d26e648b7c82 to 1ea38eb2db3f (1 revision)
...
d26e648b7c..1ea38eb2db
2021-06-22 treehugger-gerrit@google.com Merge "record_android_trace: remove file from device after pull"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I0fc05632b5443d60c562513c612d138eaf6f6d35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978132
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894620}
2021-06-22 11:22:32 +00:00
ebccaf66ab
[AW][ComponentUpdater] Override Service#onStartCommand for testing
...
Override AwComponentUpdateService#onStartCommand to run the native
update service. This way it's possible to deterministically force
launch the service on devices running android M and below for
testing purposes where it's not possible to force launch the job
service via `adb shell cmd jobscheduler`.
The service isn't exported so other apps can't start the service.
The service can be launched using the commandline:
`adb shell am startservice <webview-package-name>/org.chromium.android_webview.nonembedded.AwComponentUpdateService`
Fixed: 1209275
Test: Manually launch the service via adb, run webview shell and see scheduled jobs
Change-Id: I994b46e5b250e4f42498dc20b4b89c11ea452485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2905562
Reviewed-by: Mugdha Lakhani <nator@chromium.org >
Reviewed-by: Richard Coles <torne@chromium.org >
Commit-Queue: Hazem Ashmawy <hazems@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894619}
2021-06-22 11:08:54 +00:00
fdb9894661
[Autofill Assistant] Add url parameter for password change test credentials.
...
Allows urls for password change test credentials to be passed to the tests via the --seed-urls parameter.
Change-Id: I7827fbe4f7f81ad0d02a468175f2bba414a567b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977494
Reviewed-by: Clemens Arbesser <arbesser@google.com >
Reviewed-by: Milica Selakovic <selakovic@google.com >
Commit-Queue: Norge Vizcay <vizcay@google.com >
Cr-Commit-Position: refs/heads/master@{#894618}
2021-06-22 11:08:18 +00:00
f597c9dd59
mac: Add lld (and llvm-ar) to default clang package
...
Things are pretty close, so per
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/updating_clang.md#adding-files-to-the-clang-package
this should be fine now.
Also, the separate package causes some trouble, see 2nd linked bug.
Bug: 1149587,1222471
Change-Id: I5aaf5897a5853aa9b6b5d88f50d9386203cfa706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2977792
Reviewed-by: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894617}
2021-06-22 11:08:14 +00:00
d23a60c7cf
mac: Prevent GetLoginFileList() from mounting volumes from login items
...
If a user has a network volumes listed in login items, calling
LSSharedFileListItemCopyResolvedURL() will cause an attempt to mount
those volumes. This is confusing behavior because it is not relevant to
the user's action (which is likely installing PWA or Chrome extension
with a background page). Also the name "GetLoginFileList" doesn't
indicate there is any such side-effect expected.
Using kLSSharedFileListDoNotMountVolumes flag will prevent this
behavior.
Bug: 1220000
Change-Id: I3995c437891b558312d8994b030cfb3c0633ffc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2964074
Reviewed-by: Mark Mentovai <mark@chromium.org >
Reviewed-by: Victor Costan <pwnall@chromium.org >
Commit-Queue: Mark Mentovai <mark@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894616}
2021-06-22 11:07:02 +00:00
a55e7eb677
[Signin] Remove MOBILE_IDENTITY_CONSISTENCY from android code
...
Bug: 1206613
Change-Id: Iaea058f561cc9ed3e9996a841b376f79fcf2b086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2960930
Reviewed-by: Victor Vianna <victorvianna@google.com >
Reviewed-by: Alice Wang <aliceywang@chromium.org >
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894615}
2021-06-22 11:04:43 +00:00
fe3a5f5d0a
Remove a (mostly) obsolete TODO in sync_engine_impl.cc
...
Bug: 1140938
Change-Id: I1e6d4fbd08703001ea13a9cda2778ac448e8c443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972664
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com >
Commit-Queue: Marc Treib <treib@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894614}
2021-06-22 10:45:10 +00:00
9a860d3985
Skip tests for upcoming DevTools roll
...
This is required to land https://crbug.com/1106746
Bug: 1106746
Change-Id: I8983e04c1535406823a6d42ddaa7eb6ca1e81f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972633
Commit-Queue: Kriti Sapra <kritisapra@google.com >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894613}
2021-06-22 10:43:40 +00:00
4377ccb51e
Files app: Stop auto-generating JS module for externs/background folder
...
* file_browser_background_full.js
* background_base.js
* crostini.js
* drive_sync_handler.js
* duplicate_finder.js
* file_operation_manager.js
* import_history.js
* media_import_handler.js
* media_scanner.js
* progress_center.js
* task_queue.js
Bug: 1214953
Change-Id: Ic837a23585389cd23c3f65b5cdcf12b014b2071c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972154
Auto-Submit: Luciano Pacheco <lucmult@chromium.org >
Commit-Queue: Jeremie Boulic <jboulic@chromium.org >
Reviewed-by: Jeremie Boulic <jboulic@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894612}
2021-06-22 10:37:42 +00:00
d95434d65f
[iOS] Add trusted vault RPC flag
...
Add kSyncTrustedVaultPassphraseiOSRPC flag and
IsSyncTrustedVaultPassphraseiOSRPCEnabled() function.
IsSyncTrustedVaultPassphraseiOSRPCEnabled() is used by
crrev.com/i/3918561
Bug: 1100278
Change-Id: I06362fa4172e2995c53c25d8bbe9dff9a4e1c046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973109
Commit-Queue: Jérôme <jlebel@chromium.org >
Reviewed-by: Mikel Astiz <mastiz@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894611}
2021-06-22 10:32:48 +00:00
1e4d8367a0
Roll src-internal from 8374d06b6b3a to 74a4b7dc59ab (1 revision)
...
8374d06b6b..74a4b7dc59
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC elklm@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: elklm@google.com
Change-Id: I20ffd86ad1f30b8059ef8ff3bffe1fcf15ff383d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2978731
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#894610}
2021-06-22 10:32:38 +00:00
123607bf4f
Settings: Convert safety_check_page/ to Polymer class syntax.
...
Bug: 1206112
Change-Id: I5661a148bcdf1b89f7eb76ac94d48434fccd2204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2975560
Commit-Queue: Rainhard <rainhard@chromium.org >
Auto-Submit: dpapad <dpapad@chromium.org >
Reviewed-by: Rainhard <rainhard@chromium.org >
Cr-Commit-Position: refs/heads/master@{#894609}
2021-06-22 10:31:08 +00:00