Now that code coverage script works on iOS platform no different from
other platforms, it doesn't make sense to keep the iOS specific code
coverage docs anymore.
Bug: 800876
Change-Id: If9344e7283dae05255cc5518609dced2f4367593
Reviewed-on: https://chromium-review.googlesource.com/950469
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541158}
Add another section to explain that -d and -s arguments to iossim
are optional and may require installing additional components in
Xcode.
Bug: none
Change-Id: Iafb4e61d78be799f56862357e5e02c1d4f785dab
Reviewed-on: https://chromium-review.googlesource.com/897484
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533618}
iossim no longer automatically launches the Simulator, that must be
done manually. Also, macOS 10.12 is required for Xcode 9.
TBR=rohitrao
Bug: none.
Change-Id: Icab37c48a6b79fbbe3e5a99b89a67058e215ca98
Reviewed-on: https://chromium-review.googlesource.com/824562
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523786}
Create documentation on how to run different iOS test suites.
TBR: huangml
Bug: 769753
Change-Id: I1e63c6c603a10389ccc89050b01e075fd08e39ae
Reviewed-on: https://chromium-review.googlesource.com/772784
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517095}
BrowserWebStateListDelegate is responsible for the creation of the
tab helpers attached to all the WebStates for a given Browser. The
tab helpers may have indirect dependencies on BrowserList.
To prevent such a cycle to appear, introduce a factory to inject
the WebStateListDelegate passed to the BrowserList, and split the
target that define the BrowserList implementation and the factory.
Convert BrowserList to a KeyedService to use the infrastructure
to ensure the WebStateListDelegate injection happens at the correct
time, and fix all uses of BrowserList::FromBrowserState() to use
the factory instead.
Bug: 761537
Change-Id: I5a16571abb695bf5b76fc7e58a689ad7b93abd36
Reviewed-on: https://chromium-review.googlesource.com/649612
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500104}
Pull the ios-specific language out of the overall Chromium Objective-C
style guide and into a team-specific document.
Removed outdated language about IBOutlets, since we don't use xib
files any more.
Bug:
Change-Id: Ic2fd5f0a15db97e1b62b8c22bc91842c4cda6346
Reviewed-on: https://chromium-review.googlesource.com/616720
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495123}
Add documentation for part of the architecture of Chrome on iOS. In
particular how ApplicationContext, ChromeBrowserState, BrowserList,
Browser, WebStateList and WebState are related and used.
Bug: none
Change-Id: I1354044f6be00eb04b8f9c147190399aa16f7a62
Reviewed-on: https://chromium-review.googlesource.com/603720
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493424}
This CL mentions iossim's -c option for passing aruments to the test app in the
iOS build instructions.
Bug: None
Change-Id: I80ccddb56e142b547117297ae0fdb85e2b8d63f3
Reviewed-on: https://chromium-review.googlesource.com/575047
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487441}
EarlGrey tests are run differently than other iOS targets, so this
should be document.
Bug:
Change-Id: I112108008a85f810b7e96fb0241b1c8277ec9ea9
Reviewed-on: https://chromium-review.googlesource.com/567918
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485951}
According to the Apple documentation [1], the main binary of an iOS
application bundle should have the same name as the bundle without
the .app suffix and if the bundle name is defined it should have the
same value (only required for non-application bundles if resources
are loaded from the bundle).
Change build/config/ios/codesign.py to enforce those requirements and
fix the ios_remoting_app_tmpl used by chrome remoting iOS application.
This fix an incremental build always being considered dirty because
the ios_app_bundle template requires the correct naming of the binary
of the application bundle but did not enforce it previously.
Bug: 740476
Change-Id: I045dd3a393c96a0240f78bab303a241de967cfcd
Reviewed-on: https://chromium-review.googlesource.com/565401
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485598}
Using the newly created bundleid and mobileprovision, the search widget
can be integrated in the application alongside the current today widget.
When running on device after this check-in, it is necessary to install
the SearchTodayExtension mobileprovision.
BUG=622743, 682230
Review-Url: https://codereview.chromium.org/2814783003
Cr-Commit-Position: refs/heads/master@{#465606}
- The script setup-gn.py is not run as part of `gclient runhooks`
upstream, so update the documentation to not say the opposite.
- Fix an error in the setup-gn.py that treated any non-empty
value for FORCE_MAC_TOOLCHAIN environment variable as a `True`
(in python any non-empty string is `True` in a boolean context).
BUG=None
Review-Url: https://codereview.chromium.org/2804633002
Cr-Commit-Position: refs/heads/master@{#462065}
