
This is mostly the same base change with an addition to AXObjectCacheImpl::AddDirtyObjectToSerializationQueue. On the test flake, despite adding dirty objects, Blink a11y never re-serialized. It looks as though, depending on when exactly PdfAccessibilityTree adds the dirty object, it may fall into post lifecycle hooks, leading to no further scheduled updates. > Original change's description: > > [pdf-a11y]: reduce dependencies between RenderAccessibility and PdfAccessibilityTree > > > > Sparked by the insight that PdfAccessibilityTree has access directly to > > the WebPluginContainer on initialization (slightly after construction). > > > > Simplifications result. > > > > R=aleventhal@chromium.org > > > > Bug: 324124958 > > Test: cq > > Change-Id: I588d1bbd6f99806666fd34394db5cf54db092e93 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263060 > > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1258225} > > > > Bug: 324124958 > Change-Id: Ic4551f5c1864620864140d5294643db63552840c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5281142 > Owners-Override: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1258403} Bug: 324124958 Change-Id: I0101c30c0d3c56de5f227fe73fe8822f335357c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282435 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1261779}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.