0
Files
src/docs
David Bokan 377fb3e653 Reland "Don't run NavigationThrottles on page activations"
This is a reland of 7d90f2699d which was
speculatively reverted but was not the root cause of the issue.

Original change's description:
> Don't run NavigationThrottles on page activations
>
> Background reading:
> https://groups.google.com/u/1/a/chromium.org/g/navigation-dev/c/RJVDOjG8sQ4
>
> https://docs.google.com/document/d/1aNCGTjfRg9KwNYIz6oA8VKZ8EjD2nLA9OfwcJ9dTUxc/edit#heading=h.w2ddswjnb45
>
> For an activating navigation like activating a prerendered page, or
> restoring a page from the BackForward cache, NavigationThrottles have
> already run when the page was navigated and loaded the first time. We
> don't want to run throttles a second time when activating the page to
> become primary.
>
> This CL avoids registering throttles when the NavigationRequest is a
> page activating request. We still proceed through the navigation using
> calls on NavigationThrottleRunner since that's pretty tightly coupled to
> the phases of a NavigationRequest.
>
> Summary:
>
>  * Remove two BFCache tests (added in https://crrev.com/c/1760220) that
>    were checking behavior of throttles on restoration, these are no
>    longer relevant.
>  * TestNavigationManager is used to pause at certain points in a
>    navigation. It uses a throttle to do this today. This CL adds a
>    CommitDeferringCondition instead where the request is PageActivating
>    to allow callers to pause at the equivalent stage. (this means such
>    callers cannot use WaitForRequestStart)
>  * Fixes NavigationSimulatorImpl to work for activating navigations
>    without throttles.
>
> Bug: 1199724
> Change-Id: I61e58912acf865cb4b82fc97ccf26d8808b61a9e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911320
> Commit-Queue: David Bokan <bokan@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#889886}

Bug: 1199724
Change-Id: Ie9fd0e3ab6f90296fe14521d6ab8f4d232f86336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945384
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Owners-Override: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890798}
2021-06-09 16:19:57 +00:00
..
2021-06-07 17:11:42 +00:00
2021-05-20 20:45:17 +00:00
2021-06-08 14:38:25 +00:00
2021-05-10 15:59:20 +00:00
2020-09-09 20:57:05 +00:00
2020-12-02 16:55:28 +00:00
2021-04-29 16:52:25 +00:00
2021-05-13 16:07:33 +00:00
2021-05-13 16:07:33 +00:00
2021-05-17 18:38:25 +00:00
2021-05-13 21:01:41 +00:00
2021-02-09 20:36:22 +00:00
2021-03-09 16:50:41 +00:00
2020-08-25 17:15:12 +00:00
2021-04-15 21:38:26 +00:00

Chromium docs

This directory contains chromium project documentation in Gitiles-flavored Markdown. It is automatically rendered by Gitiles.

If you add new documents, please also add a link to them in the Document Index below.

[TOC]

Creating Documentation

Markdown documents must follow the style guide.

Preview local changes using md_browser:

# in chromium checkout
./tools/md_browser/md_browser.py

This is only an estimate. The gitiles view may differ.

  1. Upload a patch to gerrit, or receive a review request. e.g. https://chromium-review.googlesource.com/c/572236
  2. View a specific .md file. e.g. https://chromium-review.googlesource.com/c/572236/2/docs/README.md
  3. Click on gitiles link at top of page.

This gitiles view is the authoritative view, exactly the same as will be used when committed.

Document Index

Checking Out and Building

Design Docs

Integrated Development Environment (IDE) Set Up Guides

Git

Clang

General Development

Testing

Misc Linux-Specific Docs

Misc MacOS-Specific Docs

Misc Windows-Specific Docs

Misc Android-Specific Docs

Misc iOS-Specific Docs

Misc Chrome-OS-Specific Docs

Misc WebUI-Specific Docs

Media

Accessibility

Memory

Memory Infrastructure Timeline Profiling (MemoryInfra)

Metrics

Misc

Mojo & Services

Speed

  • Chrome Speed - Documentation for performance measurements and regressions in Chrome.
  • Chrome Speed Metrics - Documentation about user experience metrics in the web and their JavaScript APIs.

Probably Obsolete