23b0fa5c07
Before this CL, `RenderWidgetHostViewMac::is_visible_` and RenderWidgetHostViewCocoa's NSView hidden state was desynced until the former is explicitly updated. `RenderWidgetHostViewMac::is_visible_` is initialized as false. However, as mek@ found in https://crrev.com/c/4808654 , the NSView is initially set to visible. This CL fixes the issue by setting RenderWidgetHostViewCocoa as hidden as soon as after it is created, to be consistent with the initial status of `RenderWidgetHostViewMac::is_visible_ = false` Please refer to go/mystery2 for more detailed explanation. Test: Tested manually. Since the issue is flaky and synthetic inputs are routed correctly, this is hard to test via code. Bug: 326509142 Change-Id: I60a237470a1bc7197192b9c21e4bd0a46f739170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404373 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1280970}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.