5439f8eb1e
Changes the LogMessage class to use a string_view for file names. This required a matching change in trace_event: a const char* string was passed from logging code, but there is no safe way to get a const char* from a string_view since the latter may not be null-terminated. Many clients of base/logging.h are updated to use string_view as well. Code which attempts to pass a string_view to a LogMessage by its data pointer already exists: https://source.chromium.org/chromium/chromium/src/+/main:ash/quick_pair/common/logging.cc;l=49;drc=c6c99d03b1d2f4fab91d6be8665f81b540690c73 https://source.chromium.org/chromium/chromium/src/+/main:components/cross_device/logging/logging.cc;l=30;drc=00704dbac4f63b2476aac319572ffc42c9b71fc2 Desire for Rust logging support prompted this change. In principle a Rust log facility can be a thin wrapper around the base logging implementation, but Rust has almost no support for null-terminated strings. Instead, Rust provides a string_view equivalent built in to the language. This change enables Rust code to pass file names obtained by language-specific macros to the C++ implementation. Bug: None Change-Id: I21b4f1c945b70d54f66d80adf3dcda1fe5a39f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5765705 Reviewed-by: Peter Boström <pbos@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Stephen Nusko <nuskos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1436283}
v8
@ d2a21bd413
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.