5fc5aeb38f
ScopedSdkInitializer has an IsSDKInitializedViaPlugin() call that assumes the call can return true, and skip SDK initialization. This may have been possible about a decade ago, but modern //pdf code separates the two types of use cases, as enforced by `public` headers in //pdf/BUILD.gn: 1) Blink plugin code only run in PDF renderer processes, via //pdf/pdf_view_web_plugin.h. 2) Various utilities only run in service processes and tests, via //pdf/pdf.h. As such, ScopedSdkInitializer is only used in //pdf/pdf.cc, so it only has to deal with uses cases of type (2). Without any type (1) overlap, IsSDKInitializedViaPlugin() should always return false. Change-Id: Idff67d6283d8f6229c5d3e84c7c72f4cd799cce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5395192 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Andy Phan <andyphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1278456}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.