688c2ec3ef
For Windows builds, when an action depends on a shared library, only .dll.lib is added as a Ninja input. https://source.chromium.org/chromium/chromium/src/+/main:build/toolchain/win/toolchain.gni;l=509;drc=cbb59f8b903ad736f317885c2943fcbc50f77727 Thus, actions that depend on shared libs need to specify .dll to inputs when necessary. When solink steps run locally, it's not a problem with the missing inputs. But, when running solink steps remotely without bytes (= don't download remote outputs by default), this becomes an issue because .dll isn't stored on local disk. This CL adds missing .dll inputs to //chrome/credential_provider:gcp_installer and //chrome/installer/mini_installer:mini_installer_archive explicitly. Bug: 370860664 Change-Id: I37a51e7a82368cb1f63afee7778b52f4bd732360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347536 Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1431543}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.