9e137eaf38
Previously, the permission request callback used base::Unretained(this). This assumed that the GeolocationServiceImpl would always outlive the permission request. However, if the owning RenderFrameHost is destroyed before the permission request completes, the callback would be invoked on a destroyed GeolocationServiceImpl instance, leading to a crash. To fix this, this CL replaces base::Unretained(this) with weak_factory_.GetWeakPtr(). This ensures that the callback is only executed if the GeolocationServiceImpl instance is still valid. If the instance has been destroyed, the WeakPtr will become invalid, and the callback will be safely skipped. Bug: 396303129 Change-Id: Ic2a71bce5eb90f04957e1d85e8f31b824c93ad93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6266168 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Alvin Ji <alvinji@chromium.org> Cr-Commit-Position: refs/heads/main@{#1422352}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.