chromium/src
0
Fork 0
Code Activity
Files
c00a82207919bc98340dc417e76b083a9c20e1a1
src/cc/raster
History
Arthur Sonzogni 91423838c1 C++11 std::array rewrite for memory safety [12/19] 
Split from:
https://chromium-review.googlesource.com/c/chromium/src/+/6004959/21

Generated patch
---------------
- Tool: ./tool/clang/spanify/rewrite-multiple-platform.sh
- Platform: Linux.
- Filter: This includes 2400/4222 patches. I included the std::array
      ones and excluded build errors.

Google announcement:
--------------------
https://groups.google.com/a/google.com/g/chrome-memory-safety/c/RMiO4gaVLQA/m/Yz-3NCObAgAJ

Benchmarks:
----------
See design doc and
https://chromium-review.googlesource.com/c/chromium/src/+/6004959/21

Description
-----------
The consensus during the memory safety summit was to begin rewriting
relevant C-style arrays to C++11 std::array. It can be done immediately,
offers better developer ergonomics, and fix large chunks of the
-Wunsafe-buffer-usage errors in Chrome.

To clarify, this effort is complementary to the longer plan work with
enabling -fsanitize=array-bounds, and we plan to leverage both,
especially for protecting 3p code.

[Attached] is a document detailing the rationale, benefits, and
considerations for potential compile-time and performance impacts.

[Attached]:https://docs.google.com/document/d/1z5aBDg26lHmNDjXRCysElWKx7E4PAJXqykI_k7ondJI/edit?tab=t.0#heading=h.cqgo7wvp0kzt

NO_IFTTT=No need to update base/debug/stack_trace.h

Bug: 378069401
Change-Id: I9a0271e4b45a2be44dfbb30e95d267745765b5fa
R: dcheng@chromium.org
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6044118
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395060}
2024-12-11 13:06:30 -08:00
..
bitmap_raster_buffer_provider.cc
Rename SharedImageUsage.
2024-12-06 22:25:26 +00:00
bitmap_raster_buffer_provider.h
Make RasterBufferProvider self-flushing.
2023-07-05 21:35:41 +00:00
categorized_worker_pool_unittest.cc
[CodeHealth] Remove stale base::Feature UseCompositorJob
2024-11-06 20:41:29 +00:00
categorized_worker_pool.cc
[CodeHealth] Remove stale base::Feature UseCompositorJob
2024-11-06 20:41:29 +00:00
categorized_worker_pool.h
[CodeHealth] Remove stale base::Feature UseCompositorJob
2024-11-06 20:41:29 +00:00
DIR_METADATA
[buganizer] Migrate DIR_METADATA for cc/
2024-01-16 20:38:00 +00:00
gpu_raster_buffer_provider.cc
[CodeHealth] Cleanup UseDMSAAForTilesAndroidGL feature
2024-11-22 10:16:24 +00:00
gpu_raster_buffer_provider.h
[//cc] Rip out RasterCapabilities::tile_texture_target
2024-03-05 09:21:46 +00:00
lcd_text_disallowed_reason.cc
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
lcd_text_disallowed_reason.h
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
one_copy_raster_buffer_provider.cc
Rename SharedImageUsage.
2024-12-06 22:25:26 +00:00
one_copy_raster_buffer_provider.h
[//cc] Rip out RasterCapabilities::tile_texture_target
2024-03-05 09:21:46 +00:00
paint_worklet_image_provider.cc
Update header includes for /base/functional in /cc
2023-01-07 00:52:17 +00:00
paint_worklet_image_provider.h
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
playback_image_provider_unittest.cc
Use moved Skia Ganesh headers
2024-09-04 01:32:55 +00:00
playback_image_provider.cc
Rename {absl => std}::optional in //cc/
2023-11-10 14:18:10 +00:00
playback_image_provider.h
Exclude cc::ImageDecodeCache from raw_ptr
2024-05-22 16:01:52 +00:00
raster_buffer_provider_perftest.cc
C++11 std::array rewrite for memory safety [12/19]
2024-12-11 13:06:30 -08:00
raster_buffer_provider_unittest.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
raster_buffer_provider.cc
Migrate to NOTREACHED() in cc/
2024-09-24 18:04:39 +00:00
raster_buffer_provider.h
Fix the use of incorrect namespaces in //cc
2024-01-18 15:56:19 +00:00
raster_buffer.cc
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
raster_buffer.h
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
raster_query_queue.cc
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
raster_query_queue.h
DanglingPointer: annotate for unittests base+linux [1/N]
2023-06-01 15:02:25 +00:00
raster_source_unittest.cc
C++11 std::array rewrite for memory safety [12/19]
2024-12-11 13:06:30 -08:00
raster_source.cc
[RasterInducingScroll] Collect discardable images under DrawScrollingContentsOp
2024-06-27 22:15:48 +00:00
raster_source.h
Refactor public API of cc:DisplayItemList
2024-07-02 17:15:45 +00:00
scoped_grcontext_access.h
Manual raw_ptr rewrite: cc/raster/scoped_grcontext_access.h
2023-06-16 21:03:51 +00:00
single_thread_task_graph_runner_unittest.cc
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
single_thread_task_graph_runner.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
single_thread_task_graph_runner.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
staging_buffer_pool_unittest.cc
task posting v3: moving away from ThreadTaskRunnerHandle
2022-11-21 15:32:47 +00:00
staging_buffer_pool.cc
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
2024-04-22 19:33:31 +00:00
staging_buffer_pool.h
Rewrite std::set<T*> into std::set<raw_ptr<T, SetExperimental>>
2024-02-09 14:01:52 +00:00
synchronous_task_graph_runner_unittest.cc
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
synchronous_task_graph_runner.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
synchronous_task_graph_runner.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
task_category.h
Update copyright headers in cc/
2022-09-08 20:55:42 +00:00
task_graph_runner_perftest.cc
C++11 std::array rewrite for memory safety [12/19]
2024-12-11 13:06:30 -08:00
task_graph_runner.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
task_graph_work_queue_unittest.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
task_graph_work_queue.cc
Correctly handle external dependencies for canceled tile tasks
2024-10-29 17:05:31 +00:00
task_graph_work_queue.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
task.cc
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
task.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
tile_task.cc
Allow an external dependent TileTask to be replaced if it's canceled
2024-11-01 22:03:39 +00:00
tile_task.h
Add concept of "external dependency" to cc::TileTask
2024-10-18 18:44:43 +00:00
zero_copy_raster_buffer_provider.cc
[//cc] Spanify RasterBufferProviders' calls of ScopedMapping::Memory()
2024-10-10 07:17:40 +00:00
zero_copy_raster_buffer_provider.h
[//cc] Rip out RasterCapabilities::tile_texture_target
2024-03-05 09:21:46 +00:00