c3b03219e1
Field trial group names should be decoded with urllib.parse.unquote_plus, not unquote. This fixes a bug where encoding in split_variations_cmd.py disagrees with the encoding of Chromium (https://source.chromium.org/chromium/chromium/src/+/main:components/variations/field_trial_config/field_trial_util.cc;l=209-212) which is %-encoded (URL encoded). unquote_plus is a function that performs the same operation as unquote but also replaces plus signs with spaces. This results in strings being equally decoded. This CL contains a unit test that is run against two values: one with +:Scale+120% and one with space: Scale 120%. Change-Id: I9393bd30fea4daf86e538d77dcb585bee794c628 Bug: 40218235 Change-Id: I9393bd30fea4daf86e538d77dcb585bee794c628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179892 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Milena Krawczyk <mikr@google.com> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#1418213}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.