c439564119
>>> This change does only have functional changes on Windows <<< Support has recently been added in chrome://media-internals to show the combined effect mask if system effects are supported. Example: "ECHO_CANCELLER | NOISE_SUPPRESSION | AUTOMATIC_GAIN_CONTROL" Up until now, the logic in ProcessedLocalAudioSource has modified this mask if constraints disabled NS or AGC and that is not correct on Windows since AEC, NS and AGC can't be controlled separately. This new version ensures that if AEC has been disabled by the constraints and system AEC exists, then system NS and AGC are also disabled. If AEC is enabled and system AEC is supported, nothing is changed for system NS or AGC *even if* they are disabled by constraints since that would imply that e.g. NOISE_SUPPRESSION | AUTOMATIC_GAIN_CONTROL would be a valid result in chrome://media-internals and it is *not*. The CL also improves logging and shows all places where system effects are modified in a clear FROM => TO syntax. Tested using https://henrik-and.github.io/echo-demo/ in combination with chrome://media-internals while checking Chrome logs with the PLAS:: prefix. Example of new log style: PLAS::EnsureSourceIsStarted() => (AEC: modified system effect mask from [ECHO_CANCELLER | NOISE_SUPPRESSION | AUTOMATIC_GAIN_CONTROL] to [NONE]) See https://paste.googleplex.com/5287569649303552 for examples of the new functionality. Bug: 393098901 Change-Id: Idc7a17af9a5fa532cefb7975df7db0ee261b01ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330346 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/main@{#1431488}
v8
@ 10315155d8
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.