c57d2df361
Following recent conversations with relevant Chromium on iOS folks, it was decided that it made more sense for now to reverse one of the decisions from https://crrev.com/c/6197019 and stop making the tvOS and iOS builds be completely independent of each other: having them be completely separate would require too many changes in GN, .grd, .py and C++/Objective-C++ files in the tree (and even more so if we started renaming the _ios.{mm,cc,h} files to something more generic). More succinctly, this means that IS_IOS_TVOS in C++ and `target_platform` in GN are set if and only if IS_IOS and is_ios are set too, and iOS files and code paths are built on tvOS by default (rather than being opt-in). This CL implements this reversal while also making a few more adjustments: * The `is_tvos` GN flag is now called `target_platform` and takes "iphoneos" (default), "tvos" or "watchos" as values at the moment. As mentioned, it is set only if `is_ios` is also true (i.e. the target toolchain is being used). Files used by multiple toolchains may need to check for `is_ios` as well before referencing it. * The GN flag is no longer being set in the main BUILDCONFIG.gn file, but rather in one of the files in //build/config/apple. Build system files that need to check this variable need to explicitly import this file. * `BUILDFLAG(IS_TVOS)` is now `BUILDFLAG(IS_IOS_TVOS)` in C++. Bug: 391990604, 391914246, 397889862 Change-Id: I7862cf63074b8ff75b4b58c911212d4652cae113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6306066 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Raphael Kubo da Costa <kubo@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1426638}
v8
@ 3a5209f8a0
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.