ec90e8ab4c
This reverts commit 73c5483092.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5634425183272960
Sample build with failed test: https://ci.chromium.org/b/8739458243085250689
Affected test(s):
[ninja://base:base_unittests/ComInitUtil.AssertNotInitialized](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fbase:base_unittests%2FComInitUtil.AssertNotInitialized?q=VHash%3Afb6488203f29390f)
[ninja://base:base_unittests/ComInitUtil.AssertUninitialized](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fbase:base_unittests%2FComInitUtil.AssertUninitialized?q=VHash%3Afb6488203f29390f)
[ninja://base:base_unittests/TestComInitBalancer.BalancedPairsWithComBalancerDisabled](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fbase:base_unittests%2FTestComInitBalancer.BalancedPairsWithComBalancerDisabled?q=VHash%3Afb6488203f29390f)
[ninja://base:base_unittests/TestComInitBalancer.BalancedPairsWithComBalancerEnabled](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fbase:base_unittests%2FTestComInitBalancer.BalancedPairsWithComBalancerEnabled?q=VHash%3Afb6488203f29390f)
[ninja://base:base_unittests/TestComInitBalancer.UnbalancedPairsWithComBalancerDisabled](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fbase:base_unittests%2FTestComInitBalancer.UnbalancedPairsWithComBalancerDisabled?q=VHash%3Afb6488203f29390f)
and 1 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5634425183272960&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5785451&type=BUG
Original change's description:
> Migrate to NOTREACHED() in base/
>
> NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
> The former is [[noreturn]] so this CL also performs dead-code removal
> after the NOTREACHED().
>
> This CL does not attempt to do additional rewrites of any surrounding
> code, like:
>
> if (!foo) {
> NOTREACHED();
> }
>
> to CHECK(foo);
>
> Those transforms take a non-trivial amount of time (and there are
> thousands of instances). Cleanup can be left as an exercise for the
> reader.
>
> Bug: 40580068
> Change-Id: I0ecf27cba78fa49bd17653b8df63ad276ee915d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5785451
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Owners-Override: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1342705}
>
Bug: 40580068, 360367065
Change-Id: Id70b5a48a8385c0b7bbf151fdb04b414fd94697f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5792456
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Owners-Override: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342866}
v8
@ 3ae9e81411
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.