fc7e46cc33
This is a speculative fix for an issue in Edge where Compositor Frames are submitted with surface ranges that have invalid local_surface_id's. The issue started due to change:5348259. The hypothesis is that if TakeScopedKeepSurfaceAliveCallback is called with an invalid local_surface_id_, the LayerTreeHost will still register the associated surface range. However, the CopyOutputRequest will not be fulfilled because CopyFromCompositingSurfaceInternal will early out if the local_surface_id_ is invalid. Therefore, the SurfaceRange is added to the commit state but never removed. When it's time for SubmitCompositorFrame, an invalid SurfaceRange can be present in the list. In order to fix this issue, check whether the local surface is valid for copy before calling TakeScopedKeepSurfaceAliveCallback. Bug: 40276723 Change-Id: I6d2591ed0ee98ba0414887ea7611d640788d607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216395 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Shubham Gupta <shubham.gupta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1422253}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.