fe7c68665f
This reverts commit ebdf9a5065.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6006623857278976
Sample build with failed test: https://ci.chromium.org/b/8723813648107834593
Affected test(s):
[ninja://content/test:content_browsertests/PrerenderBrowserTest.CancelOnPreferredSizeChanged](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FPrerenderBrowserTest.CancelOnPreferredSizeChanged?q=VHash%3A2d14ec82adda2392)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6006623857278976&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5905939&type=BUG
Original change's description:
> Browser process implementation of navigation confidence
>
> To enable developers to discern if the navigation timings are
> representative for their web application, the change adds a new
> ‘confidence’ field to the PerformanceNavigationTiming struct. The
> confidence field should not be populated until the confidence value is
> finalized.
>
> The renderer host will be responsible for finalizing the confidence
> value, applying the local randomized response algorithm, and then
> sending that information to the renderer process when the underlying document is interactive.
>
> To accomplish that, there are a few changes that need to be made:
>
> 1) Add confidence field to DocumentAssociatedData. The confidence
> field lifetime should match the lifetime of the blink::Document
> class. This value is updated by RenderFrameHostImpl as part of
> committing the navigation.
> 2) Add confidence field to NavigationRequest. The confidence field is
> set in the constructor. The value is used by RenderFrameHostImpl
> to set the confidence value in the DocumentAssociatedData.
>
> The render will notify the RenderFrameHostImpl that the document
> is now interactive (which occurs after the responseEnd mark is set),
> and the RenderFrameHostImpl will then push down the noisy confidence
> value into the renderer process.
>
>
> Explainer:
> https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/PerformanceNavigationTiming%20for%20User%20Agent%20Launch/explainer.md
> Chrome Status: https://chromestatus.com/feature/5186950448283648
> Dev Design:
> https://docs.google.com/document/d/1D6DqptsCEd3wPRsZ0q1iwVBAXXmhxZuLV-KKFI0ptCg/edit?usp=sharing
> I2P:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/o0F7nBKsgg0/m/bJSp3ekfAAAJ
> W3C Issue: https://github.com/w3c/navigation-timing/issues/202
>
> Manual testing steps:
>
> 1) Start the browser with these command line parameters:
> --enable-features=PerformanceNavigationTimingConfidence
> https://example.com 2) Open the developer tools, and switch to the
> Console tool. 3) Run
> "window.performance.getEntriesByType('navigation')[0].confidence" into
> the console, and you should see both a confidence value, and a
> randomizedTriggerRate.
>
> Bug: 1413848
> Change-Id: I300357ab8198a43f97b922c4b9f2d0e819dba7fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905939
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Commit-Queue: Mike Jackson <mjackson@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1415930}
>
Bug: 1413848
Change-Id: I2e47df525f53dd2710b75aa82d133be79f77bf0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6232563
Owners-Override: Alexander Bolodurin <alexbn@google.com>
Commit-Queue: Alexander Bolodurin <alexbn@chromium.org>
Reviewed-by: Ben Reich <benreich@chromium.org>
Reviewed-by: Alexander Bolodurin <alexbn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1415986}
v8
@ 0f87a54dad
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.