Legacy SwiftShader GL is deprecated, so remove it from existing
documentation, so that only SwANGLE related documentation remains.
Bug: chromium:1060139
Change-Id: I1a59d7b4a57f80cbe627df0a77430450296df607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3452836
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@google.com>
Cr-Commit-Position: refs/heads/main@{#969936}
Moves inactive GPU experimental testers to the new
chromium.gpu.experimental console. This console is intended to be used
for parking inactive GPU experimental testers until they are needed
again in order to declutter the chromium.gpu.fyi console.
These testers have already been paused.
Bug: 1280441
Change-Id: If035c502b40a88c3dd54da5dd6236c6e88dcfb57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345549
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#955514}
Updates the Markdown documentation about building/running GPU
integration tests to refer to the correct targets and include some
additional details that may be helpful to people that are unfamiliar
with the tests.
Bug: 1270361
Change-Id: I6eb787b7abbc9e9d24672b626c93dacd7ac42bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283629
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941916}
Updates the following in the GPU documentation:
1. Links to the Skia Gold instance. There were still references to the
old chrome-gpu-gold.skia.org instance that has been gone for a long
time.
2. Links to the pixel_wrangling.md documentation, which has been moved
to various internal documentation pages.
Bug: 1250846
Change-Id: Ib72b870c91a8048bbe4568256ff1845c2d72d7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173927
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#924044}
Currently, Chrome uses legacy SwiftShader GL as the WebGL fallback when
a hardware GPU isn't usable for the purpuse of rendering WebGL content.
As we're in the process of changing legacy SwiftShader GL to SwANGLE,
this CL adds a new flag which allows using SwANGLE for WebGL only.
To clarify, current switches with legacy SwiftShader GL:
Software GL: --use-gl=swiftshader
Software WebGL only: --use-gl=swiftshader-webgl
With SwANGLE, the new switches will be:
Software GL: --use-gl=angle --use-angle=swiftshader
Software WebGL only: --use-gl=angle --use-angle=swiftshader-webgl
Bug: chromium:1060139
Change-Id: I8d0382ac3a12c1578dfc0e62fc1949a0a9c66bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2845229
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#876794}
Updates //docs/gpu/gpu_testing.md in a few ways:
1. Clarifies that vpython should be used instead of python
2. Explicitly lists all Telemetry-based test suites and the names they
can show up as on the bots. This list was generated by parsing the
//testing/buildbot JSON files.
3. Updates the instructions on how to obtain the command used to run
a test on swarming and how to download an isolate.
Bug: 1199154
Change-Id: I21bbbe7341d8788ef9e0715e5c090b8cc37469ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2828908
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#873436}
Updates the GPU documentation on adding new builders/testers to clarify
what to do if adding both a new parent builder and a tester triggered by
it, as it turns out that it's not as simple as performing the
tester-only steps two separate times.
Change-Id: Iddb3336db0fc12a22e8cb73ac6aa3dffe13f0ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613667
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840824}
Updates the GPU pixel wrangling documentation to point out
//content/test/gpu/trim_culprit_cls.py as a potentially useful tool and
updates the script's documentation to include example usages.
Bug: 1120104
Change-Id: I2026e994408097bfee8b94984dc89e8110afba0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373391
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801232}
Refactors the Skia Gold-related code in //content/test/gpu/gpu_tests
to be the same as //build/android/pylib. All the code that interacts
with Gold is encapsulated in its own class, and users simply run one
method and check its output to perform an image comparison.
Also adds a bunch of unittests (also taken from //build/android/pylib)
since the split makes the code unittest-able.
Drive-by fixes a related TODO in //build/android since the same TODO
was fixed in the GPU code in this CL.
Bug: 1093994
Change-Id: Id2fe1506796695f258069334149550cfaea49f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243718
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778514}
Adds an '"ignore": "1"' pair to the JSON for GPU pixel tests if a test
has a grace period active. This is so that newly added noisy tests do
not affect unrelated CLs by causing Gold to comment on them because they
happened to produce a new image due to bad luck.
Bug: 1081942
Change-Id: Ife8dbe1baa349c203a4e95d7a152cb42d29d384f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199908
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768520}
Updates gpu_testing_bot_details.md with the following:
1. An updated reference CL for adding a manual-only trybot.
2. Updated locations for *.star files.
3. Console and builder definitions taking place in the same file.
Change-Id: I7930c32807f590a9d8000fa8e06e95774889744d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195326
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#767607}
Adds a script to find optimal values for inexact matching in the GPU
pixel tests and enables inexact matching on several problematic tests
that could benefit from it.
Bug: 1074130
Change-Id: If4597bbda1a94fdc4dd28f87ca59ea86489c2ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173415
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764424}
Switches all tests that use Skia Gold to use a mixin instead of
individually specifying arguments in each test definition. As a
prerequisite, also ensures that all test types that use Skia Gold use
the same naming for Gold-related arguments.
This is requisite work for adding a universal Gold kill switch in the
unlikely event of an outage that can't be fixed quickly, as the switch
can just be added to the mixin.
Bug: 1057848
Change-Id: Ib57480f374eab088ac3a389637bfbff1ee41e8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121419
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755521}
Updating the Pixel Wrangler docs section on extending the rotation. Making them
more general for modifying the rotation. With a portion about swapping.
Change-Id: Ief4c3ffc86f87fe924e94900c16b017f38e9ed80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037327
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738363}
Supports outputting the closest image known to Gold and its diff with
the produced image when running the GPU pixel tests locally. This should
improve the usability of the tests when debugging locally, as before
they only output the produced image and a link to all images known to
Gold for the test.
Bug: 1030349
Change-Id: I55cd724541f86edf8d6de534bd921d70d03d6eda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949727
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721626}