36ca9de254
To make PdfInkUndoRedoModel work with modeled shapes in addition to strokes: 1) Add PdfInkUndoRedoModel::IdType, which is a variant that can hold either an InkStrokeId or an InkModeledShapeId. 2) Switch PdfInkUndoRedoModel::DrawCommands and EraseCommands to use IdType. 3) Update PdfInkUndoRedoModel internals to support (1) and (2). 4) Rename PdfInkUndoRedoModel::Erase() to EraseStroke(). Update callers. 5) Add PdfInkUndoRedoModel::EraseShape(), which is similar to EraseStroke(), but not identical. 6) Add unit tests for EraseShape(). With PdfInkUndoRedoModel ready to support modeled shapes, update PdfInkModule::ApplyUndoRedoCommandsHelper(). Prior to this CL, it only had to deal with InkStrokeIds. Now it needs to separate out the InkStrokeIds from the InkModeledShapeIds. The InkModeledShapeIds handling remains a TODO for later, when PdfInkModule connects all the pieces together. Bug: 377820805 Change-Id: I87c158481a407c9401ceff1a4d78d3526a05fd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004272 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Andy Phan <andyphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380772}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.