
These functions are not supposed to be called if reporting is disabled (enable_reporting=false). The usages was supposed to be guarded on the caller side by BUILDFLAG(ENABLE_REPORTING). Nonetheless, some of the usages are not guarded and they are still called and cause assert on certain web pages. As a fix, remove the guards where it is possible from the caller site and guard the callee site to do nothing if reporting is disabled. Also enable ReportingServiceProxy for disabled reporting to avoid crash/assert when reporting API is accessed via mojo. Bug: none Test: load https://www.usnews.com/ Change-Id: If2cc6add7eee78e842a4663f857f07bf75cce149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412481 Reviewed-by: Rodney Ding <rodneyding@google.com> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#965655}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.