
Update PDFiumEngine to apply Ink strokes to the in-memory PDF, and to update the stroke active state for undo/redo/erase actions. With visible strokes now existing in the PDF document, they will be drawn automatically along with the rest of the other PDF page objects. Remove the explicit drawing of finished strokes from PdfInkModule, and instead make a client call to invalidate the area for a newly finished stroke. Since PDFiumEngine now tracks PDF page objects for each stroke, add page unload preventers to ensure that pages with Ink strokes do not get unloaded and cause PDFiumEngine to have dangling pointers. Bug: 335517469 Change-Id: Icc7e78996bf328381138e24f96cc9bf41db4346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6003785 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380766}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.