7f36ef9458
Faulty scenario: Before MoveThemePrefsToSpecifics, clients sync ntp backgrounds via prefs and GM2 color theme via ThemeSpecifics. With the flag enabled, the ntp background is removed upon receiving the GM2 color theme from remote, since the ThemeSpecifics does not have the ntp_background field populated yet. This scenario should only occur for ntp background + GM2 color combo, since the other combos which use prefs and ThemeSpecifics to sync cannot co-exist. Fix: Avoid removing ntp background upon receiving an old ThemeSpecifics from remote. This covers the case where the specifics is missing the background not because the ThemeSpecifics didn't have the new fields. Bug: 391114025 Change-Id: Iecccad3859fb7a015b1910df345e594ad3af7fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6177275 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ankush Singh <ankushkush@google.com> Cr-Commit-Position: refs/heads/main@{#1408693}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.